refactor: replace cond with if in handle_delete_role functions
This commit is contained in:
parent
75ab046be4
commit
37a2fc3e83
6 changed files with 31 additions and 33 deletions
|
|
@ -91,20 +91,18 @@ defmodule MvWeb.RoleLive.Show do
|
|||
end
|
||||
|
||||
defp handle_delete_role(role, socket) do
|
||||
cond do
|
||||
role.is_system_role ->
|
||||
if role.is_system_role do
|
||||
{:noreply,
|
||||
put_flash(
|
||||
socket,
|
||||
:error,
|
||||
gettext("System roles cannot be deleted.")
|
||||
)}
|
||||
else
|
||||
user_count = recalculate_user_count(role)
|
||||
|
||||
if user_count > 0 do
|
||||
{:noreply,
|
||||
put_flash(
|
||||
socket,
|
||||
:error,
|
||||
gettext("System roles cannot be deleted.")
|
||||
)}
|
||||
|
||||
true ->
|
||||
user_count = recalculate_user_count(role)
|
||||
|
||||
if user_count > 0 do
|
||||
{:noreply,
|
||||
put_flash(
|
||||
socket,
|
||||
:error,
|
||||
|
|
@ -113,9 +111,9 @@ defmodule MvWeb.RoleLive.Show do
|
|||
count: user_count
|
||||
)
|
||||
)}
|
||||
else
|
||||
perform_role_deletion(role, socket)
|
||||
end
|
||||
else
|
||||
perform_role_deletion(role, socket)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue