Merge pull request 'Don't show birthday field for default configurations closes #161' (#239) from feature/161_remove_birthday into main

Reviewed-on: #239
Reviewed-by: rafael <rafael@noreply.git.local-it.org>

lib/membership/member.ex

@@ -24,7 +24,7 @@ defmodule Mv.Membership.Member do
   - Email format validation (using EctoCommons.EmailValidator)
   - Phone number format: international format with 6-20 digits
   - Postal code format: exactly 5 digits (German format)
-  - Date validations: birth_date and join_date not in future, exit_date after join_date
+  - Date validations: join_date not in future, exit_date after join_date
   - Email uniqueness: prevents conflicts with unlinked users
 
   ## Full-Text Search
@@ -284,11 +284,6 @@ defmodule Mv.Membership.Member do
       end
     end
 
-    # Birth date not in the future
-    validate compare(:birth_date, less_than_or_equal_to: &Date.utc_today/0),
-      where: [present(:birth_date)],
-      message: "cannot be in the future"
-
     # Join date not in the future
     validate compare(:join_date, less_than_or_equal_to: &Date.utc_today/0),
       where: [present(:join_date)],
@@ -351,10 +346,6 @@ defmodule Mv.Membership.Member do
       constraints min_length: 5, max_length: 254
     end
 
-    attribute :birth_date, :date do
-      allow_nil? true
-    end
-
     attribute :paid, :boolean do
       allow_nil? true
     end

lib/mv/constants.ex

@@ -7,7 +7,6 @@ defmodule Mv.Constants do
     :first_name,
     :last_name,
     :email,
-    :birth_date,
     :paid,
     :phone_number,
     :join_date,

lib/mv_web/live/member_live/form.ex

@@ -14,7 +14,7 @@ defmodule MvWeb.MemberLive.Form do
   - first_name, last_name, email
 
   **Optional:**
-  - birth_date, phone_number, address fields (city, street, house_number, postal_code)
+  - phone_number, address fields (city, street, house_number, postal_code)
   - join_date, exit_date
   - paid status
   - notes
@@ -45,7 +45,6 @@ defmodule MvWeb.MemberLive.Form do
         <.input field={@form[:first_name]} label={gettext("First Name")} required />
         <.input field={@form[:last_name]} label={gettext("Last Name")} required />
         <.input field={@form[:email]} label={gettext("Email")} required type="email" />
-        <.input field={@form[:birth_date]} label={gettext("Birth Date")} type="date" />
         <.input field={@form[:paid]} label={gettext("Paid")} type="checkbox" />
         <.input field={@form[:phone_number]} label={gettext("Phone Number")} />
         <.input field={@form[:join_date]} label={gettext("Join Date")} type="date" />

lib/mv_web/live/member_live/show.ex

@@ -10,7 +10,7 @@ defmodule MvWeb.MemberLive.Show do
   - Return to member list
 
   ## Displayed Information
-  - Basic: name, email, dates (birth, join, exit)
+  - Basic: name, email, dates (join, exit)
   - Contact: phone number
   - Address: street, house number, postal code, city
   - Status: paid flag
@@ -48,7 +48,6 @@ defmodule MvWeb.MemberLive.Show do
         <:item title={gettext("First Name")}>{@member.first_name}</:item>
         <:item title={gettext("Last Name")}>{@member.last_name}</:item>
         <:item title={gettext("Email")}>{@member.email}</:item>
-        <:item title={gettext("Birth Date")}>{@member.birth_date}</:item>
         <:item title={gettext("Paid")}>
           {if @member.paid, do: gettext("Yes"), else: gettext("No")}
         </:item>