local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 59 Pull requests 3 Projects 2 Releases Packages 1 Activity Actions

Member: remove system-actor fallback in extract_existing_values

Browse source 
Per guidelines: actor must come from context. When nil, skip load and return empty map.
This commit is contained in:
Moritz 2026-02-23 20:48:13 +01:00
parent 482a335d36
commit 3cdaa75fc1
Signed by: moritz
GPG key ID: 1020A035E5DD0824
1 changed files with 16 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

12
lib/membership/member.ex
View file

@ -1300,12 +1300,15 @@ defmodule Mv.Membership.Member do
end end
end end
# Extracts custom field values from existing member data (update scenario) # Extracts custom field values from existing member data (update scenario).
# Actor must come from context; no system-actor fallback (per guidelines).
# When no actor is present we skip the load and return empty map.
defp extract_existing_values(member_data, changeset) do defp extract_existing_values(member_data, changeset) do
actor = case Map.get(changeset.context, :actor) do
Map.get(changeset.context, :actor) || nil ->
Mv.Helpers.SystemActor.get_system_actor() %{}
actor ->
opts = Helpers.ash_actor_opts(actor) opts = Helpers.ash_actor_opts(actor)
case Ash.load(member_data, :custom_field_values, opts) do case Ash.load(member_data, :custom_field_values, opts) do
@ -1316,6 +1319,7 @@ defmodule Mv.Membership.Member do
%{} %{}
end end
end end
end
# Extracts value from a CustomFieldValue struct # Extracts value from a CustomFieldValue struct
defp extract_value_from_cfv(cfv, acc) do defp extract_value_from_cfv(cfv, acc) do