fix: join confirmation mail configuration

lib/membership/membership.ex

@@ -364,7 +364,8 @@ defmodule Mv.Membership do
     - `:actor` - Must be nil for public submit (policy allows only unauthenticated).
 
   ## Returns
-    - `{:ok, request}` - Created JoinRequest in status pending_confirmation
+    - `{:ok, request}` - Created JoinRequest in status pending_confirmation, email sent
+    - `{:error, :email_delivery_failed}` - Request created but confirmation email could not be sent (logged)
     - `{:error, error}` - Validation or authorization error
   """
   def submit_join_request(attrs, opts \\ []) do
@@ -390,8 +391,7 @@ defmodule Mv.Membership do
               "Join confirmation email failed for #{request.email}: #{inspect(reason)}"
             )
 
-            # Request was created; return success so the user sees the confirmation message
-            {:ok, request}
+            {:error, :email_delivery_failed}
         end
 
       error ->

lib/mv_web/emails/join_confirmation_email.ex

@@ -15,11 +15,11 @@ defmodule MvWeb.Emails.JoinConfirmationEmail do
   @doc """
   Sends the join confirmation email to the given address with the confirmation link.
 
+  Uses the same SMTP configuration as the test mail (Settings or boot ENV) via
+  `Mailer.deliver/2` with `Mailer.smtp_config/0` for consistency.
+
   Called from the domain after a JoinRequest is created (submit flow).
   Returns `{:ok, email}` on success, `{:error, reason}` on delivery failure.
-  Callers should log errors and may still return success for the overall operation
-  (e.g. join request created) so the user is not shown a generic error when only
-  the email failed.
   """
   def send(email_address, token) when is_binary(email_address) and is_binary(token) do
     confirm_url = url(~p"/confirm_join/#{token}")
@@ -32,12 +32,14 @@ defmodule MvWeb.Emails.JoinConfirmationEmail do
       locale: Gettext.get_locale(MvWeb.Gettext)
     }
 
-    new()
-    |> from(Mailer.mail_from())
-    |> to(email_address)
-    |> subject(subject)
-    |> put_view(MvWeb.EmailsView)
-    |> render_body("join_confirmation.html", assigns)
-    |> Mailer.deliver()
+    email =
+      new()
+      |> from(Mailer.mail_from())
+      |> to(email_address)
+      |> subject(subject)
+      |> put_view(MvWeb.EmailsView)
+      |> render_body("join_confirmation.html", assigns)
+
+    Mailer.deliver(email, Mailer.smtp_config())
   end
 end

lib/mv_web/live/join_live.ex

@@ -142,8 +142,22 @@ defmodule MvWeb.JoinLive do
     case build_submit_attrs(params, socket.assigns.join_fields) do
       {:ok, attrs} ->
         case Membership.submit_join_request(attrs, actor: nil) do
-          {:ok, _} -> {:noreply, assign(socket, :submitted, true)}
-          {:error, _} -> validation_error_reply(socket, params)
+          {:ok, _} ->
+            {:noreply, assign(socket, :submitted, true)}
+
+          {:error, :email_delivery_failed} ->
+            {:noreply,
+             socket
+             |> put_flash(
+               :error,
+               gettext(
+                 "We could not send the confirmation email. Please try again later or contact support."
+               )
+             )
+             |> assign(:form, to_form(params, as: "join"))}
+
+          {:error, _} ->
+            validation_error_reply(socket, params)
         end
 
       {:error, message} ->