refactor(web): extract format_ash_error to MvWeb.ErrorHelpers

Use shared ErrorHelpers in UserLive.Index for consistent Ash error formatting.
This commit is contained in:
Moritz 2026-01-27 17:37:23 +01:00 committed by moritz
parent eb8d78f834
commit 41bc031cc6
2 changed files with 28 additions and 13 deletions

View file

@ -26,6 +26,7 @@ defmodule MvWeb.UserLive.Index do
import MvWeb.LiveHelpers, only: [current_actor: 1]
require Ash.Query
import MvWeb.ErrorHelpers, only: [format_ash_error: 1]
@impl true
def mount(_params, _session, socket) do
@ -71,7 +72,7 @@ defmodule MvWeb.UserLive.Index do
)}
{:error, error} ->
{:noreply, put_flash(socket, :error, format_error(error))}
{:noreply, put_flash(socket, :error, format_ash_error(error))}
end
{:error, %Ash.Error.Query.NotFound{}} ->
@ -82,7 +83,7 @@ defmodule MvWeb.UserLive.Index do
put_flash(socket, :error, gettext("You do not have permission to access this user"))}
{:error, error} ->
{:noreply, put_flash(socket, :error, format_error(error))}
{:noreply, put_flash(socket, :error, format_ash_error(error))}
end
end
@ -144,15 +145,4 @@ defmodule MvWeb.UserLive.Index do
defp toggle_order(:desc), do: :asc
defp sort_fun(:asc), do: &<=/2
defp sort_fun(:desc), do: &>=/2
defp format_error(%Ash.Error.Invalid{errors: errors}) when is_list(errors) do
Enum.map_join(errors, ", ", fn
%{message: message} when is_binary(message) -> message
other -> inspect(other)
end)
end
defp format_error(error) do
inspect(error)
end
end