test: updated tests

test/mv_web/member_live/index_test.exs

@@ -74,39 +74,132 @@ defmodule MvWeb.MemberLive.IndexTest do
     assert has_element?(index_view, "#flash-group", "Member create successfully")
   end
 
-  describe "sorting interaction" do
+  describe "sorting integration" do
     test "clicking a column header toggles sort order and updates the URL", %{conn: conn} do
       conn = conn_with_oidc_user(conn)
       {:ok, view, _html} = live(conn, "/members")
 
-      # The component data test ids are built as "<field>"
+      # The component data test ids are built with the name of the field
       # First click – should sort ASC
       view
       |> element("[data-testid='email']")
       |> render_click()
 
       # The LiveView pushes a patch with the new query params
-      assert_patch(view, "/members?sort_field=email&sort_order=asc")
+      assert_patch(view, "/members?query=&sort_field=email&sort_order=asc")
 
       # Second click – toggles to DESC
       view
       |> element("[data-testid='email']")
       |> render_click()
 
-      assert_patch(view, "/members?sort_field=email&sort_order=desc")
+      assert_patch(view, "/members?query=&sort_field=email&sort_order=desc")
+    end
+
+    test "clicking different column header resets order to ascending", %{conn: conn} do
+      conn = conn_with_oidc_user(conn)
+      {:ok, view, _html} = live(conn, "/members?sort_field=email&sort_order=desc")
+
+      # Click on a different column
+      view
+      |> element("[data-testid='first_name']")
+      |> render_click()
+
+      assert_patch(view, "/members?query=&sort_field=first_name&sort_order=asc")
+    end
+
+    test "all sortable columns work correctly", %{conn: conn} do
+      conn = conn_with_oidc_user(conn)
+      {:ok, view, _html} = live(conn, "/members")
+
+      # default ascending sorting with first name
+      assert has_element?(view, "[data-testid='first_name'][aria-label='ascending']")
+
+      sortable_fields = [:email, :street, :house_number, :postal_code, :city, :phone_number, :join_date]
+
+      for field <- sortable_fields do
+        view
+        |> element("[data-testid='#{field}']")
+        |> render_click()
+
+        assert_patch(view, "/members?query=&sort_field=#{field}&sort_order=asc")
+      end
+    end
+
+    test "sorting works with search query", %{conn: conn} do
+      conn = conn_with_oidc_user(conn)
+      {:ok, view, _html} = live(conn, "/members?query=test")
+
+      view
+      |> element("[data-testid='email']")
+      |> render_click()
+
+      assert_patch(view, "/members?query=test&sort_field=email&sort_order=asc")
+    end
+
+    test "sorting maintains search query when toggling order", %{conn: conn} do
+      conn = conn_with_oidc_user(conn)
+      {:ok, view, _html} = live(conn, "/members?query=test&sort_field=email&sort_order=asc")
+
+      view
+      |> element("[data-testid='email']")
+      |> render_click()
+
+      assert_patch(view, "/members?query=test&sort_field=email&sort_order=desc")
     end
   end
 
   describe "URL param handling" do
     test "handle_params reads sort query and applies it", %{conn: conn} do
       conn = conn_with_oidc_user(conn)
-      url = "/members?sort_field=email&sort_order=desc"
+      {:ok, view, _html} = live(conn, "/members?query=&sort_field=email&sort_order=desc")
 
-      conn = get(conn, url)
+      # Check that the sort state is correctly applied
+      assert has_element?(view, "[data-testid='email'][aria-label='descending']")
+    end
 
-      # The LiveView must have parsed the params and stored them as atoms.
-      assert conn.assigns.sort_field == :email
-      assert conn.assigns.sort_order == :desc
+    test "handle_params handles invalid sort field gracefully", %{conn: conn} do
+      conn = conn_with_oidc_user(conn)
+      {:ok, view, _html} = live(conn, "/members?query=&sort_field=invalid_field&sort_order=asc")
+
+      # Should not crash and should show default first name order
+      assert has_element?(view, "[data-testid='first_name'][aria-label='ascending']")
+    end
+
+    test "handle_params preserves search query with sort params", %{conn: conn} do
+      conn = conn_with_oidc_user(conn)
+      {:ok, view, _html} = live(conn, "/members?query=test&sort_field=email&sort_order=desc")
+
+      # Both search and sort should be preserved
+      assert has_element?(view, "[data-testid='email'][aria-label='descending']")
+    end
+  end
+
+  describe "search and sort integration" do
+    test "search maintains sort state", %{conn: conn} do
+      conn = conn_with_oidc_user(conn)
+      {:ok, view, _html} = live(conn, "/members?query=&sort_field=email&sort_order=desc")
+
+      # Perform search
+      view
+      |> element("[data-testid='search-input']")
+      |> render_change(%{value: "test"})
+
+      # Sort state should be maintained
+      assert has_element?(view, "[data-testid='email'][aria-label='descending']")
+    end
+
+    test "sort maintains search state", %{conn: conn} do
+      conn = conn_with_oidc_user(conn)
+      {:ok, view, _html} = live(conn, "/members?query=test&sort_field=email&sort_order=asc")
+
+      # Perform sort
+      view
+      |> element("[data-testid='email']")
+      |> render_click()
+
+      # Search state should be maintained
+      assert_patch(view, "/members?query=test&sort_field=email&sort_order=desc")
     end
   end