Tests: use code interface for Member create/update (actor propagation)

test/membership_fees/changes/validate_same_interval_test.exs

@@ -4,7 +4,6 @@ defmodule Mv.MembershipFees.Changes.ValidateSameIntervalTest do
   """
   use Mv.DataCase, async: true
 
-  alias Mv.Membership.Member
   alias Mv.MembershipFees.MembershipFeeType
   alias Mv.MembershipFees.Changes.ValidateSameInterval
 
@@ -37,10 +36,8 @@ defmodule Mv.MembershipFees.Changes.ValidateSameIntervalTest do
     }
 
     attrs = Map.merge(default_attrs, attrs)
-
-    Member
-    |> Ash.Changeset.for_create(:create_member, attrs)
-    |> Ash.create!(actor: actor)
+    {:ok, member} = Mv.Membership.create_member(attrs, actor: actor)
+    member
   end
 
   describe "validate_interval_match/1" do
@@ -52,9 +49,9 @@ defmodule Mv.MembershipFees.Changes.ValidateSameIntervalTest do
 
       changeset =
         member
-        |> Ash.Changeset.for_update(:update_member, %{
-          membership_fee_type_id: yearly_type2.id
-        })
+        |> Ash.Changeset.for_update(:update_member, %{membership_fee_type_id: yearly_type2.id},
+          actor: actor
+        )
         |> ValidateSameInterval.change(%{}, %{})
 
       assert changeset.valid?
@@ -68,9 +65,9 @@ defmodule Mv.MembershipFees.Changes.ValidateSameIntervalTest do
 
       changeset =
         member
-        |> Ash.Changeset.for_update(:update_member, %{
-          membership_fee_type_id: monthly_type.id
-        })
+        |> Ash.Changeset.for_update(:update_member, %{membership_fee_type_id: monthly_type.id},
+          actor: actor
+        )
         |> ValidateSameInterval.change(%{}, %{})
 
       refute changeset.valid?
@@ -90,9 +87,9 @@ defmodule Mv.MembershipFees.Changes.ValidateSameIntervalTest do
 
       changeset =
         member
-        |> Ash.Changeset.for_update(:update_member, %{
-          membership_fee_type_id: yearly_type.id
-        })
+        |> Ash.Changeset.for_update(:update_member, %{membership_fee_type_id: yearly_type.id},
+          actor: actor
+        )
         |> ValidateSameInterval.change(%{}, %{})
 
       assert changeset.valid?
@@ -104,9 +101,7 @@ defmodule Mv.MembershipFees.Changes.ValidateSameIntervalTest do
 
       changeset =
         member
-        |> Ash.Changeset.for_update(:update_member, %{
-          membership_fee_type_id: nil
-        })
+        |> Ash.Changeset.for_update(:update_member, %{membership_fee_type_id: nil}, actor: actor)
         |> ValidateSameInterval.change(%{}, %{})
 
       refute changeset.valid?
@@ -124,9 +119,7 @@ defmodule Mv.MembershipFees.Changes.ValidateSameIntervalTest do
 
       changeset =
         member
-        |> Ash.Changeset.for_update(:update_member, %{
-          first_name: "New Name"
-        })
+        |> Ash.Changeset.for_update(:update_member, %{first_name: "New Name"}, actor: actor)
         |> ValidateSameInterval.change(%{}, %{})
 
       assert changeset.valid?
@@ -140,9 +133,9 @@ defmodule Mv.MembershipFees.Changes.ValidateSameIntervalTest do
 
       changeset =
         member
-        |> Ash.Changeset.for_update(:update_member, %{
-          membership_fee_type_id: quarterly_type.id
-        })
+        |> Ash.Changeset.for_update(:update_member, %{membership_fee_type_id: quarterly_type.id},
+          actor: actor
+        )
         |> ValidateSameInterval.change(%{}, %{})
 
       error = Enum.find(changeset.errors, &(&1.field == :membership_fee_type_id))
@@ -179,9 +172,9 @@ defmodule Mv.MembershipFees.Changes.ValidateSameIntervalTest do
 
         changeset =
           member
-          |> Ash.Changeset.for_update(:update_member, %{
-            membership_fee_type_id: type2.id
-          })
+          |> Ash.Changeset.for_update(:update_member, %{membership_fee_type_id: type2.id},
+            actor: actor
+          )
           |> ValidateSameInterval.change(%{}, %{})
 
         refute changeset.valid?,
@@ -199,11 +192,9 @@ defmodule Mv.MembershipFees.Changes.ValidateSameIntervalTest do
 
       # Try to update member with different interval type
       assert {:error, %Ash.Error.Invalid{} = error} =
-               member
-               |> Ash.Changeset.for_update(:update_member, %{
-                 membership_fee_type_id: monthly_type.id
-               })
-               |> Ash.update(actor: actor)
+               Mv.Membership.update_member(member, %{membership_fee_type_id: monthly_type.id},
+                 actor: actor
+               )
 
       # Check that error is about interval mismatch
       error_message = extract_error_message(error)
@@ -220,11 +211,9 @@ defmodule Mv.MembershipFees.Changes.ValidateSameIntervalTest do
 
       # Update member with same-interval type
       assert {:ok, updated_member} =
-               member
-               |> Ash.Changeset.for_update(:update_member, %{
-                 membership_fee_type_id: yearly_type2.id
-               })
-               |> Ash.update(actor: actor)
+               Mv.Membership.update_member(member, %{membership_fee_type_id: yearly_type2.id},
+                 actor: actor
+               )
 
       assert updated_member.membership_fee_type_id == yearly_type2.id
     end