Tests: use code interface for Member create/update (actor propagation)

test/mv/membership/member_policies_test.exs

@@ -78,13 +78,14 @@ defmodule Mv.Membership.MemberPoliciesTest do
     # NOTE: We need to ensure the member is actually persisted to the database
     # before we try to link it. Ash may delay writes, so we explicitly return the struct.
     {:ok, member} =
-      Membership.Member
-      |> Ash.Changeset.for_create(:create_member, %{
-        first_name: "Linked",
-        last_name: "Member",
-        email: "linked#{System.unique_integer([:positive])}@example.com"
-      })
-      |> Ash.create(actor: admin, return_notifications?: false)
+      Membership.create_member(
+        %{
+          first_name: "Linked",
+          last_name: "Member",
+          email: "linked#{System.unique_integer([:positive])}@example.com"
+        },
+        actor: admin
+      )
 
     # Link member to user (User.member_id = member.id)
     # We use force_change_attribute because the member already exists and we just
@@ -108,13 +109,14 @@ defmodule Mv.Membership.MemberPoliciesTest do
     admin = create_admin_user(actor)
 
     {:ok, member} =
-      Membership.Member
-      |> Ash.Changeset.for_create(:create_member, %{
-        first_name: "Unlinked",
-        last_name: "Member",
-        email: "unlinked#{System.unique_integer([:positive])}@example.com"
-      })
-      |> Ash.create(actor: admin)
+      Membership.create_member(
+        %{
+          first_name: "Unlinked",
+          last_name: "Member",
+          email: "unlinked#{System.unique_integer([:positive])}@example.com"
+        },
+        actor: admin
+      )
 
     member
   end
@@ -145,9 +147,7 @@ defmodule Mv.Membership.MemberPoliciesTest do
       # Update is allowed via HasPermission check with :linked scope (not via special case)
       # The special case policy only applies to :read actions
       {:ok, updated_member} =
-        linked_member
-        |> Ash.Changeset.for_update(:update_member, %{first_name: "Updated"})
-        |> Ash.update(actor: user)
+        Membership.update_member(linked_member, %{first_name: "Updated"}, actor: user)
 
       assert updated_member.first_name == "Updated"
     end
@@ -168,11 +168,8 @@ defmodule Mv.Membership.MemberPoliciesTest do
       user: user,
       unlinked_member: unlinked_member
     } do
-      assert_raise Ash.Error.Forbidden, fn ->
-        unlinked_member
-        |> Ash.Changeset.for_update(:update_member, %{first_name: "Updated"})
-        |> Ash.update!(actor: user)
-      end
+      assert {:error, %Ash.Error.Forbidden{}} =
+               Membership.update_member(unlinked_member, %{first_name: "Updated"}, actor: user)
     end
 
     test "list members returns only linked member", %{
@@ -187,15 +184,15 @@ defmodule Mv.Membership.MemberPoliciesTest do
     end
 
     test "cannot create member (returns forbidden)", %{user: user} do
-      assert_raise Ash.Error.Forbidden, fn ->
-        Membership.Member
-        |> Ash.Changeset.for_create(:create_member, %{
-          first_name: "New",
-          last_name: "Member",
-          email: "new#{System.unique_integer([:positive])}@example.com"
-        })
-        |> Ash.create!(actor: user)
-      end
+      assert {:error, %Ash.Error.Forbidden{}} =
+               Membership.create_member(
+                 %{
+                   first_name: "New",
+                   last_name: "Member",
+                   email: "new#{System.unique_integer([:positive])}@example.com"
+                 },
+                 actor: user
+               )
     end
 
     test "cannot destroy member (returns forbidden)", %{
@@ -245,26 +242,23 @@ defmodule Mv.Membership.MemberPoliciesTest do
     end
 
     test "cannot create member (returns forbidden)", %{user: user} do
-      assert_raise Ash.Error.Forbidden, fn ->
-        Membership.Member
-        |> Ash.Changeset.for_create(:create_member, %{
-          first_name: "New",
-          last_name: "Member",
-          email: "new#{System.unique_integer([:positive])}@example.com"
-        })
-        |> Ash.create!(actor: user)
-      end
+      assert {:error, %Ash.Error.Forbidden{}} =
+               Membership.create_member(
+                 %{
+                   first_name: "New",
+                   last_name: "Member",
+                   email: "new#{System.unique_integer([:positive])}@example.com"
+                 },
+                 actor: user
+               )
     end
 
     test "cannot update any member (returns forbidden)", %{
       user: user,
       linked_member: linked_member
     } do
-      assert_raise Ash.Error.Forbidden, fn ->
-        linked_member
-        |> Ash.Changeset.for_update(:update_member, %{first_name: "Updated"})
-        |> Ash.update!(actor: user)
-      end
+      assert {:error, %Ash.Error.Forbidden{}} =
+               Membership.update_member(linked_member, %{first_name: "Updated"}, actor: user)
     end
 
     test "cannot destroy any member (returns forbidden)", %{
@@ -305,22 +299,21 @@ defmodule Mv.Membership.MemberPoliciesTest do
 
     test "can create member", %{user: user} do
       {:ok, member} =
-        Membership.Member
-        |> Ash.Changeset.for_create(:create_member, %{
-          first_name: "New",
-          last_name: "Member",
-          email: "new#{System.unique_integer([:positive])}@example.com"
-        })
-        |> Ash.create(actor: user)
+        Membership.create_member(
+          %{
+            first_name: "New",
+            last_name: "Member",
+            email: "new#{System.unique_integer([:positive])}@example.com"
+          },
+          actor: user
+        )
 
       assert member.first_name == "New"
     end
 
     test "can update any member", %{user: user, unlinked_member: unlinked_member} do
       {:ok, updated_member} =
-        unlinked_member
-        |> Ash.Changeset.for_update(:update_member, %{first_name: "Updated"})
-        |> Ash.update(actor: user)
+        Membership.update_member(unlinked_member, %{first_name: "Updated"}, actor: user)
 
       assert updated_member.first_name == "Updated"
     end
@@ -363,22 +356,21 @@ defmodule Mv.Membership.MemberPoliciesTest do
 
     test "can create member", %{user: user} do
       {:ok, member} =
-        Membership.Member
-        |> Ash.Changeset.for_create(:create_member, %{
-          first_name: "New",
-          last_name: "Member",
-          email: "new#{System.unique_integer([:positive])}@example.com"
-        })
-        |> Ash.create(actor: user)
+        Membership.create_member(
+          %{
+            first_name: "New",
+            last_name: "Member",
+            email: "new#{System.unique_integer([:positive])}@example.com"
+          },
+          actor: user
+        )
 
       assert member.first_name == "New"
     end
 
     test "can update any member", %{user: user, unlinked_member: unlinked_member} do
       {:ok, updated_member} =
-        unlinked_member
-        |> Ash.Changeset.for_update(:update_member, %{first_name: "Updated"})
-        |> Ash.update(actor: user)
+        Membership.update_member(unlinked_member, %{first_name: "Updated"}, actor: user)
 
       assert updated_member.first_name == "Updated"
     end
@@ -456,9 +448,7 @@ defmodule Mv.Membership.MemberPoliciesTest do
 
       # Should succeed via HasPermission check (not special case)
       {:ok, updated_member} =
-        linked_member
-        |> Ash.Changeset.for_update(:update_member, %{first_name: "Updated"})
-        |> Ash.update(actor: user)
+        Membership.update_member(linked_member, %{first_name: "Updated"}, actor: user)
 
       assert updated_member.first_name == "Updated"
     end