Tests: use code interface for Member create/update (actor propagation)

test/mv_web/live/custom_field_live/deletion_test.exs

@@ -41,7 +41,8 @@ defmodule MvWeb.CustomFieldLive.DeletionTest do
     user_with_role = Ash.load!(user, :role, domain: Mv.Accounts, actor: system_actor)
     conn = log_in_user(build_conn(), user_with_role)
     # Use English locale so "Delete" link text matches in assertions
-    conn = Plug.Test.init_test_session(conn, Map.put(conn.private.plug_session, "locale", "en"))
+    session = conn.private[:plug_session] || %{}
+    conn = Plug.Test.init_test_session(conn, Map.put(session, "locale", "en"))
     %{conn: conn, user: user_with_role}
   end
 
@@ -271,17 +272,18 @@ defmodule MvWeb.CustomFieldLive.DeletionTest do
     end
   end
 
-  # Helper functions
+  # Helper functions (use code interface so actor is in validation context)
   defp create_member do
     system_actor = Mv.Helpers.SystemActor.get_system_actor()
 
-    Member
-    |> Ash.Changeset.for_create(:create_member, %{
-      first_name: "Test",
-      last_name: "User#{System.unique_integer([:positive])}",
-      email: "test#{System.unique_integer([:positive])}@example.com"
-    })
-    |> Ash.create(actor: system_actor)
+    Mv.Membership.create_member(
+      %{
+        first_name: "Test",
+        last_name: "User#{System.unique_integer([:positive])}",
+        email: "test#{System.unique_integer([:positive])}@example.com"
+      },
+      actor: system_actor
+    )
   end
 
   defp create_custom_field(name, value_type) do

test/mv_web/live/membership_fee_type_live/form_test.exs

@@ -7,7 +7,6 @@ defmodule MvWeb.MembershipFeeTypeLive.FormTest do
   import Phoenix.LiveViewTest
 
   alias Mv.MembershipFees.MembershipFeeType
-  alias Mv.Membership.Member
 
   require Ash.Query
 
@@ -55,10 +54,8 @@ defmodule MvWeb.MembershipFeeTypeLive.FormTest do
     }
 
     attrs = Map.merge(default_attrs, attrs)
-
-    Member
-    |> Ash.Changeset.for_create(:create_member, attrs)
-    |> Ash.create!(actor: system_actor)
+    {:ok, member} = Mv.Membership.create_member(attrs, actor: system_actor)
+    member
   end
 
   describe "create form" do

test/mv_web/live/membership_fee_type_live/index_test.exs

@@ -7,7 +7,6 @@ defmodule MvWeb.MembershipFeeTypeLive.IndexTest do
   import Phoenix.LiveViewTest
 
   alias Mv.MembershipFees.MembershipFeeType
-  alias Mv.Membership.Member
 
   require Ash.Query
 
@@ -31,7 +30,7 @@ defmodule MvWeb.MembershipFeeTypeLive.IndexTest do
   end
 
   # Helper to create a member
-  # Uses admin actor from global setup to ensure authorization
+  # Uses admin actor from global setup to ensure authorization; falls back to system_actor when nil
   defp create_member(attrs, actor) do
     default_attrs = %{
       first_name: "Test",
@@ -40,12 +39,9 @@ defmodule MvWeb.MembershipFeeTypeLive.IndexTest do
     }
 
     attrs = Map.merge(default_attrs, attrs)
-
-    opts = if actor, do: [actor: actor], else: []
-
-    Member
-    |> Ash.Changeset.for_create(:create_member, attrs)
-    |> Ash.create!(opts)
+    effective_actor = actor || Mv.Helpers.SystemActor.get_system_actor()
+    {:ok, member} = Mv.Membership.create_member(attrs, actor: effective_actor)
+    member
   end
 
   describe "list display" do

test/mv_web/live/user_live/show_test.exs

@@ -64,13 +64,10 @@ defmodule MvWeb.UserLive.ShowTest do
 
       # Create member
       {:ok, member} =
-        Member
-        |> Ash.Changeset.for_create(:create_member, %{
-          first_name: "Alice",
-          last_name: "Smith",
-          email: "alice@example.com"
-        })
-        |> Ash.create(actor: system_actor)
+        Mv.Membership.create_member(
+          %{first_name: "Alice", last_name: "Smith", email: "alice@example.com"},
+          actor: system_actor
+        )
 
       # Create user and link to member
       user = create_test_user(%{email: "user@example.com"})