local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 72 Pull requests 3 Projects 4 Releases Packages 1 Activity Actions

Merge pull request 'PermissionSets Elixir Module (Hardcoded Permissions) closes #323' (#324) from feature/323_permissionsets into main
Some checks failed
continuous-integration/drone/push Build is failing
Details

Browse source 
Reviewed-on: #324
This commit is contained in:
moritz 2026-01-06 22:20:18 +01:00
commit 5253286722
5 changed files with 979 additions and 135 deletions
Download patch file Download diff file Expand all files Collapse all files

126
docs/roles-and-permissions-architecture.md
View file

@ -93,8 +93,8 @@ Five predefined roles stored in the `roles` table:
Control CRUD operations on: Control CRUD operations on:
- User (credentials, profile) - User (credentials, profile)
- Member (member data) - Member (member data)
- Property (custom field values) - CustomFieldValue (custom field values)
- PropertyType (custom field definitions) - CustomField (custom field definitions)
- Role (role management) - Role (role management)
**4. Page-Level Permissions** **4. Page-Level Permissions**
@ -111,7 +111,7 @@ Three scope levels for permissions:
- **:own** - Only records where `record.id == user.id` (for User resource) - **:own** - Only records where `record.id == user.id` (for User resource)
- **:linked** - Only records linked to user via relationships - **:linked** - Only records linked to user via relationships
- Member: `member.user_id == user.id` - Member: `member.user_id == user.id`
- Property: `property.member.user_id == user.id` - CustomFieldValue: `custom_field_value.member.user_id == user.id`
- **:all** - All records, no filtering - **:all** - All records, no filtering
**6. Special Cases** **6. Special Cases**
@ -414,7 +414,7 @@ defmodule Mv.Authorization.PermissionSets do
## Permission Sets ## Permission Sets
1. **own_data** - Default for "Mitglied" role 1. **own_data** - Default for "Mitglied" role
- Can only access own user data and linked member/properties - Can only access own user data and linked member/custom field values
- Cannot create new members or manage system - Cannot create new members or manage system
2. **read_only** - For "Vorstand" and "Buchhaltung" roles 2. **read_only** - For "Vorstand" and "Buchhaltung" roles
@ -423,11 +423,11 @@ defmodule Mv.Authorization.PermissionSets do
3. **normal_user** - For "Kassenwart" role 3. **normal_user** - For "Kassenwart" role
- Create/Read/Update members (no delete), full CRUD on properties - Create/Read/Update members (no delete), full CRUD on properties
- Cannot manage property types or users - Cannot manage custom fields or users
4. **admin** - For "Admin" role 4. **admin** - For "Admin" role
- Unrestricted access to all resources - Unrestricted access to all resources
- Can manage users, roles, property types - Can manage users, roles, custom fields
## Usage ## Usage
@ -500,12 +500,12 @@ defmodule Mv.Authorization.PermissionSets do
%{resource: "Member", action: :read, scope: :linked, granted: true}, %{resource: "Member", action: :read, scope: :linked, granted: true},
%{resource: "Member", action: :update, scope: :linked, granted: true}, %{resource: "Member", action: :update, scope: :linked, granted: true},
# Property: Can read/update properties of linked member # CustomFieldValue: Can read/update custom field values of linked member
%{resource: "Property", action: :read, scope: :linked, granted: true}, %{resource: "CustomFieldValue", action: :read, scope: :linked, granted: true},
%{resource: "Property", action: :update, scope: :linked, granted: true}, %{resource: "CustomFieldValue", action: :update, scope: :linked, granted: true},
# PropertyType: Can read all (needed for forms) # CustomField: Can read all (needed for forms)
%{resource: "PropertyType", action: :read, scope: :all, granted: true} %{resource: "CustomField", action: :read, scope: :all, granted: true}
], ],
pages: [ pages: [
"/", # Home page "/", # Home page
@ -525,17 +525,17 @@ defmodule Mv.Authorization.PermissionSets do
# Member: Can read all members, no modifications # Member: Can read all members, no modifications
%{resource: "Member", action: :read, scope: :all, granted: true}, %{resource: "Member", action: :read, scope: :all, granted: true},
# Property: Can read all properties # CustomFieldValue: Can read all custom field values
%{resource: "Property", action: :read, scope: :all, granted: true}, %{resource: "CustomFieldValue", action: :read, scope: :all, granted: true},
# PropertyType: Can read all # CustomField: Can read all
%{resource: "PropertyType", action: :read, scope: :all, granted: true} %{resource: "CustomField", action: :read, scope: :all, granted: true}
], ],
pages: [ pages: [
"/", "/",
"/members", # Member list "/members", # Member list
"/members/:id", # Member detail "/members/:id", # Member detail
"/properties", # Property overview "/custom_field_values" # Custom field values overview
"/profile" # Own profile "/profile" # Own profile
] ]
} }
@ -554,14 +554,14 @@ defmodule Mv.Authorization.PermissionSets do
%{resource: "Member", action: :update, scope: :all, granted: true}, %{resource: "Member", action: :update, scope: :all, granted: true},
# Note: destroy intentionally omitted for safety # Note: destroy intentionally omitted for safety
# Property: Full CRUD # CustomFieldValue: Full CRUD
%{resource: "Property", action: :read, scope: :all, granted: true}, %{resource: "CustomFieldValue", action: :read, scope: :all, granted: true},
%{resource: "Property", action: :create, scope: :all, granted: true}, %{resource: "CustomFieldValue", action: :create, scope: :all, granted: true},
%{resource: "Property", action: :update, scope: :all, granted: true}, %{resource: "CustomFieldValue", action: :update, scope: :all, granted: true},
%{resource: "Property", action: :destroy, scope: :all, granted: true}, %{resource: "CustomFieldValue", action: :destroy, scope: :all, granted: true},
# PropertyType: Read only (admin manages definitions) # CustomField: Read only (admin manages definitions)
%{resource: "PropertyType", action: :read, scope: :all, granted: true} %{resource: "CustomField", action: :read, scope: :all, granted: true}
], ],
pages: [ pages: [
"/", "/",
@ -569,9 +569,9 @@ defmodule Mv.Authorization.PermissionSets do
"/members/new", # Create member "/members/new", # Create member
"/members/:id", "/members/:id",
"/members/:id/edit", # Edit member "/members/:id/edit", # Edit member
"/properties", "/custom_field_values",
"/properties/new", "/custom_field_values/new",
"/properties/:id/edit", "/custom_field_values/:id/edit",
"/profile" "/profile"
] ]
} }
@ -592,17 +592,17 @@ defmodule Mv.Authorization.PermissionSets do
%{resource: "Member", action: :update, scope: :all, granted: true}, %{resource: "Member", action: :update, scope: :all, granted: true},
%{resource: "Member", action: :destroy, scope: :all, granted: true}, %{resource: "Member", action: :destroy, scope: :all, granted: true},
# Property: Full CRUD # CustomFieldValue: Full CRUD
%{resource: "Property", action: :read, scope: :all, granted: true}, %{resource: "CustomFieldValue", action: :read, scope: :all, granted: true},
%{resource: "Property", action: :create, scope: :all, granted: true}, %{resource: "CustomFieldValue", action: :create, scope: :all, granted: true},
%{resource: "Property", action: :update, scope: :all, granted: true}, %{resource: "CustomFieldValue", action: :update, scope: :all, granted: true},
%{resource: "Property", action: :destroy, scope: :all, granted: true}, %{resource: "CustomFieldValue", action: :destroy, scope: :all, granted: true},
# PropertyType: Full CRUD (admin manages custom field definitions) # CustomField: Full CRUD (admin manages custom field definitions)
%{resource: "PropertyType", action: :read, scope: :all, granted: true}, %{resource: "CustomField", action: :read, scope: :all, granted: true},
%{resource: "PropertyType", action: :create, scope: :all, granted: true}, %{resource: "CustomField", action: :create, scope: :all, granted: true},
%{resource: "PropertyType", action: :update, scope: :all, granted: true}, %{resource: "CustomField", action: :update, scope: :all, granted: true},
%{resource: "PropertyType", action: :destroy, scope: :all, granted: true}, %{resource: "CustomField", action: :destroy, scope: :all, granted: true},
# Role: Full CRUD (admin manages roles) # Role: Full CRUD (admin manages roles)
%{resource: "Role", action: :read, scope: :all, granted: true}, %{resource: "Role", action: :read, scope: :all, granted: true},
@ -677,9 +677,9 @@ Quick reference table showing what each permission set allows:
| **User** (all) | - | - | - | R, C, U, D | | **User** (all) | - | - | - | R, C, U, D |
| **Member** (linked) | R, U | - | - | - | | **Member** (linked) | R, U | - | - | - |
| **Member** (all) | - | R | R, C, U | R, C, U, D | | **Member** (all) | - | R | R, C, U | R, C, U, D |
| **Property** (linked) | R, U | - | - | - | | **CustomFieldValue** (linked) | R, U | - | - | - |
| **Property** (all) | - | R | R, C, U, D | R, C, U, D | | **CustomFieldValue** (all) | - | R | R, C, U, D | R, C, U, D |
| **PropertyType** (all) | R | R | R | R, C, U, D | | **CustomField** (all) | R | R | R | R, C, U, D |
| **Role** (all) | - | - | - | R, C, U, D | | **Role** (all) | - | - | - | R, C, U, D |
**Legend:** R=Read, C=Create, U=Update, D=Destroy **Legend:** R=Read, C=Create, U=Update, D=Destroy
@ -715,7 +715,7 @@ defmodule Mv.Authorization.Checks.HasPermission do
- **:own** - Filters to records where record.id == actor.id - **:own** - Filters to records where record.id == actor.id
- **:linked** - Filters based on resource type: - **:linked** - Filters based on resource type:
- Member: member.user_id == actor.id - Member: member.user_id == actor.id
- Property: property.member.user_id == actor.id (traverses relationship!) - CustomFieldValue: custom_field_value.member.user_id == actor.id (traverses relationship!)
## Error Handling ## Error Handling
@ -802,8 +802,8 @@ defmodule Mv.Authorization.Checks.HasPermission do
# Member.user_id == actor.id (direct relationship) # Member.user_id == actor.id (direct relationship)
{:filter, expr(user_id == ^actor.id)} {:filter, expr(user_id == ^actor.id)}
"Property" -> "CustomFieldValue" ->
# Property.member.user_id == actor.id (traverse through member!) # CustomFieldValue.member.user_id == actor.id (traverse through member!)
{:filter, expr(member.user_id == ^actor.id)} {:filter, expr(member.user_id == ^actor.id)}
_ -> _ ->
@ -832,7 +832,7 @@ end
**Key Design Decisions:** **Key Design Decisions:**
1. **Resource-Specific :linked Scope:** Property needs to traverse `member` relationship to check `user_id` 1. **Resource-Specific :linked Scope:** CustomFieldValue needs to traverse `member` relationship to check `user_id`
2. **Error Handling:** All errors log for debugging but return generic forbidden to user 2. **Error Handling:** All errors log for debugging but return generic forbidden to user
3. **Module Name Extraction:** Uses `Module.split() |> List.last()` to match against PermissionSets strings 3. **Module Name Extraction:** Uses `Module.split() |> List.last()` to match against PermissionSets strings
4. **Pure Function:** No side effects, deterministic, easily testable 4. **Pure Function:** No side effects, deterministic, easily testable
@ -966,21 +966,21 @@ end
*Email editing has additional validation (see Special Cases) *Email editing has additional validation (see Special Cases)
### Property Resource Policies ### CustomFieldValue Resource Policies
**Location:** `lib/mv/membership/property.ex` **Location:** `lib/mv/membership/custom_field_value.ex`
**Special Case:** Users can access properties of their linked member. **Special Case:** Users can access custom field values of their linked member.
```elixir ```elixir
defmodule Mv.Membership.Property do defmodule Mv.Membership.CustomFieldValue do
use Ash.Resource, ... use Ash.Resource, ...
policies do policies do
# SPECIAL CASE: Users can access properties of their linked member # SPECIAL CASE: Users can access custom field values of their linked member
# Note: This traverses the member relationship! # Note: This traverses the member relationship!
policy action_type([:read, :update]) do policy action_type([:read, :update]) do
description "Users can access properties of their linked member" description "Users can access custom field values of their linked member"
authorize_if expr(member.user_id == ^actor(:id)) authorize_if expr(member.user_id == ^actor(:id))
end end
@ -1010,18 +1010,18 @@ end
| Create | ❌ | ❌ | ✅ | ❌ | ✅ | | Create | ❌ | ❌ | ✅ | ❌ | ✅ |
| Destroy | ❌ | ❌ | ✅ | ❌ | ✅ | | Destroy | ❌ | ❌ | ✅ | ❌ | ✅ |
### PropertyType Resource Policies ### CustomField Resource Policies
**Location:** `lib/mv/membership/property_type.ex` **Location:** `lib/mv/membership/custom_field.ex`
**No Special Cases:** All users can read, only admin can write. **No Special Cases:** All users can read, only admin can write.
```elixir ```elixir
defmodule Mv.Membership.PropertyType do defmodule Mv.Membership.CustomField do
use Ash.Resource, ... use Ash.Resource, ...
policies do policies do
# All authenticated users can read property types (needed for forms) # All authenticated users can read custom fields (needed for forms)
# Write operations are admin-only # Write operations are admin-only
policy action_type([:read, :create, :update, :destroy]) do policy action_type([:read, :create, :update, :destroy]) do
description "Check permissions from user's role" description "Check permissions from user's role"
@ -1308,12 +1308,12 @@ end
- ❌ Cannot access: `/members`, `/members/new`, `/admin/roles` - ❌ Cannot access: `/members`, `/members/new`, `/admin/roles`
**Vorstand (read_only):** **Vorstand (read_only):**
- ✅ Can access: `/`, `/members`, `/members/123`, `/properties`, `/profile` - ✅ Can access: `/`, `/members`, `/members/123`, `/custom_field_values`, `/profile`
- ❌ Cannot access: `/members/new`, `/members/123/edit`, `/admin/roles` - ❌ Cannot access: `/members/new`, `/members/123/edit`, `/admin/roles`
**Kassenwart (normal_user):** **Kassenwart (normal_user):**
- ✅ Can access: `/`, `/members`, `/members/new`, `/members/123/edit`, `/properties`, `/profile` - ✅ Can access: `/`, `/members`, `/members/new`, `/members/123/edit`, `/custom_field_values`, `/profile`
- ❌ Cannot access: `/admin/roles`, `/admin/property_types/new` - ❌ Cannot access: `/admin/roles`, `/admin/custom_fields/new`
**Admin:** **Admin:**
- ✅ Can access: `*` (all pages, including `/admin/roles`) - ✅ Can access: `*` (all pages, including `/admin/roles`)
@ -1479,9 +1479,9 @@ defmodule MvWeb.Authorization do
# Direct relationship: member.user_id # Direct relationship: member.user_id
Map.get(record, :user_id) == user.id Map.get(record, :user_id) == user.id
"Property" -> "CustomFieldValue" ->
# Need to traverse: property.member.user_id # Need to traverse: custom_field_value.member.user_id
# Note: In UI, property should have member preloaded # Note: In UI, custom_field_value should have member preloaded
case Map.get(record, :member) do case Map.get(record, :member) do
%{user_id: member_user_id} -> member_user_id == user.id %{user_id: member_user_id} -> member_user_id == user.id
_ -> false _ -> false
@ -1569,7 +1569,7 @@ end
<span>Admin</span> <span>Admin</span>
<ul> <ul>
<li><.link navigate="/admin/roles">Roles</.link></li> <li><.link navigate="/admin/roles">Roles</.link></li>
<li><.link navigate="/admin/property_types">Property Types</.link></li> <li><.link navigate="/admin/custom_fields">Custom Fields</.link></li>
</ul> </ul>
</div> </div>
<% end %> <% end %>
@ -2409,8 +2409,8 @@ The `HasPermission` check extracts resource names via `Module.split() |> List.la
|------------|------------------------| |------------|------------------------|
| `Mv.Accounts.User` | "User" | | `Mv.Accounts.User` | "User" |
| `Mv.Membership.Member` | "Member" | | `Mv.Membership.Member` | "Member" |
| `Mv.Membership.Property` | "Property" | | `Mv.Membership.CustomFieldValue` | "CustomFieldValue" |
| `Mv.Membership.PropertyType` | "PropertyType" | | `Mv.Membership.CustomField` | "CustomField" |
| `Mv.Authorization.Role` | "Role" | | `Mv.Authorization.Role` | "Role" |
These strings must match exactly in `PermissionSets` module. These strings must match exactly in `PermissionSets` module.
@ -2450,7 +2450,7 @@ These strings must match exactly in `PermissionSets` module.
**Integration:** **Integration:**
- [ ] One complete user journey per role - [ ] One complete user journey per role
- [ ] Cross-resource scenarios (e.g., Member -> Property) - [ ] Cross-resource scenarios (e.g., Member -> CustomFieldValue)
- [ ] Special cases in context (e.g., linked member email during full edit flow) - [ ] Special cases in context (e.g., linked member email during full edit flow)
### Useful Commands ### Useful Commands

130
docs/roles-and-permissions-implementation-plan.md
View file

@ -53,7 +53,7 @@ This document defines the implementation plan for the **MVP (Phase 1)** of the R
Hardcoded in `Mv.Authorization.PermissionSets` module: Hardcoded in `Mv.Authorization.PermissionSets` module:
1. **own_data** - User can only access their own data (default for "Mitglied") 1. **own_data** - User can only access their own data (default for "Mitglied")
2. **read_only** - Read access to all members/properties (for "Vorstand", "Buchhaltung") 2. **read_only** - Read access to all members/custom field values (for "Vorstand", "Buchhaltung")
3. **normal_user** - Create/Read/Update members (no delete), full CRUD on properties (for "Kassenwart") 3. **normal_user** - Create/Read/Update members (no delete), full CRUD on properties (for "Kassenwart")
4. **admin** - Unrestricted access including user/role management (for "Admin") 4. **admin** - Unrestricted access including user/role management (for "Admin")
@ -77,7 +77,7 @@ Stored in database `roles` table, each referencing a `permission_set_name`:
- ✅ Hardcoded PermissionSets module with 4 permission sets - ✅ Hardcoded PermissionSets module with 4 permission sets
- ✅ Role database table and CRUD interface - ✅ Role database table and CRUD interface
- ✅ Custom Ash Policy Check (`HasPermission`) that reads from PermissionSets - ✅ Custom Ash Policy Check (`HasPermission`) that reads from PermissionSets
- ✅ Policies on all resources (Member, User, Property, PropertyType, Role) - ✅ Policies on all resources (Member, User, CustomFieldValue, CustomField, Role)
- ✅ Page-level permissions via Phoenix Plug - ✅ Page-level permissions via Phoenix Plug
- ✅ UI authorization helpers for conditional rendering - ✅ UI authorization helpers for conditional rendering
- ✅ Special case: Member email validation for linked users - ✅ Special case: Member email validation for linked users
@ -228,32 +228,32 @@ Create the core `PermissionSets` module that defines all four permission sets wi
- Resources: - Resources:
- User: read/update :own - User: read/update :own
- Member: read/update :linked - Member: read/update :linked
- Property: read/update :linked - CustomFieldValue: read/update :linked
- PropertyType: read :all - CustomField: read :all
- Pages: `["/", "/profile", "/members/:id"]` - Pages: `["/", "/profile", "/members/:id"]`
**2. read_only (Vorstand, Buchhaltung):** **2. read_only (Vorstand, Buchhaltung):**
- Resources: - Resources:
- User: read :own, update :own - User: read :own, update :own
- Member: read :all - Member: read :all
- Property: read :all - CustomFieldValue: read :all
- PropertyType: read :all - CustomField: read :all
- Pages: `["/", "/members", "/members/:id", "/properties"]` - Pages: `["/", "/members", "/members/:id", "/custom_field_values"]`
**3. normal_user (Kassenwart):** **3. normal_user (Kassenwart):**
- Resources: - Resources:
- User: read/update :own - User: read/update :own
- Member: read/create/update :all (no destroy for safety) - Member: read/create/update :all (no destroy for safety)
- Property: read/create/update/destroy :all - CustomFieldValue: read/create/update/destroy :all
- PropertyType: read :all - CustomField: read :all
- Pages: `["/", "/members", "/members/new", "/members/:id", "/members/:id/edit", "/properties", "/properties/new", "/properties/:id/edit"]` - Pages: `["/", "/members", "/members/new", "/members/:id", "/members/:id/edit", "/custom_field_values", "/custom_field_values/new", "/custom_field_values/:id/edit"]`
**4. admin:** **4. admin:**
- Resources: - Resources:
- User: read/update/destroy :all - User: read/update/destroy :all
- Member: read/create/update/destroy :all - Member: read/create/update/destroy :all
- Property: read/create/update/destroy :all - CustomFieldValue: read/create/update/destroy :all
- PropertyType: read/create/update/destroy :all - CustomField: read/create/update/destroy :all
- Role: read/create/update/destroy :all - Role: read/create/update/destroy :all
- Pages: `["*"]` (wildcard = all pages) - Pages: `["*"]` (wildcard = all pages)
@ -276,10 +276,10 @@ Create the core `PermissionSets` module that defines all four permission sets wi
**Permission Content Tests:** **Permission Content Tests:**
- `:own_data` allows User read/update with scope :own - `:own_data` allows User read/update with scope :own
- `:own_data` allows Member/Property read/update with scope :linked - `:own_data` allows Member/CustomFieldValue read/update with scope :linked
- `:read_only` allows Member/Property read with scope :all - `:read_only` allows Member/CustomFieldValue read with scope :all
- `:read_only` does NOT allow Member/Property create/update/destroy - `:read_only` does NOT allow Member/CustomFieldValue create/update/destroy
- `:normal_user` allows Member/Property full CRUD with scope :all - `:normal_user` allows Member/CustomFieldValue full CRUD with scope :all
- `:admin` allows everything with scope :all - `:admin` allows everything with scope :all
- `:admin` has wildcard page permission "*" - `:admin` has wildcard page permission "*"
@ -387,7 +387,7 @@ Create the core custom Ash Policy Check that reads permissions from the `Permiss
- `:own` → `{:filter, expr(id == ^actor.id)}` - `:own` → `{:filter, expr(id == ^actor.id)}`
- `:linked` → resource-specific logic: - `:linked` → resource-specific logic:
- Member: `{:filter, expr(user_id == ^actor.id)}` - Member: `{:filter, expr(user_id == ^actor.id)}`
- Property: `{:filter, expr(member.user_id == ^actor.id)}` (traverse relationship!) - CustomFieldValue: `{:filter, expr(member.user_id == ^actor.id)}` (traverse relationship!)
6. Handle errors gracefully: 6. Handle errors gracefully:
- No actor → `{:error, :no_actor}` - No actor → `{:error, :no_actor}`
- No role → `{:error, :no_role}` - No role → `{:error, :no_role}`
@ -401,7 +401,7 @@ Create the core custom Ash Policy Check that reads permissions from the `Permiss
- [ ] Check module implements `Ash.Policy.Check` behavior - [ ] Check module implements `Ash.Policy.Check` behavior
- [ ] `match?/3` correctly evaluates permissions from PermissionSets - [ ] `match?/3` correctly evaluates permissions from PermissionSets
- [ ] Scope filters work correctly (:all, :own, :linked) - [ ] Scope filters work correctly (:all, :own, :linked)
- [ ] `:linked` scope handles Member and Property differently - [ ] `:linked` scope handles Member and CustomFieldValue differently
- [ ] Errors are handled gracefully (no crashes) - [ ] Errors are handled gracefully (no crashes)
- [ ] Authorization failures are logged - [ ] Authorization failures are logged
- [ ] Module is well-documented - [ ] Module is well-documented
@ -425,7 +425,7 @@ Create the core custom Ash Policy Check that reads permissions from the `Permiss
**Scope Application Tests - :linked:** **Scope Application Tests - :linked:**
- Actor with scope :linked can access Member where member.user_id == actor.id - Actor with scope :linked can access Member where member.user_id == actor.id
- Actor with scope :linked can access Property where property.member.user_id == actor.id (relationship traversal!) - Actor with scope :linked can access CustomFieldValue where custom_field_value.member.user_id == actor.id (relationship traversal!)
- Actor with scope :linked cannot access unlinked member - Actor with scope :linked cannot access unlinked member
- Query correctly filters based on user_id relationship - Query correctly filters based on user_id relationship
@ -581,7 +581,7 @@ Add authorization policies to the User resource. Special case: Users can always
--- ---
#### Issue #9: Property Resource Policies #### Issue #9: CustomFieldValue Resource Policies
**Size:** M (2 days) **Size:** M (2 days)
**Dependencies:** #6 (HasPermission check) **Dependencies:** #6 (HasPermission check)
@ -590,20 +590,20 @@ Add authorization policies to the User resource. Special case: Users can always
**Description:** **Description:**
Add authorization policies to the Property resource. Properties are linked to members, which are linked to users. Add authorization policies to the CustomFieldValue resource. CustomFieldValues are linked to members, which are linked to users.
**Tasks:** **Tasks:**
1. Open `lib/mv/membership/property.ex` 1. Open `lib/mv/membership/custom_field_value.ex`
2. Add `policies` block 2. Add `policies` block
3. Add special policy: Allow user to read/update properties of their linked member 3. Add special policy: Allow user to read/update custom field values of their linked member
```elixir ```elixir
policy action_type([:read, :update]) do policy action_type([:read, :update]) do
authorize_if expr(member.user_id == ^actor(:id)) authorize_if expr(member.user_id == ^actor(:id))
end end
``` ```
4. Add general policy: Check HasPermission 4. Add general policy: Check HasPermission
5. Ensure Property preloads :member relationship for scope checks 5. Ensure CustomFieldValue preloads :member relationship for scope checks
6. Preload :role relationship for actor 6. Preload :role relationship for actor
**Policy Order:** **Policy Order:**
@ -620,27 +620,27 @@ Add authorization policies to the Property resource. Properties are linked to me
**Test Strategy (TDD):** **Test Strategy (TDD):**
**Linked Properties Tests (:own_data):** **Linked CustomFieldValues Tests (:own_data):**
- User can read properties of their linked member - User can read custom field values of their linked member
- User can update properties of their linked member - User can update custom field values of their linked member
- User cannot read properties of unlinked members - User cannot read custom field values of unlinked members
- Verify relationship traversal works (property.member.user_id) - Verify relationship traversal works (custom_field_value.member.user_id)
**Read-Only Tests:** **Read-Only Tests:**
- User with :read_only can read all properties - User with :read_only can read all custom field values
- User with :read_only cannot create/update properties - User with :read_only cannot create/update custom field values
**Normal User Tests:** **Normal User Tests:**
- User with :normal_user can CRUD properties - User with :normal_user can CRUD custom field values
**Admin Tests:** **Admin Tests:**
- Admin can perform all operations - Admin can perform all operations
**Test File:** `test/mv/membership/property_policies_test.exs` **Test File:** `test/mv/membership/custom_field_value_policies_test.exs`
--- ---
#### Issue #10: PropertyType Resource Policies #### Issue #10: CustomField Resource Policies
**Size:** S (1 day) **Size:** S (1 day)
**Dependencies:** #6 (HasPermission check) **Dependencies:** #6 (HasPermission check)
@ -649,11 +649,11 @@ Add authorization policies to the Property resource. Properties are linked to me
**Description:** **Description:**
Add authorization policies to the PropertyType resource. PropertyTypes are admin-managed, but readable by all. Add authorization policies to the CustomField resource. CustomFields are admin-managed, but readable by all.
**Tasks:** **Tasks:**
1. Open `lib/mv/membership/property_type.ex` 1. Open `lib/mv/membership/custom_field.ex`
2. Add `policies` block 2. Add `policies` block
3. Add read policy: All authenticated users can read (scope :all) 3. Add read policy: All authenticated users can read (scope :all)
4. Add write policies: Only admin can create/update/destroy 4. Add write policies: Only admin can create/update/destroy
@ -661,27 +661,27 @@ Add authorization policies to the PropertyType resource. PropertyTypes are admin
**Acceptance Criteria:** **Acceptance Criteria:**
- [ ] All users can read property types - [ ] All users can read custom fields
- [ ] Only admin can create/update/destroy property types - [ ] Only admin can create/update/destroy custom fields
- [ ] Policies tested - [ ] Policies tested
**Test Strategy (TDD):** **Test Strategy (TDD):**
**Read Access (All Roles):** **Read Access (All Roles):**
- User with :own_data can read all property types - User with :own_data can read all custom fields
- User with :read_only can read all property types - User with :read_only can read all custom fields
- User with :normal_user can read all property types - User with :normal_user can read all custom fields
- User with :admin can read all property types - User with :admin can read all custom fields
**Write Access (Admin Only):** **Write Access (Admin Only):**
- Non-admin cannot create property type (Forbidden) - Non-admin cannot create custom field (Forbidden)
- Non-admin cannot update property type (Forbidden) - Non-admin cannot update custom field (Forbidden)
- Non-admin cannot destroy property type (Forbidden) - Non-admin cannot destroy custom field (Forbidden)
- Admin can create property type - Admin can create custom field
- Admin can update property type - Admin can update custom field
- Admin can destroy property type - Admin can destroy custom field
**Test File:** `test/mv/membership/property_type_policies_test.exs` **Test File:** `test/mv/membership/custom_field_policies_test.exs`
--- ---
@ -924,7 +924,7 @@ Create helper functions for UI-level authorization checks. These will be used in
``` ```
5. All functions use `PermissionSets.get_permissions/1` (same logic as HasPermission) 5. All functions use `PermissionSets.get_permissions/1` (same logic as HasPermission)
6. All functions handle nil user gracefully (return false) 6. All functions handle nil user gracefully (return false)
7. Implement resource-specific scope checking (Member vs Property for :linked) 7. Implement resource-specific scope checking (Member vs CustomFieldValue for :linked)
8. Add comprehensive `@doc` with template examples 8. Add comprehensive `@doc` with template examples
9. Import helper in `mv_web.ex` `html_helpers` section 9. Import helper in `mv_web.ex` `html_helpers` section
@ -957,9 +957,9 @@ Create helper functions for UI-level authorization checks. These will be used in
**can?/3 with Record Struct - Scope :linked:** **can?/3 with Record Struct - Scope :linked:**
- User can update linked Member (member.user_id == user.id) - User can update linked Member (member.user_id == user.id)
- User cannot update unlinked Member - User cannot update unlinked Member
- User can update Property of linked Member (property.member.user_id == user.id) - User can update CustomFieldValue of linked Member (custom_field_value.member.user_id == user.id)
- User cannot update Property of unlinked Member - User cannot update CustomFieldValue of unlinked Member
- Scope checking is resource-specific (Member vs Property) - Scope checking is resource-specific (Member vs CustomFieldValue)
**can_access_page?/2:** **can_access_page?/2:**
- User with page in list can access (returns true) - User with page in list can access (returns true)
@ -1046,7 +1046,7 @@ Update Role management LiveViews to use authorization helpers for conditional re
**Description:** **Description:**
Update all existing LiveViews (Member, User, Property, PropertyType) to use authorization helpers for conditional rendering. Update all existing LiveViews (Member, User, CustomFieldValue, CustomField) to use authorization helpers for conditional rendering.
**Tasks:** **Tasks:**
@ -1061,10 +1061,10 @@ Update all existing LiveViews (Member, User, Property, PropertyType) to use auth
- Show: Only show other users if admin, always show own profile - Show: Only show other users if admin, always show own profile
- Edit: Only allow editing own profile or admin editing anyone - Edit: Only allow editing own profile or admin editing anyone
3. **Property LiveViews:** 3. **CustomFieldValue LiveViews:**
- Similar to Member (hide create/edit/delete based on permissions) - Similar to Member (hide create/edit/delete based on permissions)
4. **PropertyType LiveViews:** 4. **CustomField LiveViews:**
- All users can view - All users can view
- Only admin can create/edit/delete - Only admin can create/edit/delete
@ -1110,13 +1110,13 @@ Update all existing LiveViews (Member, User, Property, PropertyType) to use auth
- Vorstand: Sees "Home", "Members" (read-only), "Profile" - Vorstand: Sees "Home", "Members" (read-only), "Profile"
- Kassenwart: Sees "Home", "Members", "Properties", "Profile" - Kassenwart: Sees "Home", "Members", "Properties", "Profile"
- Buchhaltung: Sees "Home", "Members" (read-only), "Profile" - Buchhaltung: Sees "Home", "Members" (read-only), "Profile"
- Admin: Sees "Home", "Members", "Properties", "Property Types", "Admin", "Profile" - Admin: Sees "Home", "Members", "Custom Field Values", "Custom Fields", "Admin", "Profile"
**Test Files:** **Test Files:**
- `test/mv_web/live/member_live_authorization_test.exs` - `test/mv_web/live/member_live_authorization_test.exs`
- `test/mv_web/live/user_live_authorization_test.exs` - `test/mv_web/live/user_live_authorization_test.exs`
- `test/mv_web/live/property_live_authorization_test.exs` - `test/mv_web/live/custom_field_value_live_authorization_test.exs`
- `test/mv_web/live/property_type_live_authorization_test.exs` - `test/mv_web/live/custom_field_live_authorization_test.exs`
- `test/mv_web/components/navbar_authorization_test.exs` - `test/mv_web/components/navbar_authorization_test.exs`
--- ---
@ -1192,7 +1192,7 @@ Write comprehensive integration tests that follow complete user journeys for eac
4. Can edit any member (except email if linked - see special case) 4. Can edit any member (except email if linked - see special case)
5. Cannot delete member 5. Cannot delete member
6. Can manage properties 6. Can manage properties
7. Cannot manage property types (read-only) 7. Cannot manage custom fields (read-only)
8. Cannot access /admin/roles 8. Cannot access /admin/roles
**Buchhaltung Journey:** **Buchhaltung Journey:**
@ -1266,7 +1266,7 @@ Write comprehensive integration tests that follow complete user journeys for eac
│ │ │ │ │ │
┌────▼─────┐ ┌──────▼──────┐ │ ┌────▼─────┐ ┌──────▼──────┐ │
│ Issue #9 │ │ Issue #10 │ │ │ Issue #9 │ │ Issue #10 │ │
│ Property │ │ PropType │ │ │ CustomFieldValue │ │ CustomField │ │
│ Policies │ │ Policies │ │ │ Policies │ │ Policies │ │
└────┬─────┘ └──────┬──────┘ │ └────┬─────┘ └──────┬──────┘ │
│ │ │ │ │ │
@ -1384,8 +1384,8 @@ test/
├── mv/membership/ ├── mv/membership/
│ ├── member_policies_test.exs # Issue #7 │ ├── member_policies_test.exs # Issue #7
│ ├── member_email_validation_test.exs # Issue #12 │ ├── member_email_validation_test.exs # Issue #12
│ ├── property_policies_test.exs # Issue #9 │ ├── custom_field_value_policies_test.exs # Issue #9
│ └── property_type_policies_test.exs # Issue #10 │ └── custom_field_policies_test.exs # Issue #10
├── mv_web/ ├── mv_web/
│ ├── authorization_test.exs # Issue #14 │ ├── authorization_test.exs # Issue #14
│ ├── plugs/ │ ├── plugs/
@ -1395,8 +1395,8 @@ test/
│ ├── role_live_authorization_test.exs # Issue #15 │ ├── role_live_authorization_test.exs # Issue #15
│ ├── member_live_authorization_test.exs # Issue #16 │ ├── member_live_authorization_test.exs # Issue #16
│ ├── user_live_authorization_test.exs # Issue #16 │ ├── user_live_authorization_test.exs # Issue #16
│ ├── property_live_authorization_test.exs # Issue #16 │ ├── custom_field_value_live_authorization_test.exs # Issue #16
│ └── property_type_live_authorization_test.exs # Issue #16 │ └── custom_field_live_authorization_test.exs # Issue #16
├── integration/ ├── integration/
│ ├── mitglied_journey_test.exs # Issue #17 │ ├── mitglied_journey_test.exs # Issue #17
│ ├── vorstand_journey_test.exs # Issue #17 │ ├── vorstand_journey_test.exs # Issue #17

4
docs/roles-and-permissions-overview.md
View file

@ -201,7 +201,7 @@ When runtime permission editing becomes a business requirement, migrate to Appro
**Resource Level (MVP):** **Resource Level (MVP):**
- Controls create, read, update, destroy actions on resources - Controls create, read, update, destroy actions on resources
- Resources: Member, User, Property, PropertyType, Role - Resources: Member, User, CustomFieldValue, CustomField, Role
**Page Level (MVP):** **Page Level (MVP):**
- Controls access to LiveView pages - Controls access to LiveView pages
@ -280,7 +280,7 @@ Contains:
Each Permission Set contains: Each Permission Set contains:
**Resources:** List of resource permissions **Resources:** List of resource permissions
- resource: "Member", "User", "Property", etc. - resource: "Member", "User", "CustomFieldValue", etc.
- action: :read, :create, :update, :destroy - action: :read, :create, :update, :destroy
- scope: :own, :linked, :all - scope: :own, :linked, :all
- granted: true/false - granted: true/false

270
lib/mv/authorization/permission_sets.ex
View file

@ -2,23 +2,62 @@ defmodule Mv.Authorization.PermissionSets do
@moduledoc """ @moduledoc """
Defines the four hardcoded permission sets for the application. Defines the four hardcoded permission sets for the application.
This is a minimal stub implementation. The full implementation Each permission set specifies:
with all permission details will be added in a subsequent issue. - Resource permissions (what CRUD operations on which resources)
- Page permissions (which LiveView pages can be accessed)
- Scopes (own, linked, all)
## Permission Sets ## Permission Sets
1. **own_data** - Default for "Mitglied" role 1. **own_data** - Default for "Mitglied" role
- Can only access own user data and linked member/custom field values
- Cannot create new members or manage system
2. **read_only** - For "Vorstand" and "Buchhaltung" roles 2. **read_only** - For "Vorstand" and "Buchhaltung" roles
- Can read all member data
- Cannot create, update, or delete
3. **normal_user** - For "Kassenwart" role 3. **normal_user** - For "Kassenwart" role
- Create/Read/Update members (no delete for safety), full CRUD on custom field values
- Cannot manage custom fields or users
4. **admin** - For "Admin" role 4. **admin** - For "Admin" role
- Unrestricted access to all resources
- Can manage users, roles, custom fields
## Usage ## Usage
# Get list of all valid permission set names # Get permissions for a role's permission set
PermissionSets.all_permission_sets() permissions = PermissionSets.get_permissions(:admin)
# => [:own_data, :read_only, :normal_user, :admin]
# Check if a permission set name is valid
PermissionSets.valid_permission_set?("read_only") # => true
# Convert string to atom safely
{:ok, atom} = PermissionSets.permission_set_name_to_atom("own_data")
## Performance
All functions are pure and intended to be constant-time. Permission lookups
are very fast (typically < 1 microsecond in practice) as they are simple
pattern matches and map lookups with no database queries or external calls.
""" """
@type scope :: :own | :linked | :all
@type action :: :read | :create | :update | :destroy
@type resource_permission :: %{
resource: String.t(),
action: action(),
scope: scope(),
granted: boolean()
}
@type permission_set :: %{
resources: [resource_permission()],
pages: [String.t()]
}
@doc """ @doc """
Returns the list of all valid permission set names. Returns the list of all valid permission set names.
@ -31,4 +70,225 @@ defmodule Mv.Authorization.PermissionSets do
def all_permission_sets do def all_permission_sets do
[:own_data, :read_only, :normal_user, :admin] [:own_data, :read_only, :normal_user, :admin]
end end
@doc """
Returns permissions for the given permission set.
## Examples
iex> permissions = PermissionSets.get_permissions(:admin)
iex> Enum.any?(permissions.resources, fn p ->
...> p.resource == "User" and p.action == :destroy
...> end)
true
iex> PermissionSets.get_permissions(:invalid)
** (ArgumentError) invalid permission set: :invalid. Must be one of: [:own_data, :read_only, :normal_user, :admin]
"""
@spec get_permissions(atom()) :: permission_set()
def get_permissions(set) when set not in [:own_data, :read_only, :normal_user, :admin] do
raise ArgumentError,
"invalid permission set: #{inspect(set)}. Must be one of: #{inspect(all_permission_sets())}"
end
def get_permissions(:own_data) do
%{
resources: [
# User: Can always read/update own credentials
%{resource: "User", action: :read, scope: :own, granted: true},
%{resource: "User", action: :update, scope: :own, granted: true},
# Member: Can read/update linked member
%{resource: "Member", action: :read, scope: :linked, granted: true},
%{resource: "Member", action: :update, scope: :linked, granted: true},
# CustomFieldValue: Can read/update custom field values of linked member
%{resource: "CustomFieldValue", action: :read, scope: :linked, granted: true},
%{resource: "CustomFieldValue", action: :update, scope: :linked, granted: true},
# CustomField: Can read all (needed for forms)
%{resource: "CustomField", action: :read, scope: :all, granted: true}
],
pages: [
# Home page
"/",
# Own profile
"/profile",
# Linked member detail (filtered by policy)
"/members/:id"
]
}
end
def get_permissions(:read_only) do
%{
resources: [
# User: Can read/update own credentials only
%{resource: "User", action: :read, scope: :own, granted: true},
%{resource: "User", action: :update, scope: :own, granted: true},
# Member: Can read all members, no modifications
%{resource: "Member", action: :read, scope: :all, granted: true},
# CustomFieldValue: Can read all custom field values
%{resource: "CustomFieldValue", action: :read, scope: :all, granted: true},
# CustomField: Can read all
%{resource: "CustomField", action: :read, scope: :all, granted: true}
],
pages: [
"/",
# Own profile
"/profile",
# Member list
"/members",
# Member detail
"/members/:id",
# Custom field values overview
"/custom_field_values",
# Custom field value detail
"/custom_field_values/:id"
]
}
end
def get_permissions(:normal_user) do
%{
resources: [
# User: Can read/update own credentials only
%{resource: "User", action: :read, scope: :own, granted: true},
%{resource: "User", action: :update, scope: :own, granted: true},
# Member: Full CRUD except destroy (safety)
%{resource: "Member", action: :read, scope: :all, granted: true},
%{resource: "Member", action: :create, scope: :all, granted: true},
%{resource: "Member", action: :update, scope: :all, granted: true},
# Note: destroy intentionally omitted for safety
# CustomFieldValue: Full CRUD
%{resource: "CustomFieldValue", action: :read, scope: :all, granted: true},
%{resource: "CustomFieldValue", action: :create, scope: :all, granted: true},
%{resource: "CustomFieldValue", action: :update, scope: :all, granted: true},
%{resource: "CustomFieldValue", action: :destroy, scope: :all, granted: true},
# CustomField: Read only (admin manages definitions)
%{resource: "CustomField", action: :read, scope: :all, granted: true}
],
pages: [
"/",
# Own profile
"/profile",
"/members",
# Create member
"/members/new",
"/members/:id",
# Edit member
"/members/:id/edit",
"/custom_field_values",
# Custom field value detail
"/custom_field_values/:id",
"/custom_field_values/new",
"/custom_field_values/:id/edit"
]
}
end
def get_permissions(:admin) do
%{
resources: [
# User: Full management including other users
%{resource: "User", action: :read, scope: :all, granted: true},
%{resource: "User", action: :create, scope: :all, granted: true},
%{resource: "User", action: :update, scope: :all, granted: true},
%{resource: "User", action: :destroy, scope: :all, granted: true},
# Member: Full CRUD
%{resource: "Member", action: :read, scope: :all, granted: true},
%{resource: "Member", action: :create, scope: :all, granted: true},
%{resource: "Member", action: :update, scope: :all, granted: true},
%{resource: "Member", action: :destroy, scope: :all, granted: true},
# CustomFieldValue: Full CRUD
%{resource: "CustomFieldValue", action: :read, scope: :all, granted: true},
%{resource: "CustomFieldValue", action: :create, scope: :all, granted: true},
%{resource: "CustomFieldValue", action: :update, scope: :all, granted: true},
%{resource: "CustomFieldValue", action: :destroy, scope: :all, granted: true},
# CustomField: Full CRUD (admin manages custom field definitions)
%{resource: "CustomField", action: :read, scope: :all, granted: true},
%{resource: "CustomField", action: :create, scope: :all, granted: true},
%{resource: "CustomField", action: :update, scope: :all, granted: true},
%{resource: "CustomField", action: :destroy, scope: :all, granted: true},
# Role: Full CRUD (admin manages roles)
%{resource: "Role", action: :read, scope: :all, granted: true},
%{resource: "Role", action: :create, scope: :all, granted: true},
%{resource: "Role", action: :update, scope: :all, granted: true},
%{resource: "Role", action: :destroy, scope: :all, granted: true}
],
pages: [
# Wildcard: Admin can access all pages
"*"
]
}
end
def get_permissions(invalid) do
raise ArgumentError,
"invalid permission set: #{inspect(invalid)}. Must be one of: #{inspect(all_permission_sets())}"
end
@doc """
Checks if a permission set name (string or atom) is valid.
## Examples
iex> PermissionSets.valid_permission_set?("admin")
true
iex> PermissionSets.valid_permission_set?(:read_only)
true
iex> PermissionSets.valid_permission_set?("invalid")
false
"""
@spec valid_permission_set?(any()) :: boolean()
def valid_permission_set?(name) when is_binary(name) do
case permission_set_name_to_atom(name) do
{:ok, _atom} -> true
{:error, _} -> false
end
end
def valid_permission_set?(name) when is_atom(name) do
name in all_permission_sets()
end
def valid_permission_set?(_), do: false
@doc """
Converts a permission set name string to atom safely.
## Examples
iex> PermissionSets.permission_set_name_to_atom("admin")
{:ok, :admin}
iex> PermissionSets.permission_set_name_to_atom("invalid")
{:error, :invalid_permission_set}
"""
@spec permission_set_name_to_atom(String.t()) ::
{:ok, atom()} | {:error, :invalid_permission_set}
def permission_set_name_to_atom(name) when is_binary(name) do
atom = String.to_existing_atom(name)
if valid_permission_set?(atom) do
{:ok, atom}
else
{:error, :invalid_permission_set}
end
rescue
ArgumentError -> {:error, :invalid_permission_set}
end
end end

584
test/mv/authorization/permission_sets_test.exs Normal file
View file

@ -0,0 +1,584 @@
defmodule Mv.Authorization.PermissionSetsTest do
@moduledoc """
Tests for the PermissionSets module that defines hardcoded permission sets.
"""
use ExUnit.Case, async: true
alias Mv.Authorization.PermissionSets
describe "all_permission_sets/0" do
test "returns all four permission sets" do
sets = PermissionSets.all_permission_sets()
assert length(sets) == 4
assert :own_data in sets
assert :read_only in sets
assert :normal_user in sets
assert :admin in sets
end
end
describe "get_permissions/1" do
test "all permission sets return map with :resources and :pages keys" do
for set <- PermissionSets.all_permission_sets() do
permissions = PermissionSets.get_permissions(set)
assert Map.has_key?(permissions, :resources),
"#{set} missing :resources key"
assert Map.has_key?(permissions, :pages),
"#{set} missing :pages key"
assert is_list(permissions.resources),
"#{set} :resources must be a list"
assert is_list(permissions.pages),
"#{set} :pages must be a list"
end
end
test "each resource permission has required keys" do
permissions = PermissionSets.get_permissions(:own_data)
Enum.each(permissions.resources, fn perm ->
assert Map.has_key?(perm, :resource)
assert Map.has_key?(perm, :action)
assert Map.has_key?(perm, :scope)
assert Map.has_key?(perm, :granted)
assert is_binary(perm.resource)
assert perm.action in [:read, :create, :update, :destroy]
assert perm.scope in [:own, :linked, :all]
assert is_boolean(perm.granted)
end)
end
test "pages lists are non-empty for all permission sets" do
for set <- [:own_data, :read_only, :normal_user, :admin] do
permissions = PermissionSets.get_permissions(set)
assert not Enum.empty?(permissions.pages),
"Permission set #{set} should have at least one page"
end
end
end
describe "get_permissions/1 - :own_data permission content" do
test "allows User read/update with scope :own" do
permissions = PermissionSets.get_permissions(:own_data)
user_read =
Enum.find(permissions.resources, fn p -> p.resource == "User" && p.action == :read end)
user_update =
Enum.find(permissions.resources, fn p -> p.resource == "User" && p.action == :update end)
assert user_read.scope == :own
assert user_read.granted == true
assert user_update.scope == :own
assert user_update.granted == true
end
test "allows Member read/update with scope :linked" do
permissions = PermissionSets.get_permissions(:own_data)
member_read =
Enum.find(permissions.resources, fn p -> p.resource == "Member" && p.action == :read end)
member_update =
Enum.find(permissions.resources, fn p -> p.resource == "Member" && p.action == :update end)
assert member_read.scope == :linked
assert member_read.granted == true
assert member_update.scope == :linked
assert member_update.granted == true
end
test "allows CustomFieldValue read/update with scope :linked" do
permissions = PermissionSets.get_permissions(:own_data)
cfv_read =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomFieldValue" && p.action == :read
end)
cfv_update =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomFieldValue" && p.action == :update
end)
assert cfv_read.scope == :linked
assert cfv_read.granted == true
assert cfv_update.scope == :linked
assert cfv_update.granted == true
end
test "allows CustomField read with scope :all" do
permissions = PermissionSets.get_permissions(:own_data)
cf_read =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomField" && p.action == :read
end)
assert cf_read.scope == :all
assert cf_read.granted == true
end
test "includes correct pages" do
permissions = PermissionSets.get_permissions(:own_data)
assert "/" in permissions.pages
assert "/profile" in permissions.pages
assert "/members/:id" in permissions.pages
end
end
describe "get_permissions/1 - :read_only permission content" do
test "allows User read/update with scope :own" do
permissions = PermissionSets.get_permissions(:read_only)
user_read =
Enum.find(permissions.resources, fn p -> p.resource == "User" && p.action == :read end)
user_update =
Enum.find(permissions.resources, fn p -> p.resource == "User" && p.action == :update end)
assert user_read.scope == :own
assert user_read.granted == true
assert user_update.scope == :own
assert user_update.granted == true
end
test "allows Member read with scope :all" do
permissions = PermissionSets.get_permissions(:read_only)
member_read =
Enum.find(permissions.resources, fn p -> p.resource == "Member" && p.action == :read end)
assert member_read.scope == :all
assert member_read.granted == true
end
test "does NOT allow Member create/update/destroy" do
permissions = PermissionSets.get_permissions(:read_only)
member_create =
Enum.find(permissions.resources, fn p -> p.resource == "Member" && p.action == :create end)
member_update =
Enum.find(permissions.resources, fn p -> p.resource == "Member" && p.action == :update end)
member_destroy =
Enum.find(permissions.resources, fn p ->
p.resource == "Member" && p.action == :destroy
end)
assert member_create == nil || member_create.granted == false
assert member_update == nil || member_update.granted == false
assert member_destroy == nil || member_destroy.granted == false
end
test "allows CustomFieldValue read with scope :all" do
permissions = PermissionSets.get_permissions(:read_only)
cfv_read =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomFieldValue" && p.action == :read
end)
assert cfv_read.scope == :all
assert cfv_read.granted == true
end
test "does NOT allow CustomFieldValue create/update/destroy" do
permissions = PermissionSets.get_permissions(:read_only)
cfv_create =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomFieldValue" && p.action == :create
end)
cfv_update =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomFieldValue" && p.action == :update
end)
cfv_destroy =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomFieldValue" && p.action == :destroy
end)
assert cfv_create == nil || cfv_create.granted == false
assert cfv_update == nil || cfv_update.granted == false
assert cfv_destroy == nil || cfv_destroy.granted == false
end
test "allows CustomField read with scope :all" do
permissions = PermissionSets.get_permissions(:read_only)
cf_read =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomField" && p.action == :read
end)
assert cf_read.scope == :all
assert cf_read.granted == true
end
test "includes correct pages" do
permissions = PermissionSets.get_permissions(:read_only)
assert "/" in permissions.pages
assert "/profile" in permissions.pages
assert "/members" in permissions.pages
assert "/members/:id" in permissions.pages
assert "/custom_field_values" in permissions.pages
assert "/custom_field_values/:id" in permissions.pages
end
end
describe "get_permissions/1 - :normal_user permission content" do
test "allows User read/update with scope :own" do
permissions = PermissionSets.get_permissions(:normal_user)
user_read =
Enum.find(permissions.resources, fn p -> p.resource == "User" && p.action == :read end)
user_update =
Enum.find(permissions.resources, fn p -> p.resource == "User" && p.action == :update end)
assert user_read.scope == :own
assert user_read.granted == true
assert user_update.scope == :own
assert user_update.granted == true
end
test "allows Member read/create/update with scope :all" do
permissions = PermissionSets.get_permissions(:normal_user)
member_read =
Enum.find(permissions.resources, fn p -> p.resource == "Member" && p.action == :read end)
member_create =
Enum.find(permissions.resources, fn p -> p.resource == "Member" && p.action == :create end)
member_update =
Enum.find(permissions.resources, fn p -> p.resource == "Member" && p.action == :update end)
assert member_read.scope == :all
assert member_read.granted == true
assert member_create.scope == :all
assert member_create.granted == true
assert member_update.scope == :all
assert member_update.granted == true
end
test "does NOT allow Member destroy (safety)" do
permissions = PermissionSets.get_permissions(:normal_user)
member_destroy =
Enum.find(permissions.resources, fn p ->
p.resource == "Member" && p.action == :destroy
end)
assert member_destroy == nil || member_destroy.granted == false
end
test "allows CustomFieldValue full CRUD with scope :all" do
permissions = PermissionSets.get_permissions(:normal_user)
cfv_read =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomFieldValue" && p.action == :read
end)
cfv_create =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomFieldValue" && p.action == :create
end)
cfv_update =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomFieldValue" && p.action == :update
end)
cfv_destroy =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomFieldValue" && p.action == :destroy
end)
assert cfv_read.scope == :all
assert cfv_read.granted == true
assert cfv_create.scope == :all
assert cfv_create.granted == true
assert cfv_update.scope == :all
assert cfv_update.granted == true
assert cfv_destroy.scope == :all
assert cfv_destroy.granted == true
end
test "allows CustomField read with scope :all" do
permissions = PermissionSets.get_permissions(:normal_user)
cf_read =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomField" && p.action == :read
end)
assert cf_read.scope == :all
assert cf_read.granted == true
end
test "includes correct pages" do
permissions = PermissionSets.get_permissions(:normal_user)
assert "/" in permissions.pages
assert "/profile" in permissions.pages
assert "/members" in permissions.pages
assert "/members/new" in permissions.pages
assert "/members/:id" in permissions.pages
assert "/members/:id/edit" in permissions.pages
assert "/custom_field_values" in permissions.pages
assert "/custom_field_values/:id" in permissions.pages
assert "/custom_field_values/new" in permissions.pages
assert "/custom_field_values/:id/edit" in permissions.pages
end
end
describe "get_permissions/1 - :admin permission content" do
test "allows User full CRUD with scope :all" do
permissions = PermissionSets.get_permissions(:admin)
user_read =
Enum.find(permissions.resources, fn p -> p.resource == "User" && p.action == :read end)
user_create =
Enum.find(permissions.resources, fn p -> p.resource == "User" && p.action == :create end)
user_update =
Enum.find(permissions.resources, fn p -> p.resource == "User" && p.action == :update end)
user_destroy =
Enum.find(permissions.resources, fn p -> p.resource == "User" && p.action == :destroy end)
assert user_read.scope == :all
assert user_read.granted == true
assert user_create.scope == :all
assert user_create.granted == true
assert user_update.scope == :all
assert user_update.granted == true
assert user_destroy.scope == :all
assert user_destroy.granted == true
end
test "allows Member full CRUD with scope :all" do
permissions = PermissionSets.get_permissions(:admin)
member_read =
Enum.find(permissions.resources, fn p -> p.resource == "Member" && p.action == :read end)
member_create =
Enum.find(permissions.resources, fn p -> p.resource == "Member" && p.action == :create end)
member_update =
Enum.find(permissions.resources, fn p -> p.resource == "Member" && p.action == :update end)
member_destroy =
Enum.find(permissions.resources, fn p ->
p.resource == "Member" && p.action == :destroy
end)
assert member_read.scope == :all
assert member_read.granted == true
assert member_create.scope == :all
assert member_create.granted == true
assert member_update.scope == :all
assert member_update.granted == true
assert member_destroy.scope == :all
assert member_destroy.granted == true
end
test "allows CustomFieldValue full CRUD with scope :all" do
permissions = PermissionSets.get_permissions(:admin)
cfv_read =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomFieldValue" && p.action == :read
end)
cfv_create =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomFieldValue" && p.action == :create
end)
cfv_update =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomFieldValue" && p.action == :update
end)
cfv_destroy =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomFieldValue" && p.action == :destroy
end)
assert cfv_read.scope == :all
assert cfv_read.granted == true
assert cfv_create.scope == :all
assert cfv_create.granted == true
assert cfv_update.scope == :all
assert cfv_update.granted == true
assert cfv_destroy.scope == :all
assert cfv_destroy.granted == true
end
test "allows CustomField full CRUD with scope :all" do
permissions = PermissionSets.get_permissions(:admin)
cf_read =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomField" && p.action == :read
end)
cf_create =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomField" && p.action == :create
end)
cf_update =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomField" && p.action == :update
end)
cf_destroy =
Enum.find(permissions.resources, fn p ->
p.resource == "CustomField" && p.action == :destroy
end)
assert cf_read.scope == :all
assert cf_read.granted == true
assert cf_create.scope == :all
assert cf_create.granted == true
assert cf_update.scope == :all
assert cf_update.granted == true
assert cf_destroy.scope == :all
assert cf_destroy.granted == true
end
test "allows Role full CRUD with scope :all" do
permissions = PermissionSets.get_permissions(:admin)
role_read =
Enum.find(permissions.resources, fn p -> p.resource == "Role" && p.action == :read end)
role_create =
Enum.find(permissions.resources, fn p -> p.resource == "Role" && p.action == :create end)
role_update =
Enum.find(permissions.resources, fn p -> p.resource == "Role" && p.action == :update end)
role_destroy =
Enum.find(permissions.resources, fn p -> p.resource == "Role" && p.action == :destroy end)
assert role_read.scope == :all
assert role_read.granted == true
assert role_create.scope == :all
assert role_create.granted == true
assert role_update.scope == :all
assert role_update.granted == true
assert role_destroy.scope == :all
assert role_destroy.granted == true
end
test "has wildcard page permission" do
permissions = PermissionSets.get_permissions(:admin)
assert "*" in permissions.pages
end
end
describe "valid_permission_set?/1" do
test "returns true for valid permission set string" do
assert PermissionSets.valid_permission_set?("own_data") == true
assert PermissionSets.valid_permission_set?("read_only") == true
assert PermissionSets.valid_permission_set?("normal_user") == true
assert PermissionSets.valid_permission_set?("admin") == true
end
test "returns true for valid permission set atom" do
assert PermissionSets.valid_permission_set?(:own_data) == true
assert PermissionSets.valid_permission_set?(:read_only) == true
assert PermissionSets.valid_permission_set?(:normal_user) == true
assert PermissionSets.valid_permission_set?(:admin) == true
end
test "returns false for invalid permission set string" do
assert PermissionSets.valid_permission_set?("invalid") == false
assert PermissionSets.valid_permission_set?("") == false
assert PermissionSets.valid_permission_set?("admin_user") == false
end
test "returns false for invalid permission set atom" do
assert PermissionSets.valid_permission_set?(:invalid) == false
assert PermissionSets.valid_permission_set?(:unknown) == false
end
test "returns false for nil input" do
assert PermissionSets.valid_permission_set?(nil) == false
end
test "returns false for invalid types" do
assert PermissionSets.valid_permission_set?(123) == false
assert PermissionSets.valid_permission_set?([]) == false
assert PermissionSets.valid_permission_set?(%{}) == false
assert PermissionSets.valid_permission_set?("") == false
end
end
describe "permission_set_name_to_atom/1" do
test "returns {:ok, atom} for valid permission set name" do
assert PermissionSets.permission_set_name_to_atom("own_data") == {:ok, :own_data}
assert PermissionSets.permission_set_name_to_atom("read_only") == {:ok, :read_only}
assert PermissionSets.permission_set_name_to_atom("normal_user") == {:ok, :normal_user}
assert PermissionSets.permission_set_name_to_atom("admin") == {:ok, :admin}
end
test "returns {:error, :invalid_permission_set} for invalid permission set name" do
assert PermissionSets.permission_set_name_to_atom("invalid") ==
{:error, :invalid_permission_set}
assert PermissionSets.permission_set_name_to_atom("") == {:error, :invalid_permission_set}
assert PermissionSets.permission_set_name_to_atom("admin_user") ==
{:error, :invalid_permission_set}
end
test "handles non-existent atom gracefully" do
# String.to_existing_atom will raise ArgumentError for non-existent atoms
assert PermissionSets.permission_set_name_to_atom("nonexistent_atom_12345") ==
{:error, :invalid_permission_set}
end
end
describe "get_permissions/1 - error handling" do
test "raises ArgumentError for invalid permission set with helpful message" do
assert_raise ArgumentError,
~r/invalid permission set: :invalid\. Must be one of:/,
fn ->
PermissionSets.get_permissions(:invalid)
end
end
test "error message includes all valid permission sets" do
error =
assert_raise ArgumentError, fn ->
PermissionSets.get_permissions(:unknown)
end
error_message = Exception.message(error)
assert error_message =~ "own_data"
assert error_message =~ "read_only"
assert error_message =~ "normal_user"
assert error_message =~ "admin"
end
end
end