local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 72 Pull requests 3 Projects 4 Releases Packages 1 Activity Actions

refactor: simplify system role deletion validation

Browse source 
Remove redundant action_type check since validation already
runs only on destroy actions. Add field to error for better
error handling.
This commit is contained in:
Moritz 2026-01-06 18:37:34 +01:00
parent 9bb0fe5e37
commit 557eb4d27d
1 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

13
lib/mv/authorization/role.ex
View file

@ -88,14 +88,11 @@ defmodule Mv.Authorization.Role do
message: "must be one of: own_data, read_only, normal_user, admin" message: "must be one of: own_data, read_only, normal_user, admin"
validate fn changeset, _context -> validate fn changeset, _context ->
if changeset.action_type == :destroy do if changeset.data.is_system_role do
if changeset.data.is_system_role do {:error,
{:error, field: :is_system_role,
message: message:
"Cannot delete system role. System roles are required for the application to function."} "Cannot delete system role. System roles are required for the application to function."}
else
:ok
end
else else
:ok :ok
end end