local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 54 Pull requests 5 Projects 1 Releases 3 Packages 1 Activity Actions

fix: adapt tests to updated deps
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/promote/production Build is passing
Details

Browse source
This commit is contained in:
Simon 2026-04-07 15:52:19 +02:00
parent 879695e7b6
commit 5aaca7aa37
Signed by: simon
GPG key ID: 40E7A58C4AA1EDB2
4 changed files with 51 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

54
test/mv_web/controllers/auth_controller_test.exs
View file

@ -286,16 +286,33 @@ defmodule MvWeb.AuthControllerTest do
describe "when OIDC-only is enabled" do
setup %{conn: authenticated_conn} do
{:ok, settings} = Membership.get_settings()
original_oidc_only = Map.get(settings, :oidc_only, false)
{:ok, _} = Membership.update_settings(settings, %{oidc_only: true})
prev = %{
oidc_only: settings.oidc_only,
oidc_client_id: settings.oidc_client_id,
oidc_base_url: settings.oidc_base_url,
oidc_redirect_uri: settings.oidc_redirect_uri,
oidc_client_secret: settings.oidc_client_secret
}
# OIDC must be cleared so GET /sign-in is not redirected by OidcOnlySignInRedirect
# (seeds may leave a full OIDC config). Rejection is enforced in AuthController.success/4.
{:ok, _} =
Membership.update_settings(settings, %{
oidc_only: true,
oidc_client_id: nil,
oidc_base_url: nil,
oidc_redirect_uri: nil,
oidc_client_secret: nil
})
conn = build_unauthenticated_conn(authenticated_conn)
{:ok, conn: conn, original_oidc_only: original_oidc_only}
{:ok, conn: conn, original_sign_in_settings: prev}
end
test "password sign-in is rejected and redirects to sign-in with error", %{
conn: conn,
original_oidc_only: original
original_sign_in_settings: prev
} do
try do
_user =
@ -326,7 +343,7 @@ defmodule MvWeb.AuthControllerTest do
end
after
{:ok, s} = Membership.get_settings()
Membership.update_settings(s, %{oidc_only: original})
Membership.update_settings(s, prev)
end
end
end
@ -341,7 +358,8 @@ defmodule MvWeb.AuthControllerTest do
oidc_only: settings.oidc_only,
oidc_client_id: settings.oidc_client_id,
oidc_base_url: settings.oidc_base_url,
oidc_redirect_uri: settings.oidc_redirect_uri
oidc_redirect_uri: settings.oidc_redirect_uri,
oidc_client_secret: settings.oidc_client_secret
}
{:ok, _} =
@ -372,7 +390,8 @@ defmodule MvWeb.AuthControllerTest do
oidc_only: settings.oidc_only,
oidc_client_id: settings.oidc_client_id,
oidc_base_url: settings.oidc_base_url,
oidc_redirect_uri: settings.oidc_redirect_uri
oidc_redirect_uri: settings.oidc_redirect_uri,
oidc_client_secret: settings.oidc_client_secret
}
{:ok, _} =
@ -398,8 +417,23 @@ defmodule MvWeb.AuthControllerTest do
test "returns 200 when OIDC-only but OIDC not configured", %{conn: authenticated_conn} do
{:ok, settings} = Membership.get_settings()
original_oidc_only = Map.get(settings, :oidc_only, false)
{:ok, _} = Membership.update_settings(settings, %{oidc_only: true})
prev = %{
oidc_only: settings.oidc_only,
oidc_client_id: settings.oidc_client_id,
oidc_base_url: settings.oidc_base_url,
oidc_redirect_uri: settings.oidc_redirect_uri,
oidc_client_secret: settings.oidc_client_secret
}
{:ok, _} =
Membership.update_settings(settings, %{
oidc_only: true,
oidc_client_id: nil,
oidc_base_url: nil,
oidc_redirect_uri: nil,
oidc_client_secret: nil
})
try do
conn = build_unauthenticated_conn(authenticated_conn)
@ -407,7 +441,7 @@ defmodule MvWeb.AuthControllerTest do
assert conn.status == 200
after
{:ok, s} = Membership.get_settings()
Membership.update_settings(s, %{oidc_only: original_oidc_only})
Membership.update_settings(s, prev)
end
end