refactor: adress review comments

lib/mix/tasks/join_requests.cleanup_expired.ex

@@ -17,6 +17,7 @@ defmodule Mix.Tasks.JoinRequests.CleanupExpired do
   use Mix.Task
 
   require Ash.Query
+  require Logger
 
   alias Mv.Membership.JoinRequest
 
@@ -34,23 +35,41 @@ defmodule Mix.Tasks.JoinRequests.CleanupExpired do
       |> Ash.Query.filter(confirmation_token_expires_at < ^now)
 
     # Bypass authorization: cleanup is a system maintenance task (cron/Oban).
-    case Ash.read(query, domain: Mv.Membership, authorize?: false) do
-      {:ok, requests} ->
-        count = delete_expired_requests(requests)
+    # Use bulk_destroy so the data layer can delete in one pass when supported.
+    opts = [domain: Mv.Membership, authorize?: false]
+
+    count =
+      case Ash.count(query, opts) do
+        {:ok, n} -> n
+        {:error, _} -> 0
+      end
+
+    do_run(query, opts, count)
+  end
+
+  defp do_run(_query, _opts, 0) do
+    Mix.shell().info("No expired join requests to delete.")
+    0
+  end
+
+  defp do_run(query, opts, count) do
+    case Ash.bulk_destroy(query, :destroy, %{}, opts) do
+      %{status: status, errors: errors} when status in [:success, :partial_success] ->
+        maybe_log_errors(errors)
         Mix.shell().info("Deleted #{count} expired join request(s).")
         count
 
-      {:error, error} ->
-        Mix.raise("Failed to list expired join requests: #{inspect(error)}")
+      %{status: :error, errors: errors} ->
+        Mix.raise("Failed to delete expired join requests: #{inspect(errors)}")
     end
   end
 
-  defp delete_expired_requests(requests) do
-    Enum.reduce_while(requests, 0, fn request, acc ->
-      case Ash.destroy(request, domain: Mv.Membership, authorize?: false) do
-        :ok -> {:cont, acc + 1}
-        {:error, _} -> {:halt, acc}
-      end
-    end)
+  defp maybe_log_errors(nil), do: :ok
+  defp maybe_log_errors([]), do: :ok
+
+  defp maybe_log_errors(errors) do
+    Logger.warning(
+      "Join requests cleanup: #{length(errors)} error(s) while deleting expired requests: #{inspect(errors)}"
+    )
   end
 end