fix: adress review comments

priv/repo/migrations/20260217120000_add_group_names_to_member_search_vector.exs

@@ -32,7 +32,7 @@ defmodule Mv.Repo.Migrations.AddGroupNamesToMemberSearchVector do
       FROM custom_field_values
       WHERE member_id = NEW.id AND value IS NOT NULL;
 
-      -- Aggregate group names for this member (weight B, same as city/notes)
+      -- Aggregate group names for this member (weight B, same as notes/email)
       SELECT string_agg(g.name, ' ')
       INTO groups_text
       FROM member_groups mg
@@ -162,7 +162,8 @@ defmodule Mv.Repo.Migrations.AddGroupNamesToMemberSearchVector do
     $$ LANGUAGE plpgsql;
     """)
 
-    # 3. Trigger on member_groups: when associations change, refresh that member's search_vector
+    # 3. Trigger on member_groups: when associations change, refresh affected member(s) search_vector.
+    # On UPDATE with different member_id, refresh both OLD and NEW member so neither keeps a stale vector.
     execute("""
     CREATE FUNCTION update_member_search_vector_from_member_groups() RETURNS trigger AS $$
     DECLARE
@@ -180,66 +181,71 @@ defmodule Mv.Repo.Migrations.AddGroupNamesToMemberSearchVector do
       custom_values_text text;
       groups_text text;
     BEGIN
-      member_id_val := COALESCE(NEW.member_id, OLD.member_id);
+      FOR member_id_val IN
+        SELECT COALESCE(NEW.member_id, OLD.member_id)
+        UNION ALL
+        SELECT OLD.member_id
+        WHERE TG_OP = 'UPDATE' AND OLD.member_id IS DISTINCT FROM NEW.member_id
+      LOOP
+        SELECT
+          first_name,
+          last_name,
+          email,
+          join_date,
+          exit_date,
+          notes,
+          city,
+          street,
+          house_number,
+          postal_code
+        INTO
+          member_first_name,
+          member_last_name,
+          member_email,
+          member_join_date,
+          member_exit_date,
+          member_notes,
+          member_city,
+          member_street,
+          member_house_number,
+          member_postal_code
+        FROM members
+        WHERE id = member_id_val;
 
-      SELECT
-        first_name,
-        last_name,
-        email,
-        join_date,
-        exit_date,
-        notes,
-        city,
-        street,
-        house_number,
-        postal_code
-      INTO
-        member_first_name,
-        member_last_name,
-        member_email,
-        member_join_date,
-        member_exit_date,
-        member_notes,
-        member_city,
-        member_street,
-        member_house_number,
-        member_postal_code
-      FROM members
-      WHERE id = member_id_val;
+        SELECT string_agg(
+          CASE
+            WHEN value ? '_union_value' THEN value->>'_union_value'
+            WHEN value ? 'value' THEN value->>'value'
+            ELSE ''
+          END,
+          ' '
+        )
+        INTO custom_values_text
+        FROM custom_field_values
+        WHERE member_id = member_id_val AND value IS NOT NULL;
 
-      SELECT string_agg(
-        CASE
-          WHEN value ? '_union_value' THEN value->>'_union_value'
-          WHEN value ? 'value' THEN value->>'value'
-          ELSE ''
-        END,
-        ' '
-      )
-      INTO custom_values_text
-      FROM custom_field_values
-      WHERE member_id = member_id_val AND value IS NOT NULL;
+        SELECT string_agg(g.name, ' ')
+        INTO groups_text
+        FROM member_groups mg
+        JOIN groups g ON g.id = mg.group_id
+        WHERE mg.member_id = member_id_val;
 
-      SELECT string_agg(g.name, ' ')
-      INTO groups_text
-      FROM member_groups mg
-      JOIN groups g ON g.id = mg.group_id
-      WHERE mg.member_id = member_id_val;
-
-      UPDATE members
-      SET search_vector =
-        setweight(to_tsvector('simple', coalesce(member_first_name, '')), 'A') ||
-        setweight(to_tsvector('simple', coalesce(member_last_name, '')), 'A') ||
-        setweight(to_tsvector('simple', coalesce(member_email, '')), 'B') ||
-        setweight(to_tsvector('simple', coalesce(member_join_date::text, '')), 'D') ||
-        setweight(to_tsvector('simple', coalesce(member_exit_date::text, '')), 'D') ||
-        setweight(to_tsvector('simple', coalesce(member_notes, '')), 'B') ||
-        setweight(to_tsvector('simple', coalesce(member_city, '')), 'C') ||
-        setweight(to_tsvector('simple', coalesce(member_street, '')), 'C') ||
-        setweight(to_tsvector('simple', coalesce(member_house_number::text, '')), 'C') ||
-        setweight(to_tsvector('simple', coalesce(member_postal_code::text, '')), 'C') ||
-        setweight(to_tsvector('simple', coalesce(custom_values_text, '')), 'C') ||
-        setweight(to_tsvector('simple', coalesce(groups_text, '')), 'B')
-      WHERE id = member_id_val;
+        UPDATE members
+        SET search_vector =
+          setweight(to_tsvector('simple', coalesce(member_first_name, '')), 'A') ||
+          setweight(to_tsvector('simple', coalesce(member_last_name, '')), 'A') ||
+          setweight(to_tsvector('simple', coalesce(member_email, '')), 'B') ||
+          setweight(to_tsvector('simple', coalesce(member_join_date::text, '')), 'D') ||
+          setweight(to_tsvector('simple', coalesce(member_exit_date::text, '')), 'D') ||
+          setweight(to_tsvector('simple', coalesce(member_notes, '')), 'B') ||
+          setweight(to_tsvector('simple', coalesce(member_city, '')), 'C') ||
+          setweight(to_tsvector('simple', coalesce(member_street, '')), 'C') ||
+          setweight(to_tsvector('simple', coalesce(member_house_number::text, '')), 'C') ||
+          setweight(to_tsvector('simple', coalesce(member_postal_code::text, '')), 'C') ||
+          setweight(to_tsvector('simple', coalesce(custom_values_text, '')), 'C') ||
+          setweight(to_tsvector('simple', coalesce(groups_text, '')), 'B')
+        WHERE id = member_id_val;
+      END LOOP;
 
       RETURN COALESCE(NEW, OLD);
     END