local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 51 Pull requests 13 Projects 1 Releases Packages 1 Activity Actions

feat: fail if oidc provide does not provide a sub or id

Browse source
This commit is contained in:
Moritz 2025-07-24 15:30:34 +02:00 • committed by carla
parent 4ee629366b
commit 6907b2ed3c
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
lib/accounts/user.ex
View file

@ -105,6 +105,8 @@ defmodule Mv.Accounts.User do
upsert? true upsert? true
upsert_identity :unique_oidc_id upsert_identity :unique_oidc_id
validate &__MODULE__.validate_oidc_id_present/2
change AshAuthentication.GenerateTokenChange change AshAuthentication.GenerateTokenChange
change fn changeset, _ctx -> change fn changeset, _ctx ->
@ -125,6 +127,16 @@ defmodule Mv.Accounts.User do
end end
end end
def validate_oidc_id_present(changeset, _context) do
user_info = Ash.Changeset.get_argument(changeset, :user_info) || %{}
if is_binary(user_info["sub"]) or is_binary(user_info["id"]) do
:ok
else
{:error, [user_info: "OIDC user_info must contain a non-empty 'sub' or 'id' field"]}
end
end
attributes do attributes do
uuid_primary_key :id uuid_primary_key :id