local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 61 Pull requests 7 Projects 1 Releases Packages 1 Activity Actions

refactor: use sql_sandbox config instead of env for sync/async

Browse source 
- Replace Application.get_env(:mv, :env) with :sql_sandbox config
- Remove redundant :env config from test.exs
- More explicit and less error-prone for test environment detection
This commit is contained in:
Moritz 2025-12-12 16:05:39 +01:00
parent 162d06da21
commit 7e4d3e0a60
2 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/membership/member.ex
View file

@ -112,7 +112,7 @@ defmodule Mv.Membership.Member do
# but in test environment it runs synchronously for DB sandbox compatibility
change after_action(fn _changeset, member, _context ->
if member.membership_fee_type_id && member.join_date do
if Application.get_env(:mv, :env) == :test do
if Application.get_env(:mv, :sql_sandbox, false) do
# Run synchronously in test environment for DB sandbox compatibility
Mv.MembershipFees.CycleGenerator.generate_cycles_for_member(member.id)
else
@ -180,7 +180,7 @@ defmodule Mv.Membership.Member do
Ash.Changeset.changing_attribute?(changeset, :membership_fee_type_id)
if fee_type_changed && member.membership_fee_type_id && member.join_date do
if Application.get_env(:mv, :env) == :test do
if Application.get_env(:mv, :sql_sandbox, false) do
# Run synchronously in test environment for DB sandbox compatibility
Mv.MembershipFees.CycleGenerator.generate_cycles_for_member(member.id)
else