Fix Credo Readability (strict)
- Max line length, implicit try, alias order, zero-arity defs - String sigils, long comments split; redundant blank lines fixed
This commit is contained in:
parent
f0a8dfcc21
commit
81ce204502
48 changed files with 131 additions and 144 deletions
|
|
@ -446,23 +446,21 @@ defmodule MvWeb.MemberLive.Form do
|
|||
end
|
||||
|
||||
def handle_event("save", %{"member" => member_params}, socket) do
|
||||
try do
|
||||
actor = current_actor(socket)
|
||||
actor = current_actor(socket)
|
||||
|
||||
case submit_form(socket.assigns.form, member_params, actor) do
|
||||
{:ok, member} ->
|
||||
handle_save_success(socket, member)
|
||||
case submit_form(socket.assigns.form, member_params, actor) do
|
||||
{:ok, member} ->
|
||||
handle_save_success(socket, member)
|
||||
|
||||
{:error, form} ->
|
||||
handle_save_error(socket, form)
|
||||
end
|
||||
rescue
|
||||
_e in [Ash.Error.Forbidden, Ash.Error.Forbidden.Policy] ->
|
||||
handle_save_forbidden(socket)
|
||||
|
||||
e ->
|
||||
handle_save_exception(socket, e)
|
||||
{:error, form} ->
|
||||
handle_save_error(socket, form)
|
||||
end
|
||||
rescue
|
||||
_e in [Ash.Error.Forbidden, Ash.Error.Forbidden.Policy] ->
|
||||
handle_save_forbidden(socket)
|
||||
|
||||
e ->
|
||||
handle_save_exception(socket, e)
|
||||
end
|
||||
|
||||
@impl true
|
||||
|
|
@ -690,11 +688,9 @@ defmodule MvWeb.MemberLive.Form do
|
|||
|
||||
# Extracts message from struct error using Ash.ErrorKind protocol
|
||||
defp extract_struct_error_message(error) do
|
||||
try do
|
||||
Ash.ErrorKind.message(error)
|
||||
rescue
|
||||
Protocol.UndefinedError -> gettext("Failed to save member. Please try again.")
|
||||
end
|
||||
Ash.ErrorKind.message(error)
|
||||
rescue
|
||||
Protocol.UndefinedError -> gettext("Failed to save member. Please try again.")
|
||||
end
|
||||
|
||||
# Checks if form has any errors
|
||||
|
|
|
|||
|
|
@ -708,11 +708,9 @@ defmodule MvWeb.MemberLive.Index do
|
|||
end
|
||||
|
||||
defp to_sort_id(field) when is_binary(field) do
|
||||
try do
|
||||
String.to_existing_atom("sort_#{field}")
|
||||
rescue
|
||||
ArgumentError -> :"sort_#{field}"
|
||||
end
|
||||
String.to_existing_atom("sort_#{field}")
|
||||
rescue
|
||||
ArgumentError -> :"sort_#{field}"
|
||||
end
|
||||
|
||||
defp to_sort_id(field) when is_atom(field), do: :"sort_#{field}"
|
||||
|
|
|
|||
|
|
@ -18,10 +18,10 @@ defmodule MvWeb.MemberLive.Show.MembershipFeesComponent do
|
|||
|
||||
alias Mv.Membership
|
||||
alias Mv.MembershipFees
|
||||
alias Mv.MembershipFees.MembershipFeeType
|
||||
alias Mv.MembershipFees.MembershipFeeCycle
|
||||
alias Mv.MembershipFees.CycleGenerator
|
||||
alias Mv.MembershipFees.CalendarCycles
|
||||
alias Mv.MembershipFees.CycleGenerator
|
||||
alias Mv.MembershipFees.MembershipFeeCycle
|
||||
alias Mv.MembershipFees.MembershipFeeType
|
||||
alias MvWeb.Helpers.MembershipFeeHelpers
|
||||
|
||||
@impl true
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue