Fix Credo Readability (strict)

- Max line length, implicit try, alias order, zero-arity defs
- String sigils, long comments split; redundant blank lines fixed

test/mv/helpers/system_actor_test.exs

@@ -4,9 +4,9 @@ defmodule Mv.Helpers.SystemActorTest do
   """
   use Mv.DataCase, async: false
 
-  alias Mv.Helpers.SystemActor
-  alias Mv.Authorization
   alias Mv.Accounts
+  alias Mv.Authorization
+  alias Mv.Helpers.SystemActor
 
   require Ash.Query
 

test/mv/membership/custom_field_value_policies_test.exs

@@ -9,8 +9,8 @@ defmodule Mv.Membership.CustomFieldValuePoliciesTest do
   # async: false because we need database commits to be visible across queries
   use Mv.DataCase, async: false
 
-  alias Mv.Membership.{CustomField, CustomFieldValue}
   alias Mv.Accounts
+  alias Mv.Membership.{CustomField, CustomFieldValue}
 
   require Ash.Query
 

test/mv/membership/member_policies_test.exs

@@ -10,8 +10,8 @@ defmodule Mv.Membership.MemberPoliciesTest do
   # in the same test (especially for unlinked members)
   use Mv.DataCase, async: false
 
-  alias Mv.Membership
   alias Mv.Accounts
+  alias Mv.Membership
 
   require Ash.Query
 

test/mv/membership_fees/membership_fee_cycle_policies_test.exs

@@ -8,8 +8,8 @@ defmodule Mv.MembershipFees.MembershipFeeCyclePoliciesTest do
   """
   use Mv.DataCase, async: false
 
-  alias Mv.MembershipFees
   alias Mv.Membership
+  alias Mv.MembershipFees
 
   setup do
     system_actor = Mv.Helpers.SystemActor.get_system_actor()

test/mv/oidc_role_sync_test.exs

@@ -92,7 +92,7 @@ defmodule Mv.OidcRoleSyncTest do
       # Minimal JWT: header.payload.signature with "groups" in payload (Rauthy puts groups in access_token)
       payload = Jason.encode!(%{"groups" => ["mila-admin"], "sub" => "oidc-123"})
       payload_b64 = Base.url_encode64(payload, padding: false)
-      header_b64 = Base.url_encode64("{\"alg\":\"HS256\",\"typ\":\"JWT\"}", padding: false)
+      header_b64 = Base.url_encode64(~s({"alg":"HS256","typ":"JWT"}), padding: false)
       sig_b64 = Base.url_encode64("sig", padding: false)
       access_token = "#{header_b64}.#{payload_b64}.#{sig_b64}"
       oauth_tokens = %{"access_token" => access_token}

test/mv/statistics_test.exs

@@ -8,10 +8,10 @@ defmodule Mv.StatisticsTest do
   import Ash.Expr
 
   alias Mv.Membership.Member
-  alias Mv.Statistics
   alias Mv.MembershipFees
   alias Mv.MembershipFees.MembershipFeeCycle
   alias Mv.MembershipFees.MembershipFeeType
+  alias Mv.Statistics
 
   setup do
     actor = Mv.Helpers.SystemActor.get_system_actor()