Fix Credo Readability (strict)
- Max line length, implicit try, alias order, zero-arity defs - String sigils, long comments split; redundant blank lines fixed
This commit is contained in:
parent
f0a8dfcc21
commit
81ce204502
48 changed files with 131 additions and 144 deletions
|
|
@ -4,8 +4,8 @@ defmodule MvWeb.Plugs.CheckPagePermissionTest do
|
|||
"""
|
||||
use MvWeb.ConnCase, async: true
|
||||
|
||||
alias MvWeb.Plugs.CheckPagePermission
|
||||
alias Mv.Fixtures
|
||||
alias MvWeb.Plugs.CheckPagePermission
|
||||
|
||||
defp conn_with_user(path, user) do
|
||||
build_conn(:get, path)
|
||||
|
|
@ -46,21 +46,21 @@ defmodule MvWeb.Plugs.CheckPagePermissionTest do
|
|||
end
|
||||
|
||||
describe "dynamic routes" do
|
||||
test "user with \"/members/:id\" permission can access \"/members/123\"" do
|
||||
test ~s(user with "/members/:id" permission can access "/members/123") do
|
||||
user = Fixtures.user_with_role_fixture("read_only")
|
||||
conn = conn_with_user("/members/123", user) |> CheckPagePermission.call([])
|
||||
|
||||
refute conn.halted
|
||||
end
|
||||
|
||||
test "user with \"/members/:id/edit\" permission can access \"/members/456/edit\"" do
|
||||
test ~s(user with "/members/:id/edit" permission can access "/members/456/edit") do
|
||||
user = Fixtures.user_with_role_fixture("normal_user")
|
||||
conn = conn_with_user("/members/456/edit", user) |> CheckPagePermission.call([])
|
||||
|
||||
refute conn.halted
|
||||
end
|
||||
|
||||
test "user with only \"/members/:id\" cannot access \"/members/123/edit\"" do
|
||||
test ~s(user with only "/members/:id" cannot access "/members/123/edit") do
|
||||
user = Fixtures.user_with_role_fixture("read_only")
|
||||
conn = conn_with_user("/members/123/edit", user) |> CheckPagePermission.call([])
|
||||
|
||||
|
|
@ -456,7 +456,8 @@ defmodule MvWeb.Plugs.CheckPagePermissionTest do
|
|||
assert conn.status == 200
|
||||
end
|
||||
|
||||
# Full-router test: session may not preserve member_id; plug logic covered by unit test "own_data user with linked member can access /members/:id/edit (plug direct call)"
|
||||
# Full-router test: session may not preserve member_id; plug logic covered by unit test
|
||||
# "own_data user with linked member can access /members/:id/edit (plug direct call)".
|
||||
@tag role: :member
|
||||
@tag :skip
|
||||
test "GET /members/:id/edit (linked member edit) returns 200 when user has linked member", %{
|
||||
|
|
@ -512,7 +513,8 @@ defmodule MvWeb.Plugs.CheckPagePermissionTest do
|
|||
assert conn.status == 200
|
||||
end
|
||||
|
||||
# Skipped: MemberLive.Show requires membership fee cycle data; plug allows access (page loads then LiveView may error).
|
||||
# Skipped: MemberLive.Show requires membership fee cycle data; plug allows access
|
||||
# (page loads then LiveView may error).
|
||||
@tag role: :member
|
||||
@tag :skip
|
||||
test "GET /members/:id for linked member returns 200", %{conn: conn, current_user: user} do
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue