refactor: small changes from PR review

2025-11-13 16:32:54 +01:00 · 2025-11-13 16:32:54 +01:00 · 82e2fbb109
commit 82e2fbb109
parent 07cb1ab57c
2 changed files with 7 additions and 22 deletions
--- a/lib/accounts/user.ex
+++ b/lib/accounts/user.ex
@ -190,8 +190,9 @@ defmodule Mv.Accounts.User do
        changeset
        |> Ash.Changeset.change_attribute(:oidc_id, oidc_id)
        # Update email if it differs from OIDC provider
+        # change_attribute/3 already checks if value matches existing value
        |> then(fn cs ->
-          if new_email && to_string(cs.data.email) != new_email do
+          if new_email do
            Ash.Changeset.change_attribute(cs, :email, new_email)
          else
            cs