resolve review issues

This commit is contained in:
Moritz 2025-12-01 15:43:04 +01:00 committed by Rafael Epplée
parent a5aeef3e27
commit 8391122426
2 changed files with 8 additions and 6 deletions

View file

@ -147,6 +147,7 @@ lib/
**Existing Fields Used:** **Existing Fields Used:**
- `joined_at` - For calculating contribution start - `joined_at` - For calculating contribution start
- `left_at` - For limiting period generation - `left_at` - For limiting period generation
- These fields must remain member fields and should not be replaced by custom fields in the future
### Settings Integration ### Settings Integration
@ -236,6 +237,7 @@ lib/
**Bulk Operations:** **Bulk Operations:**
- `bulk_mark_as_paid` - Mark multiple periods as paid (efficiency) - `bulk_mark_as_paid` - Mark multiple periods as paid (efficiency)
- low priority, can be a future issue
### Contribution Type Change Handling ### Contribution Type Change Handling
@ -403,7 +405,7 @@ lib/
**AC-UI-MD-1:** Contributions section shows all periods **AC-UI-MD-1:** Contributions section shows all periods
**AC-UI-MD-2:** Table columns: Period, Interval, Amount, Status, Actions **AC-UI-MD-2:** Table columns: Period, Interval, Amount, Status, Actions
**AC-UI-MD-3:** Checkbox per period for bulk marking **AC-UI-MD-3:** Checkbox per period for bulk marking (low prio)
**AC-UI-MD-4:** "Mark selected as paid" button **AC-UI-MD-4:** "Mark selected as paid" button
**AC-UI-MD-5:** Dropdown to change contribution type (same interval only) **AC-UI-MD-5:** Dropdown to change contribution type (same interval only)
**AC-UI-MD-6:** Warning if different interval selected **AC-UI-MD-6:** Warning if different interval selected
@ -466,7 +468,7 @@ lib/
**Status Management Flow:** **Status Management Flow:**
- Mark single period as paid - Mark single period as paid
- Bulk mark multiple periods - Bulk mark multiple periods (low prio)
- Status transitions work - Status transitions work
- Permissions enforced - Permissions enforced
@ -487,7 +489,7 @@ lib/
**Member Detail:** **Member Detail:**
- Periods table displays all periods - Periods table displays all periods
- Checkboxes work - Checkboxes work
- Bulk marking works - Bulk marking works (low prio)
- Type change validation works - Type change validation works
- Actions only shown with permission - Actions only shown with permission

View file

@ -321,7 +321,7 @@ Legend: ☑ = paid | ☐ = unpaid | ⊘ = suspended
**Quick Marking:** **Quick Marking:**
- Checkbox in each row for fast marking - Checkbox in each row for fast marking
- Button: "Mark selected as paid" - Button: "Mark selected as paid/unpaid/suspended"
- Bulk action for multiple periods - Bulk action for multiple periods
### Admin: Contribution Types Management ### Admin: Contribution Types Management
@ -426,7 +426,7 @@ Member exits: 15.08.2024
Yearly period 2024: unpaid Yearly period 2024: unpaid
``` ```
**UI Notice on Exit:** **UI Notice on Exit: (Low Prio)**
``` ```
⚠ Unpaid contributions present ⚠ Unpaid contributions present
@ -453,7 +453,7 @@ Do you want to continue?
│ 2025 │ Yearly │ 60 € │ ☐ Open │ [ ] │ │ 2025 │ Yearly │ 60 € │ ☐ Open │ [ ] │
└───────────────┴──────────┴────────┴──────────┴─────────┘ └───────────────┴──────────┴────────┴──────────┴─────────┘
[Mark selected as paid] (2 selected) [Mark selected as paid/unpaid/suspended] (2 selected)
``` ```
### 4. Amount Changes ### 4. Amount Changes