refactor: Rename Property/PropertyType to CustomFieldValue/CustomField

Complete refactoring of resources, database tables, code references, tests, and documentation for improved naming consistency.

lib/mv_web/live/member_live/form.ex

@@ -19,14 +19,14 @@ defmodule MvWeb.MemberLive.Form do
   - paid status
   - notes
 
-  ## Custom Properties
-  Members can have dynamic custom properties defined by PropertyTypes.
-  The form dynamically renders inputs based on available PropertyTypes.
+  ## Custom Field Values
+  Members can have dynamic custom field values defined by CustomFields.
+  The form dynamically renders inputs based on available CustomFields.
 
   ## Events
   - `validate` - Real-time form validation
   - `save` - Submit form (create or update member)
-  - Property management events for adding/removing custom fields
+  - Custom field value management events for adding/removing custom fields
   """
   use MvWeb, :live_view
 
@@ -56,10 +56,11 @@ defmodule MvWeb.MemberLive.Form do
         <.input field={@form[:house_number]} label={gettext("House Number")} />
         <.input field={@form[:postal_code]} label={gettext("Postal Code")} />
 
-        <h3 class="mt-8 mb-2 text-lg font-semibold">{gettext("Custom Properties")}</h3>
-        <.inputs_for :let={f_property} field={@form[:properties]}>
-          <% type = Enum.find(@property_types, &(&1.id == f_property[:property_type_id].value)) %>
-          <.inputs_for :let={value_form} field={f_property[:value]}>
+        <h3 class="mt-8 mb-2 text-lg font-semibold">{gettext("Custom Field Values")}</h3>
+        <.inputs_for :let={f_custom_field_value} field={@form[:custom_field_values]}>
+          <% type =
+            Enum.find(@custom_fields, &(&1.id == f_custom_field_value[:custom_field_id].value)) %>
+          <.inputs_for :let={value_form} field={f_custom_field_value[:value]}>
             <% input_type =
               cond do
                 type && type.value_type == :boolean -> "checkbox"
@@ -70,8 +71,8 @@ defmodule MvWeb.MemberLive.Form do
           </.inputs_for>
           <input
             type="hidden"
-            name={f_property[:property_type_id].name}
-            value={f_property[:property_type_id].value}
+            name={f_custom_field_value[:custom_field_id].name}
+            value={f_custom_field_value[:custom_field_id].value}
           />
         </.inputs_for>
 
@@ -86,16 +87,16 @@ defmodule MvWeb.MemberLive.Form do
 
   @impl true
   def mount(params, _session, socket) do
-    {:ok, property_types} = Mv.Membership.list_property_types()
+    {:ok, custom_fields} = Mv.Membership.list_custom_fields()
 
-    initial_properties =
-      Enum.map(property_types, fn pt ->
+    initial_custom_field_values =
+      Enum.map(custom_fields, fn cf ->
         %{
-          "property_type_id" => pt.id,
+          "custom_field_id" => cf.id,
           "value" => %{
-            "type" => pt.value_type,
+            "type" => cf.value_type,
             "value" => nil,
-            "_union_type" => Atom.to_string(pt.value_type)
+            "_union_type" => Atom.to_string(cf.value_type)
           }
         }
       end)
@@ -112,8 +113,8 @@ defmodule MvWeb.MemberLive.Form do
     {:ok,
      socket
      |> assign(:return_to, return_to(params["return_to"]))
-     |> assign(:property_types, property_types)
-     |> assign(:initial_properties, initial_properties)
+     |> assign(:custom_fields, custom_fields)
+     |> assign(:initial_custom_field_values, initial_custom_field_values)
      |> assign(member: member)
      |> assign(:page_title, page_title)
      |> assign_form()}
@@ -156,25 +157,25 @@ defmodule MvWeb.MemberLive.Form do
   defp assign_form(%{assigns: %{member: member}} = socket) do
     form =
       if member do
-        {:ok, member} = Ash.load(member, properties: [:property_type])
+        {:ok, member} = Ash.load(member, custom_field_values: [:custom_field])
 
-        existing_properties =
-          member.properties
-          |> Enum.map(& &1.property_type_id)
+        existing_custom_field_values =
+          member.custom_field_values
+          |> Enum.map(& &1.custom_field_id)
 
-        is_missing_property = fn i ->
-          not Enum.member?(existing_properties, Map.get(i, "property_type_id"))
+        is_missing_custom_field_value = fn i ->
+          not Enum.member?(existing_custom_field_values, Map.get(i, "custom_field_id"))
         end
 
         params = %{
-          "properties" =>
-            Enum.map(member.properties, fn prop ->
+          "custom_field_values" =>
+            Enum.map(member.custom_field_values, fn cfv ->
               %{
-                "property_type_id" => prop.property_type_id,
+                "custom_field_id" => cfv.custom_field_id,
                 "value" => %{
-                  "_union_type" => Atom.to_string(prop.value.type),
-                  "type" => prop.value.type,
-                  "value" => prop.value.value
+                  "_union_type" => Atom.to_string(cfv.value.type),
+                  "type" => cfv.value.type,
+                  "value" => cfv.value.value
                 }
               }
             end)
@@ -190,12 +191,13 @@ defmodule MvWeb.MemberLive.Form do
             forms: [auto?: true]
           )
 
-        missing_properties = Enum.filter(socket.assigns[:initial_properties], is_missing_property)
+        missing_custom_field_values =
+          Enum.filter(socket.assigns[:initial_custom_field_values], is_missing_custom_field_value)
 
         Enum.reduce(
-          missing_properties,
+          missing_custom_field_values,
           form,
-          &AshPhoenix.Form.add_form(&2, [:properties], params: &1)
+          &AshPhoenix.Form.add_form(&2, [:custom_field_values], params: &1)
         )
       else
         AshPhoenix.Form.for_create(
@@ -203,7 +205,7 @@ defmodule MvWeb.MemberLive.Form do
           :create_member,
           api: Mv.Membership,
           as: "member",
-          params: %{"properties" => socket.assigns[:initial_properties]},
+          params: %{"custom_field_values" => socket.assigns[:initial_custom_field_values]},
           forms: [auto?: true]
         )
       end

lib/mv_web/live/member_live/show.ex

@@ -5,7 +5,7 @@ defmodule MvWeb.MemberLive.Show do
   ## Features
   - Display all member information (personal, contact, address)
   - Show linked user account (if exists)
-  - Display custom properties
+  - Display custom field values
   - Navigate to edit form
   - Return to member list
 
@@ -15,7 +15,7 @@ defmodule MvWeb.MemberLive.Show do
   - Address: street, house number, postal code, city
   - Status: paid flag
   - Relationships: linked user account
-  - Custom: dynamic properties from PropertyTypes
+  - Custom: dynamic custom field values from CustomFields
 
   ## Navigation
   - Back to member list
@@ -75,14 +75,14 @@ defmodule MvWeb.MemberLive.Show do
         </:item>
       </.list>
 
-      <h3 class="mt-8 mb-2 text-lg font-semibold">{gettext("Custom Properties")}</h3>
+      <h3 class="mt-8 mb-2 text-lg font-semibold">{gettext("Custom Field Values")}</h3>
       <.generic_list items={
-        Enum.map(@member.properties, fn p ->
+        Enum.map(@member.custom_field_values, fn cfv ->
           {
             # name
-            p.property_type && p.property_type.name,
+            cfv.custom_field && cfv.custom_field.name,
             # value
-            case p.value do
+            case cfv.value do
               %{value: v} -> v
               v -> v
             end
@@ -103,7 +103,7 @@ defmodule MvWeb.MemberLive.Show do
     query =
       Mv.Membership.Member
       |> filter(id == ^id)
-      |> load([:user, properties: [:property_type]])
+      |> load([:user, custom_field_values: [:custom_field]])
 
     member = Ash.read_one!(query)