fix: address review comments
Some checks failed
continuous-integration/drone/push Build is failing
continuous-integration/drone/promote/production Build is passing

This commit is contained in:
Simon 2026-02-17 15:30:23 +01:00
parent b1a9eb8b1d
commit 911f308a67
Signed by: simon
GPG key ID: 40E7A58C4AA1EDB2
7 changed files with 88 additions and 164 deletions

View file

@ -322,7 +322,6 @@
<%= for group <- (member.groups || []) do %>
<span
class="badge badge-outline badge-primary"
role="status"
aria-label={gettext("Member of group %{name}", name: group.name)}
>
{group.name}

View file

@ -12,7 +12,7 @@ defmodule MvWeb.MemberLive.Show do
## Sections
- Personal Data: Name, address, contact information, membership dates, notes
- Custom Fields: Dynamic fields in uniform grid layout (sorted by name)
- Groups: Group links (buttons) in Personal Data section, below Linked User
- Groups: Links to group detail pages in Personal Data section
- Payment Data: Membership fee type and cycle status
- Membership Fees: Tab showing all membership fee cycles with status management (via MembershipFeesComponent)
@ -148,24 +148,24 @@ defmodule MvWeb.MemberLive.Show do
</div>
<% end %>
<%!-- Groups (in Personal Data, below Linked User) --%>
<%!-- Groups (in Personal Data) --%>
<% groups = @member.groups || [] %>
<div>
<.data_field label={gettext("Groups")}>
<%= if Enum.any?(@member.groups || []) do %>
<%= if Enum.empty?(groups) do %>
<span class="text-base-content/70 italic">{gettext("No groups")}</span>
<% else %>
<div class="flex flex-wrap gap-2">
<%= for group <- (@member.groups || []) do %>
<%= for group <- groups do %>
<.link
navigate={~p"/groups/#{group.slug}"}
class="btn btn-xs btn-outline btn-primary"
role="status"
aria-label={gettext("Member of group %{name}", name: group.name)}
>
{group.name}
</.link>
<% end %>
</div>
<% else %>
<span class="text-base-content/70 italic">{gettext("No groups")}</span>
<% end %>
</.data_field>
</div>