local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 68 Pull requests 8 Projects 1 Releases Packages 1 Activity Actions

Fix accessibility issues: add select label, improve contrast, fix heading hierarchy

Browse source
This commit is contained in:
Moritz 2025-12-22 17:48:53 +01:00
parent 18766df224
commit 9233f56847
Signed by: moritz
GPG key ID: 1020A035E5DD0824
4 changed files with 35 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

10
lib/mv_web/live/member_live/show.ex
View file

@ -47,7 +47,10 @@ defmodule MvWeb.MemberLive.Show do
<div role="tablist" class="tabs tabs-bordered mb-6">
<button
role="tab"
class={["tab", if(@active_tab == :contact, do: "tab-active", else: "")]}
class={[
"tab",
if(@active_tab == :contact, do: "tab-active", else: "!text-gray-800")
]}
aria-selected={@active_tab == :contact}
phx-click="switch_tab"
phx-value-tab="contact"
@ -57,7 +60,10 @@ defmodule MvWeb.MemberLive.Show do
</button>
<button
role="tab"
class={["tab", if(@active_tab == :membership_fees, do: "tab-active", else: "")]}
class={[
"tab",
if(@active_tab == :membership_fees, do: "tab-active", else: "!text-gray-800")
]}
aria-selected={@active_tab == :membership_fees}
phx-click="switch_tab"
phx-value-tab="membership_fees"

8
lib/mv_web/live/member_live/show/membership_fees_component.ex
View file

@ -311,17 +311,19 @@ defmodule MvWeb.MemberLive.Show.MembershipFeesComponent do
<h3 class="text-lg font-bold">{gettext("Create Cycle")}</h3>
<form phx-submit="create_cycle" phx-target={@myself}>
<div class="form-control w-full mt-4">
<label class="label">
<label class="label" for="create-cycle-date">
<span class="label-text">{gettext("Date")}</span>
</label>
<input
type="date"
id="create-cycle-date"
name="date"
value={@create_cycle_date || ""}
phx-change="update_create_cycle_date"
phx-target={@myself}
class="input input-bordered w-full"
required
aria-label={gettext("Date")}
/>
<label class="label">
<span class="label-text-alt">
@ -345,17 +347,19 @@ defmodule MvWeb.MemberLive.Show.MembershipFeesComponent do
</div>
<% end %>
<div class="form-control w-full mt-4">
<label class="label">
<label class="label" for="create-cycle-amount">
<span class="label-text">{gettext("Amount")}</span>
</label>
<input
type="number"
id="create-cycle-amount"
name="amount"
step="0.01"
min="0"
value={Decimal.to_string(@member.membership_fee_type.amount)}
class="input input-bordered w-full"
required
aria-label={gettext("Amount")}
/>
</div>
<%= if @create_cycle_error do %>