refactor: adress review

config/runtime.exs

@@ -227,6 +227,10 @@ if config_env() == :prod do
   # When SMTP_HOST is set, configure Swoosh to use the SMTP adapter at boot time.
   # If SMTP is configured only via Settings (Admin UI), the mailer builds the config
   # per-send at runtime using Mv.Config.smtp_*() helpers.
+  #
+  # TLS/SSL options (tls_options, sockopts) are duplicated here and in Mv.Mailer.smtp_config/0
+  # because boot config must be set in this file; the Mailer uses the same logic for
+  # Settings-only config. Keep verify behaviour in sync (see SMTP_VERIFY_PEER below).
   smtp_host_env = System.get_env("SMTP_HOST")
 
   if smtp_host_env && String.trim(smtp_host_env) != "" do
@@ -250,6 +254,15 @@ if config_env() == :prod do
 
     smtp_ssl_mode = System.get_env("SMTP_SSL", "tls")
 
+    # SMTP_VERIFY_PEER: set to true/1/yes to enable TLS certificate verification (recommended
+    # for public SMTP like Gmail/Mailgun). Default false for self-signed/internal certs.
+    smtp_verify_peer =
+      (System.get_env("SMTP_VERIFY_PEER", "false") |> String.downcase()) in ~w(true 1 yes)
+
+    config :mv, :smtp_verify_peer, smtp_verify_peer
+
+    verify_mode = if smtp_verify_peer, do: :verify_peer, else: :verify_none
+
     smtp_opts =
       [
         adapter: Swoosh.Adapters.SMTP,
@@ -260,10 +273,9 @@ if config_env() == :prod do
         ssl: smtp_ssl_mode == "ssl",
         tls: if(smtp_ssl_mode == "tls", do: :always, else: :never),
         auth: :always,
-        # Allow self-signed or internal SMTP server certs (OTP 26+ enforces verify_peer with cacerts).
         # tls_options: STARTTLS (587); sockopts: direct SSL (465).
-        tls_options: [verify: :verify_none],
-        sockopts: [verify: :verify_none]
+        tls_options: [verify: verify_mode],
+        sockopts: [verify: verify_mode]
       ]
       |> Enum.reject(fn {_k, v} -> is_nil(v) end)