fix: datafield edit view was shown alongside othe relements

test/mv_web/live/custom_field_live/deletion_test.exs

@@ -71,6 +71,10 @@ defmodule MvWeb.CustomFieldLive.DeletionTest do
       # Modal should be visible
       assert has_element?(view, "#delete-custom-field-modal")
 
+      # Edit mode: section titles must not reappear when modal opens (regression)
+      refute has_element?(view, "h2", "Member fields")
+      refute has_element?(view, "h2", "Custom fields")
+
       # Should show correct member count (1 member)
       assert render(view) =~ "1 member has a value assigned for this custom field"
 

test/mv_web/live/member_field_live/index_component_test.exs

@@ -83,6 +83,21 @@ defmodule MvWeb.MemberFieldLive.IndexComponentTest do
     end
   end
 
+  describe "edit mode visibility" do
+    test "clicking member field row shows only form, no section titles", %{conn: conn} do
+      {:ok, view, _html} = live(conn, ~p"/admin/datafields")
+
+      # Row click is on the first td (no col_click); click that cell to open edit form
+      view
+      |> element("tr#member_field-first_name td:first-child")
+      |> render_click()
+
+      assert has_element?(view, "#member-field-form-first_name")
+      refute has_element?(view, "h2", "Custom fields")
+      refute has_element?(view, "h2", "Member fields")
+    end
+  end
+
   describe "required fields" do
     setup do
       {:ok, settings} = Membership.get_settings()

test/mv_web/live/statistics_live_test.exs

@@ -29,9 +29,8 @@ defmodule MvWeb.StatisticsLiveTest do
     test "page shows overview of all relevant years without year selector", %{conn: conn} do
       {:ok, _view, html} = live(conn, ~p"/statistics")
 
-      # No year dropdown: single select for year should not be present as main control
-      assert html =~ "Overview" or html =~ "overview"
-      # table header or legend
+      # Page shows multi-year data (member numbers by year) and year column; no single-year selector as main control
+      assert html =~ "Member numbers by year"
       assert html =~ "Year"
     end
 

test/mv_web/user_live/index_test.exs

@@ -123,13 +123,17 @@ defmodule MvWeb.UserLive.IndexTest do
       {:ok, index_view, _html} = live(conn, "/users")
       assert render(index_view) =~ "delete-me@example.com"
 
-      # Navigate to user show and trigger delete from Danger zone
+      # Navigate to user show, open delete modal, then confirm in modal (WCAG modal pattern)
       {:ok, show_view, _html} = live(conn, "/users/#{user.id}")
 
       show_view
       |> element("[data-testid=user-delete]")
       |> render_click()
 
+      show_view
+      |> element("#delete-user-modal button", "Delete")
+      |> render_click()
+
       # Should redirect to index
       assert_redirect(show_view, "/users")