refactor: fix credo warnings and format code

- Replace Enum.map/2 |> Enum.join/2 with Enum.map_join/3 for efficiency
- Refactor get_existing_form_values to reduce cyclomatic complexity
- Replace length/1 with Enum.empty?/1 for better performance
- Update gettext translations

test/mv_web/member_live/membership_fee_integration_test.exs

@@ -75,7 +75,7 @@ defmodule MvWeb.MemberLive.MembershipFeeIntegrationTest do
         |> Ash.Query.filter(member_id == ^member.id)
         |> Ash.read!()
 
-      if length(cycles) > 0 do
+      if !Enum.empty?(cycles) do
         cycle = List.first(cycles)
 
         # Change status

test/mv_web/member_live/show_membership_fees_test.exs

@@ -161,7 +161,9 @@ defmodule MvWeb.MemberLive.ShowMembershipFeesTest do
 
       # Mark as paid
       view
-      |> element("button[phx-click='mark_cycle_status'][phx-value-cycle_id='#{cycle.id}'][phx-value-status='paid']")
+      |> element(
+        "button[phx-click='mark_cycle_status'][phx-value-cycle_id='#{cycle.id}'][phx-value-status='paid']"
+      )
       |> render_click()
 
       # Verify cycle is now paid
@@ -184,7 +186,9 @@ defmodule MvWeb.MemberLive.ShowMembershipFeesTest do
 
       # Mark as suspended
       view
-      |> element("button[phx-click='mark_cycle_status'][phx-value-cycle_id='#{cycle.id}'][phx-value-status='suspended']")
+      |> element(
+        "button[phx-click='mark_cycle_status'][phx-value-cycle_id='#{cycle.id}'][phx-value-status='suspended']"
+      )
       |> render_click()
 
       # Verify cycle is now suspended
@@ -207,7 +211,9 @@ defmodule MvWeb.MemberLive.ShowMembershipFeesTest do
 
       # Mark as unpaid
       view
-      |> element("button[phx-click='mark_cycle_status'][phx-value-cycle_id='#{cycle.id}'][phx-value-status='unpaid']")
+      |> element(
+        "button[phx-click='mark_cycle_status'][phx-value-cycle_id='#{cycle.id}'][phx-value-status='unpaid']"
+      )
       |> render_click()
 
       # Verify cycle is now unpaid