local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 68 Pull requests 8 Projects 1 Releases Packages 1 Activity Actions

refactor: fix credo warnings and format code

Browse source 
- Replace Enum.map/2 |> Enum.join/2 with Enum.map_join/3 for efficiency
- Refactor get_existing_form_values to reduce cyclomatic complexity
- Replace length/1 with Enum.empty?/1 for better performance
- Update gettext translations
This commit is contained in:
Moritz 2025-12-16 13:01:16 +01:00
parent 97c9ef670b
commit 98dc73ee37
Signed by: moritz
GPG key ID: 1020A035E5DD0824
10 changed files with 1180 additions and 159 deletions
Download patch file Download diff file Expand all files Collapse all files

12
test/mv_web/member_live/show_membership_fees_test.exs
View file

@ -161,7 +161,9 @@ defmodule MvWeb.MemberLive.ShowMembershipFeesTest do
# Mark as paid
view
|> element("button[phx-click='mark_cycle_status'][phx-value-cycle_id='#{cycle.id}'][phx-value-status='paid']")
|> element(
"button[phx-click='mark_cycle_status'][phx-value-cycle_id='#{cycle.id}'][phx-value-status='paid']"
)
|> render_click()
# Verify cycle is now paid
@ -184,7 +186,9 @@ defmodule MvWeb.MemberLive.ShowMembershipFeesTest do
# Mark as suspended
view
|> element("button[phx-click='mark_cycle_status'][phx-value-cycle_id='#{cycle.id}'][phx-value-status='suspended']")
|> element(
"button[phx-click='mark_cycle_status'][phx-value-cycle_id='#{cycle.id}'][phx-value-status='suspended']"
)
|> render_click()
# Verify cycle is now suspended
@ -207,7 +211,9 @@ defmodule MvWeb.MemberLive.ShowMembershipFeesTest do
# Mark as unpaid
view
|> element("button[phx-click='mark_cycle_status'][phx-value-cycle_id='#{cycle.id}'][phx-value-status='unpaid']")
|> element(
"button[phx-click='mark_cycle_status'][phx-value-cycle_id='#{cycle.id}'][phx-value-status='unpaid']"
)
|> render_click()
# Verify cycle is now unpaid