fix: translation of login page

lib/mv_web/live/auth/sign_in_live.ex

@@ -1,28 +1,42 @@
 defmodule MvWeb.SignInLive do
   @moduledoc """
-  Custom sign-in page with language selector and conditional Single Sign-On button.
+  Custom sign-in page with public header and hero layout (same as Join/Join Confirm).
 
-  - Renders a language selector (same pattern as LinkOidcAccountLive).
-  - Wraps the default AshAuthentication SignIn component in a container with
-    `data-oidc-configured` so that CSS can hide the SSO button when OIDC is not configured.
+  Uses Layouts.public_page (no sidebar, no app-layout hooks). Wraps the AshAuthentication
+  SignIn component in a hero section. Container has data-oidc-configured so CSS can hide
+  the SSO button when OIDC is not configured.
+
+  Keeps `use Phoenix.LiveView` (not MvWeb :live_view) so AshAuthentication's sign_in_route
+  live_session on_mount chain is not mixed with LiveHelpers hooks.
+
+  ## Locale overrides
+  `MvWeb.AuthOverridesDE` is prepended to the overrides list when the locale is "de",
+  providing static German strings for components that do not use `_gettext` internally
+  (e.g. HorizontalRule renders its `:text` override directly).
   """
   use Phoenix.LiveView
   use Gettext, backend: MvWeb.Gettext
 
   alias AshAuthentication.Phoenix.Components
   alias Mv.Config
+  alias MvWeb.{AuthOverridesDE, Layouts}
 
   @impl true
   def mount(_params, session, socket) do
-    overrides =
-      session
-      |> Map.get("overrides", [AshAuthentication.Phoenix.Overrides.Default])
-
     # Locale: same fallback as LiveUserAuth so config :default_locale (e.g. "en" in test) is respected
-    locale =
-      session["locale"] || Application.get_env(:mv, :default_locale, "de")
+    locale = session["locale"] || Application.get_env(:mv, :default_locale, "de")
 
+    # Set both backend-specific and global locale so Gettext.get_locale/0 and
+    # Gettext.get_locale/1 both return the correct value (important for the
+    # language-selector `selected` attribute in Layouts.public_page).
     Gettext.put_locale(MvWeb.Gettext, locale)
+    Gettext.put_locale(locale)
+
+    # Prepend DE-specific overrides when locale is German so that components
+    # without _gettext support (e.g. HorizontalRule) still render in German.
+    base_overrides = Map.get(session, "overrides", [AshAuthentication.Phoenix.Overrides.Default])
+    locale_overrides = if locale == "de", do: [AuthOverridesDE], else: []
+    overrides = locale_overrides ++ base_overrides
 
     socket =
       socket
@@ -36,10 +50,9 @@ defmodule MvWeb.SignInLive do
       |> assign(:context, session["context"] || %{})
       |> assign(:auth_routes_prefix, session["auth_routes_prefix"])
       |> assign(:gettext_fn, session["gettext_fn"])
-      |> assign(:live_action, :sign_in)
+      |> assign_new(:live_action, fn -> :sign_in end)
       |> assign(:oidc_configured, Config.oidc_configured?())
       |> assign(:oidc_only, Config.oidc_only?())
-      |> assign(:root_class, "grid h-screen place-items-center bg-base-100")
       |> assign(:sign_in_id, "sign-in")
       |> assign(:locale, locale)
 
@@ -54,50 +67,43 @@ defmodule MvWeb.SignInLive do
   @impl true
   def render(assigns) do
     ~H"""
-    <main
-      id="sign-in-page"
-      role="main"
-      class={@root_class}
-      data-oidc-configured={to_string(@oidc_configured)}
-      data-oidc-only={to_string(@oidc_only)}
-      data-locale={@locale}
-    >
-      <h1 class="sr-only">{dgettext("auth", "Sign in")}</h1>
-      <%!-- Language selector --%>
-      <nav
-        aria-label={dgettext("auth", "Language selection")}
-        class="absolute top-4 right-4 flex justify-end z-10"
-      >
-        <form method="post" action="/set_locale" class="text-sm">
-          <input type="hidden" name="_csrf_token" value={Plug.CSRFProtection.get_csrf_token()} />
-          <select
-            name="locale"
-            onchange="this.form.submit()"
-            class="select select-sm select-bordered bg-base-100"
-            aria-label={dgettext("auth", "Select language")}
-          >
-            <option value="de" selected={@locale == "de"}>Deutsch</option>
-            <option value="en" selected={@locale == "en"}>English</option>
-          </select>
-        </form>
-      </nav>
-
-      <.live_component
-        module={Components.SignIn}
-        otp_app={@otp_app}
-        live_action={@live_action}
-        path={@path}
-        auth_routes_prefix={@auth_routes_prefix}
-        resources={@resources}
-        reset_path={@reset_path}
-        register_path={@register_path}
-        id={@sign_in_id}
-        overrides={@overrides}
-        current_tenant={@current_tenant}
-        context={@context}
-        gettext_fn={@gettext_fn}
-      />
-    </main>
+    <Layouts.public_page flash={@flash}>
+      <div class="max-w-4xl mx-auto">
+        <div
+          class="hero min-h-[60vh] bg-base-200 rounded-lg"
+          id="sign-in-page"
+          role="main"
+          data-oidc-configured={to_string(@oidc_configured)}
+          data-oidc-only={to_string(@oidc_only)}
+          data-locale={@locale}
+        >
+          <div class="hero-content flex-col items-start text-left">
+            <div class="w-full max-w-md">
+              <h1 class="text-xl font-semibold leading-8">
+                {if @live_action == :register,
+                  do: dgettext("auth", "Register"),
+                  else: dgettext("auth", "Sign in")}
+              </h1>
+              <.live_component
+                module={Components.SignIn}
+                otp_app={@otp_app}
+                live_action={@live_action}
+                path={@path}
+                auth_routes_prefix={@auth_routes_prefix}
+                resources={@resources}
+                reset_path={@reset_path}
+                register_path={@register_path}
+                id={@sign_in_id}
+                overrides={@overrides}
+                current_tenant={@current_tenant}
+                context={@context}
+                gettext_fn={@gettext_fn}
+              />
+            </div>
+          </div>
+        </div>
+      </div>
+    </Layouts.public_page>
     """
   end
 end