fix: credo error
This commit is contained in:
parent
b4adf63e83
commit
9b314a9806
3 changed files with 1 additions and 14 deletions
|
|
@ -139,9 +139,6 @@ defmodule MvWeb.GroupLive.IndexTest do
|
|||
# Verify all groups are displayed
|
||||
assert html =~ gettext("Groups")
|
||||
|
||||
# Log actual query count for monitoring
|
||||
IO.puts("\n[PERF] GroupLive.Index 'page loads efficiently': #{final_count} queries")
|
||||
|
||||
# Verify query count is reasonable (should avoid N+1 queries)
|
||||
# Expected: 1 query for groups list + 1 batch query for member counts + LiveView setup queries
|
||||
# Allow overhead for authorization, LiveView setup, and other initialization queries
|
||||
|
|
@ -183,11 +180,6 @@ defmodule MvWeb.GroupLive.IndexTest do
|
|||
# Member count should be displayed (should be 2)
|
||||
assert html =~ "2" or html =~ gettext("Members") or html =~ "Mitglieder"
|
||||
|
||||
# Log actual query count for monitoring
|
||||
IO.puts(
|
||||
"\n[PERF] GroupLive.Index 'member count is loaded efficiently': #{final_count} queries"
|
||||
)
|
||||
|
||||
# Verify query count is reasonable (member count should be calculated efficiently)
|
||||
# Expected: 1 query for groups + 1 batch query for member counts + LiveView setup queries
|
||||
# Allow overhead for authorization, LiveView setup, and other initialization queries
|
||||
|
|
|
|||
|
|
@ -256,11 +256,6 @@ defmodule MvWeb.GroupLive.ShowTest do
|
|||
assert html =~ member.first_name or html =~ member.last_name
|
||||
end)
|
||||
|
||||
# Log actual query count for monitoring
|
||||
IO.puts(
|
||||
"\n[PERF] GroupLive.Show 'member list is loaded efficiently': #{final_count} queries"
|
||||
)
|
||||
|
||||
# Verify query count is reasonable (should avoid N+1 queries)
|
||||
# Expected: 1 query for group lookup + 1 query for members (with preload) + member_count aggregate
|
||||
# Allow overhead for authorization, LiveView setup, and other initialization queries
|
||||
|
|
|
|||
|
|
@ -244,7 +244,7 @@ defmodule MvWeb.UserLive.IndexTest do
|
|||
|> Enum.uniq()
|
||||
|
||||
# Skip if no users found (shouldn't happen, but be safe)
|
||||
if length(user_ids) > 0 do
|
||||
if user_ids != [] do
|
||||
# Initially nothing should be checked
|
||||
refute view
|
||||
|> element("input[type='checkbox'][name='select_all'][checked]")
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue