local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 67 Pull requests 7 Projects 3 Releases Packages 1 Activity Actions

fix: credo error
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/promote/production Build is passing
Details

Browse source
This commit is contained in:
Simon 2026-01-29 15:26:45 +01:00
parent b4adf63e83
commit 9b314a9806
Signed by: simon
GPG key ID: 40E7A58C4AA1EDB2
3 changed files with 1 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/mv_web/live/group_live/index_test.exs
View file

@ -139,9 +139,6 @@ defmodule MvWeb.GroupLive.IndexTest do
# Verify all groups are displayed # Verify all groups are displayed
assert html =~ gettext("Groups") assert html =~ gettext("Groups")
# Log actual query count for monitoring
IO.puts("\n[PERF] GroupLive.Index 'page loads efficiently': #{final_count} queries")
# Verify query count is reasonable (should avoid N+1 queries) # Verify query count is reasonable (should avoid N+1 queries)
# Expected: 1 query for groups list + 1 batch query for member counts + LiveView setup queries # Expected: 1 query for groups list + 1 batch query for member counts + LiveView setup queries
# Allow overhead for authorization, LiveView setup, and other initialization queries # Allow overhead for authorization, LiveView setup, and other initialization queries
@ -183,11 +180,6 @@ defmodule MvWeb.GroupLive.IndexTest do
# Member count should be displayed (should be 2) # Member count should be displayed (should be 2)
assert html =~ "2" or html =~ gettext("Members") or html =~ "Mitglieder" assert html =~ "2" or html =~ gettext("Members") or html =~ "Mitglieder"
# Log actual query count for monitoring
IO.puts(
"\n[PERF] GroupLive.Index 'member count is loaded efficiently': #{final_count} queries"
)
# Verify query count is reasonable (member count should be calculated efficiently) # Verify query count is reasonable (member count should be calculated efficiently)
# Expected: 1 query for groups + 1 batch query for member counts + LiveView setup queries # Expected: 1 query for groups + 1 batch query for member counts + LiveView setup queries
# Allow overhead for authorization, LiveView setup, and other initialization queries # Allow overhead for authorization, LiveView setup, and other initialization queries

5
test/mv_web/live/group_live/show_test.exs
View file

@ -256,11 +256,6 @@ defmodule MvWeb.GroupLive.ShowTest do
assert html =~ member.first_name or html =~ member.last_name assert html =~ member.first_name or html =~ member.last_name
end) end)
# Log actual query count for monitoring
IO.puts(
"\n[PERF] GroupLive.Show 'member list is loaded efficiently': #{final_count} queries"
)
# Verify query count is reasonable (should avoid N+1 queries) # Verify query count is reasonable (should avoid N+1 queries)
# Expected: 1 query for group lookup + 1 query for members (with preload) + member_count aggregate # Expected: 1 query for group lookup + 1 query for members (with preload) + member_count aggregate
# Allow overhead for authorization, LiveView setup, and other initialization queries # Allow overhead for authorization, LiveView setup, and other initialization queries

2
test/mv_web/user_live/index_test.exs
View file

@ -244,7 +244,7 @@ defmodule MvWeb.UserLive.IndexTest do
|> Enum.uniq() |> Enum.uniq()
# Skip if no users found (shouldn't happen, but be safe) # Skip if no users found (shouldn't happen, but be safe)
if length(user_ids) > 0 do if user_ids != [] do
# Initially nothing should be checked # Initially nothing should be checked
refute view refute view
|> element("input[type='checkbox'][name='select_all'][checked]") |> element("input[type='checkbox'][name='select_all'][checked]")