Tests: use Mv.Fixtures, fix warnings, Credo TODO disable

- Policy tests: use Fixtures where applicable; create_custom_field() fix in custom_field_value.
- Replace unused actor with _actor, remove unused alias Accounts in policy tests.
- profile_navigation_test: disable Credo for intentional TODO comment.

test/mv/membership/group_policies_test.exs

@@ -8,8 +8,6 @@ defmodule Mv.Membership.GroupPoliciesTest do
   use Mv.DataCase, async: false
 
   alias Mv.Membership
-  alias Mv.Accounts
-  alias Mv.Authorization
 
   require Ash.Query
 
@@ -18,49 +16,8 @@ defmodule Mv.Membership.GroupPoliciesTest do
     %{actor: system_actor}
   end
 
-  defp create_role_with_permission_set(permission_set_name, actor) do
-    role_name = "Test Role #{permission_set_name} #{System.unique_integer([:positive])}"
-
-    case Authorization.create_role(
-           %{
-             name: role_name,
-             description: "Test role for #{permission_set_name}",
-             permission_set_name: permission_set_name
-           },
-           actor: actor
-         ) do
-      {:ok, role} -> role
-      {:error, error} -> raise "Failed to create role: #{inspect(error)}"
-    end
-  end
-
-  defp create_user_with_permission_set(permission_set_name, actor) do
-    role = create_role_with_permission_set(permission_set_name, actor)
-
-    {:ok, user} =
-      Accounts.User
-      |> Ash.Changeset.for_create(:register_with_password, %{
-        email: "user#{System.unique_integer([:positive])}@example.com",
-        password: "testpassword123"
-      })
-      |> Ash.create(actor: actor)
-
-    {:ok, user} =
-      user
-      |> Ash.Changeset.for_update(:update, %{})
-      |> Ash.Changeset.manage_relationship(:role, role, type: :append_and_remove)
-      |> Ash.update(actor: actor)
-
-    {:ok, user_with_role} = Ash.load(user, :role, domain: Mv.Accounts, actor: actor)
-    user_with_role
-  end
-
-  defp create_admin_user(actor) do
-    create_user_with_permission_set("admin", actor)
-  end
-
-  defp create_group_fixture(actor) do
-    admin = create_admin_user(actor)
+  defp create_group_fixture do
+    admin = Mv.Fixtures.user_with_role_fixture("admin")
 
     {:ok, group} =
       Membership.create_group(
@@ -72,9 +29,9 @@ defmodule Mv.Membership.GroupPoliciesTest do
   end
 
   describe "own_data permission set" do
-    setup %{actor: actor} do
-      user = create_user_with_permission_set("own_data", actor)
-      group = create_group_fixture(actor)
+    setup %{actor: _actor} do
+      user = Mv.Fixtures.user_with_role_fixture("own_data")
+      group = create_group_fixture()
       %{user: user, group: group}
     end
 
@@ -90,9 +47,9 @@ defmodule Mv.Membership.GroupPoliciesTest do
   end
 
   describe "read_only permission set" do
-    setup %{actor: actor} do
-      user = create_user_with_permission_set("read_only", actor)
-      group = create_group_fixture(actor)
+    setup %{actor: _actor} do
+      user = Mv.Fixtures.user_with_role_fixture("read_only")
+      group = create_group_fixture()
       %{user: user, group: group}
     end
 
@@ -108,9 +65,9 @@ defmodule Mv.Membership.GroupPoliciesTest do
   end
 
   describe "normal_user permission set" do
-    setup %{actor: actor} do
-      user = create_user_with_permission_set("normal_user", actor)
-      group = create_group_fixture(actor)
+    setup %{actor: _actor} do
+      user = Mv.Fixtures.user_with_role_fixture("normal_user")
+      group = create_group_fixture()
       %{user: user, group: group}
     end
 
@@ -147,9 +104,9 @@ defmodule Mv.Membership.GroupPoliciesTest do
   end
 
   describe "admin permission set" do
-    setup %{actor: actor} do
-      user = create_user_with_permission_set("admin", actor)
-      group = create_group_fixture(actor)
+    setup %{actor: _actor} do
+      user = Mv.Fixtures.user_with_role_fixture("admin")
+      group = create_group_fixture()
       %{user: user, group: group}
     end