Tests: use Mv.Fixtures, fix warnings, Credo TODO disable

- Policy tests: use Fixtures where applicable; create_custom_field() fix in custom_field_value.
- Replace unused actor with _actor, remove unused alias Accounts in policy tests.
- profile_navigation_test: disable Credo for intentional TODO comment.

test/mv/membership_fees/membership_fee_cycle_policies_test.exs

@@ -10,57 +10,14 @@ defmodule Mv.MembershipFees.MembershipFeeCyclePoliciesTest do
 
   alias Mv.MembershipFees
   alias Mv.Membership
-  alias Mv.Accounts
-  alias Mv.Authorization
 
   setup do
     system_actor = Mv.Helpers.SystemActor.get_system_actor()
     %{actor: system_actor}
   end
 
-  defp create_role_with_permission_set(permission_set_name, actor) do
-    role_name = "Test Role #{permission_set_name} #{System.unique_integer([:positive])}"
-
-    case Authorization.create_role(
-           %{
-             name: role_name,
-             description: "Test role for #{permission_set_name}",
-             permission_set_name: permission_set_name
-           },
-           actor: actor
-         ) do
-      {:ok, role} -> role
-      {:error, error} -> raise "Failed to create role: #{inspect(error)}"
-    end
-  end
-
-  defp create_user_with_permission_set(permission_set_name, actor) do
-    role = create_role_with_permission_set(permission_set_name, actor)
-
-    {:ok, user} =
-      Accounts.User
-      |> Ash.Changeset.for_create(:register_with_password, %{
-        email: "user#{System.unique_integer([:positive])}@example.com",
-        password: "testpassword123"
-      })
-      |> Ash.create(actor: actor)
-
-    {:ok, user} =
-      user
-      |> Ash.Changeset.for_update(:update, %{})
-      |> Ash.Changeset.manage_relationship(:role, role, type: :append_and_remove)
-      |> Ash.update(actor: actor)
-
-    {:ok, user_with_role} = Ash.load(user, :role, domain: Mv.Accounts, actor: actor)
-    user_with_role
-  end
-
-  defp create_admin_user(actor) do
-    create_user_with_permission_set("admin", actor)
-  end
-
-  defp create_member_fixture(actor) do
-    admin = create_admin_user(actor)
+  defp create_member_fixture do
+    admin = Mv.Fixtures.user_with_role_fixture("admin")
 
     {:ok, member} =
       Membership.create_member(
@@ -75,8 +32,8 @@ defmodule Mv.MembershipFees.MembershipFeeCyclePoliciesTest do
     member
   end
 
-  defp create_fee_type_fixture(actor) do
-    admin = create_admin_user(actor)
+  defp create_fee_type_fixture do
+    admin = Mv.Fixtures.user_with_role_fixture("admin")
 
     {:ok, fee_type} =
       MembershipFees.create_membership_fee_type(
@@ -92,10 +49,10 @@ defmodule Mv.MembershipFees.MembershipFeeCyclePoliciesTest do
     fee_type
   end
 
-  defp create_cycle_fixture(actor) do
-    admin = create_admin_user(actor)
-    member = create_member_fixture(actor)
-    fee_type = create_fee_type_fixture(actor)
+  defp create_cycle_fixture do
+    admin = Mv.Fixtures.user_with_role_fixture("admin")
+    member = create_member_fixture()
+    fee_type = create_fee_type_fixture()
 
     {:ok, cycle} =
       MembershipFees.create_membership_fee_cycle(
@@ -114,8 +71,8 @@ defmodule Mv.MembershipFees.MembershipFeeCyclePoliciesTest do
 
   describe "read_only permission set" do
     setup %{actor: actor} do
-      user = create_user_with_permission_set("read_only", actor)
-      cycle = create_cycle_fixture(actor)
+      user = Mv.Fixtures.user_with_role_fixture("read_only")
+      cycle = create_cycle_fixture()
       %{actor: actor, user: user, cycle: cycle}
     end
 
@@ -139,9 +96,9 @@ defmodule Mv.MembershipFees.MembershipFeeCyclePoliciesTest do
                |> Ash.update(actor: user, domain: Mv.MembershipFees)
     end
 
-    test "cannot create cycle (returns forbidden)", %{user: user, actor: actor} do
-      member = create_member_fixture(actor)
-      fee_type = create_fee_type_fixture(actor)
+    test "cannot create cycle (returns forbidden)", %{user: user, actor: _actor} do
+      member = create_member_fixture()
+      fee_type = create_fee_type_fixture()
 
       assert {:error, %Ash.Error.Forbidden{}} =
                MembershipFees.create_membership_fee_cycle(
@@ -164,8 +121,8 @@ defmodule Mv.MembershipFees.MembershipFeeCyclePoliciesTest do
 
   describe "normal_user permission set" do
     setup %{actor: actor} do
-      user = create_user_with_permission_set("normal_user", actor)
-      cycle = create_cycle_fixture(actor)
+      user = Mv.Fixtures.user_with_role_fixture("normal_user")
+      cycle = create_cycle_fixture()
       %{actor: actor, user: user, cycle: cycle}
     end
 
@@ -193,9 +150,9 @@ defmodule Mv.MembershipFees.MembershipFeeCyclePoliciesTest do
       assert updated.status == :paid
     end
 
-    test "can create cycle", %{user: user, actor: actor} do
-      member = create_member_fixture(actor)
-      fee_type = create_fee_type_fixture(actor)
+    test "can create cycle", %{user: user, actor: _actor} do
+      member = create_member_fixture()
+      fee_type = create_fee_type_fixture()
 
       assert {:ok, created} =
                MembershipFees.create_membership_fee_cycle(
@@ -219,8 +176,8 @@ defmodule Mv.MembershipFees.MembershipFeeCyclePoliciesTest do
 
   describe "admin permission set" do
     setup %{actor: actor} do
-      user = create_user_with_permission_set("admin", actor)
-      cycle = create_cycle_fixture(actor)
+      user = Mv.Fixtures.user_with_role_fixture("admin")
+      cycle = create_cycle_fixture()
       %{actor: actor, user: user, cycle: cycle}
     end
 
@@ -253,9 +210,9 @@ defmodule Mv.MembershipFees.MembershipFeeCyclePoliciesTest do
       assert updated.status == :paid
     end
 
-    test "can create cycle", %{user: user, actor: actor} do
-      member = create_member_fixture(actor)
-      fee_type = create_fee_type_fixture(actor)
+    test "can create cycle", %{user: user, actor: _actor} do
+      member = create_member_fixture()
+      fee_type = create_fee_type_fixture()
 
       assert {:ok, created} =
                MembershipFees.create_membership_fee_cycle(