refactor: apply review changes to joinrequest

test/membership/join_request_test.exs

@@ -98,8 +98,20 @@ defmodule Mv.Membership.JoinRequestTest do
       assert {:error, _} = Membership.confirm_join_request("nonexistent-token", actor: nil)
     end
 
-    @tag :skip
-    test "returns error when token is expired (requires fixture for expired token)"
+    test "returns error when token is expired" do
+      token = "expired-token-#{System.unique_integer([:positive])}"
+      attrs = Map.put(@valid_submit_attrs, :confirmation_token, token)
+
+      {:ok, request} = Membership.submit_join_request(attrs, actor: nil)
+      past = DateTime.add(DateTime.utc_now(), -1, :hour)
+      id_binary = Ecto.UUID.dump!(request.id)
+
+      from(j in "join_requests", where: fragment("id = ?", ^id_binary))
+      |> Repo.update_all(set: [confirmation_token_expires_at: past])
+
+      assert {:error, :token_expired} =
+               Membership.confirm_join_request(token, actor: nil)
+    end
   end
 
   describe "policies (actor: nil)" do