Add actor parameter to all tests requiring authorization

This commit adds actor: system_actor to all Ash operations in tests that
require authorization.

test/membership/custom_field_value_validation_test.exs

@@ -13,6 +13,8 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
   alias Mv.Membership.{CustomField, CustomFieldValue, Member}
 
   setup do
+    system_actor = Mv.Helpers.SystemActor.get_system_actor()
+
     # Create a test member
     {:ok, member} =
       Member
@@ -21,7 +23,7 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
         last_name: "User",
         email: "test.validation@example.com"
       })
-      |> Ash.create()
+      |> Ash.create(actor: system_actor)
 
     # Create custom fields for different types
     {:ok, string_field} =
@@ -30,7 +32,7 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
         name: "string_field",
         value_type: :string
       })
-      |> Ash.create()
+      |> Ash.create(actor: system_actor)
 
     {:ok, integer_field} =
       CustomField
@@ -38,7 +40,7 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
         name: "integer_field",
         value_type: :integer
       })
-      |> Ash.create()
+      |> Ash.create(actor: system_actor)
 
     {:ok, email_field} =
       CustomField
@@ -46,9 +48,10 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
         name: "email_field",
         value_type: :email
       })
-      |> Ash.create()
+      |> Ash.create(actor: system_actor)
 
     %{
+      actor: system_actor,
       member: member,
       string_field: string_field,
       integer_field: integer_field,
@@ -58,6 +61,7 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
 
   describe "string value length validation" do
     test "accepts string value with exactly 10,000 characters", %{
+      actor: system_actor,
       member: member,
       string_field: string_field
     } do
@@ -73,13 +77,14 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                    "_union_value" => value_string
                  }
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       assert custom_field_value.value.value == value_string
       assert String.length(custom_field_value.value.value) == 10_000
     end
 
     test "rejects string value with 10,001 characters", %{
+      actor: system_actor,
       member: member,
       string_field: string_field
     } do
@@ -92,14 +97,18 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: string_field.id,
                  value: %{"_union_type" => "string", "_union_value" => value_string}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       assert Enum.any?(changeset.errors, fn error ->
                error.field == :value and (error.message =~ "max" or error.message =~ "length")
              end)
     end
 
-    test "trims whitespace from string value", %{member: member, string_field: string_field} do
+    test "trims whitespace from string value", %{
+      actor: system_actor,
+      member: member,
+      string_field: string_field
+    } do
       assert {:ok, custom_field_value} =
                CustomFieldValue
                |> Ash.Changeset.for_create(:create, %{
@@ -107,12 +116,16 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: string_field.id,
                  value: %{"_union_type" => "string", "_union_value" => "  test value  "}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       assert custom_field_value.value.value == "test value"
     end
 
-    test "accepts empty string value", %{member: member, string_field: string_field} do
+    test "accepts empty string value", %{
+      actor: system_actor,
+      member: member,
+      string_field: string_field
+    } do
       assert {:ok, custom_field_value} =
                CustomFieldValue
                |> Ash.Changeset.for_create(:create, %{
@@ -120,13 +133,17 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: string_field.id,
                  value: %{"_union_type" => "string", "_union_value" => ""}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       # Empty strings after trimming become nil
       assert custom_field_value.value.value == nil
     end
 
-    test "accepts string with special characters", %{member: member, string_field: string_field} do
+    test "accepts string with special characters", %{
+      actor: system_actor,
+      member: member,
+      string_field: string_field
+    } do
       special_string = "Hello 世界! 🎉 @#$%^&*()"
 
       assert {:ok, custom_field_value} =
@@ -136,14 +153,18 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: string_field.id,
                  value: %{"_union_type" => "string", "_union_value" => special_string}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       assert custom_field_value.value.value == special_string
     end
   end
 
   describe "integer value validation" do
-    test "accepts valid integer value", %{member: member, integer_field: integer_field} do
+    test "accepts valid integer value", %{
+      actor: system_actor,
+      member: member,
+      integer_field: integer_field
+    } do
       assert {:ok, custom_field_value} =
                CustomFieldValue
                |> Ash.Changeset.for_create(:create, %{
@@ -151,12 +172,16 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: integer_field.id,
                  value: %{"_union_type" => "integer", "_union_value" => 42}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       assert custom_field_value.value.value == 42
     end
 
-    test "accepts negative integer", %{member: member, integer_field: integer_field} do
+    test "accepts negative integer", %{
+      actor: system_actor,
+      member: member,
+      integer_field: integer_field
+    } do
       assert {:ok, custom_field_value} =
                CustomFieldValue
                |> Ash.Changeset.for_create(:create, %{
@@ -164,12 +189,12 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: integer_field.id,
                  value: %{"_union_type" => "integer", "_union_value" => -100}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       assert custom_field_value.value.value == -100
     end
 
-    test "accepts zero", %{member: member, integer_field: integer_field} do
+    test "accepts zero", %{actor: system_actor, member: member, integer_field: integer_field} do
       assert {:ok, custom_field_value} =
                CustomFieldValue
                |> Ash.Changeset.for_create(:create, %{
@@ -177,14 +202,18 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: integer_field.id,
                  value: %{"_union_type" => "integer", "_union_value" => 0}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       assert custom_field_value.value.value == 0
     end
   end
 
   describe "email value validation" do
-    test "accepts nil value (optional field)", %{member: member, email_field: email_field} do
+    test "accepts nil value (optional field)", %{
+      actor: system_actor,
+      member: member,
+      email_field: email_field
+    } do
       assert {:ok, custom_field_value} =
                CustomFieldValue
                |> Ash.Changeset.for_create(:create, %{
@@ -192,12 +221,13 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: email_field.id,
                  value: %{"_union_type" => "email", "_union_value" => nil}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       assert custom_field_value.value.value == nil
     end
 
     test "accepts empty string (becomes nil after trim)", %{
+      actor: system_actor,
       member: member,
       email_field: email_field
     } do
@@ -208,13 +238,13 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: email_field.id,
                  value: %{"_union_type" => "email", "_union_value" => ""}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       # Empty string after trim should become nil
       assert custom_field_value.value.value == nil
     end
 
-    test "accepts valid email", %{member: member, email_field: email_field} do
+    test "accepts valid email", %{actor: system_actor, member: member, email_field: email_field} do
       assert {:ok, custom_field_value} =
                CustomFieldValue
                |> Ash.Changeset.for_create(:create, %{
@@ -222,12 +252,16 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: email_field.id,
                  value: %{"_union_type" => "email", "_union_value" => "test@example.com"}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       assert custom_field_value.value.value == "test@example.com"
     end
 
-    test "rejects invalid email format", %{member: member, email_field: email_field} do
+    test "rejects invalid email format", %{
+      actor: system_actor,
+      member: member,
+      email_field: email_field
+    } do
       assert {:error, changeset} =
                CustomFieldValue
                |> Ash.Changeset.for_create(:create, %{
@@ -235,12 +269,16 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: email_field.id,
                  value: %{"_union_type" => "email", "_union_value" => "not-an-email"}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       assert Enum.any?(changeset.errors, fn error -> error.field == :value end)
     end
 
-    test "rejects email longer than 254 characters", %{member: member, email_field: email_field} do
+    test "rejects email longer than 254 characters", %{
+      actor: system_actor,
+      member: member,
+      email_field: email_field
+    } do
       # Create an email with >254 chars (243 + 12 = 255)
       long_email = String.duplicate("a", 243) <> "@example.com"
 
@@ -251,12 +289,16 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: email_field.id,
                  value: %{"_union_type" => "email", "_union_value" => long_email}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       assert Enum.any?(changeset.errors, fn error -> error.field == :value end)
     end
 
-    test "trims whitespace from email", %{member: member, email_field: email_field} do
+    test "trims whitespace from email", %{
+      actor: system_actor,
+      member: member,
+      email_field: email_field
+    } do
       assert {:ok, custom_field_value} =
                CustomFieldValue
                |> Ash.Changeset.for_create(:create, %{
@@ -264,7 +306,7 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: email_field.id,
                  value: %{"_union_type" => "email", "_union_value" => "  test@example.com  "}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       assert custom_field_value.value.value == "test@example.com"
     end
@@ -272,6 +314,7 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
 
   describe "uniqueness constraint" do
     test "rejects duplicate custom_field_id per member", %{
+      actor: system_actor,
       member: member,
       string_field: string_field
     } do
@@ -283,7 +326,7 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: string_field.id,
                  value: %{"_union_type" => "string", "_union_value" => "first value"}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       # Try to create second custom field value with same custom_field_id for same member
       assert {:error, changeset} =
@@ -293,7 +336,7 @@ defmodule Mv.Membership.CustomFieldValueValidationTest do
                  custom_field_id: string_field.id,
                  value: %{"_union_type" => "string", "_union_value" => "second value"}
                })
-               |> Ash.create()
+               |> Ash.create(actor: system_actor)
 
       # Should have uniqueness error
       assert Enum.any?(changeset.errors, fn error ->