Add actor parameter to all tests requiring authorization

This commit adds actor: system_actor to all Ash operations in tests that
require authorization.

test/mv_web/member_live/index_test.exs

@@ -223,13 +223,18 @@ defmodule MvWeb.MemberLive.IndexTest do
   end
 
   test "can delete a member without error", %{conn: conn} do
+    system_actor = Mv.Helpers.SystemActor.get_system_actor()
+
     # Create a test member first
     {:ok, member} =
-      Mv.Membership.create_member(%{
-        first_name: "Test",
-        last_name: "User",
-        email: "test@example.com"
-      })
+      Mv.Membership.create_member(
+        %{
+          first_name: "Test",
+          last_name: "User",
+          email: "test@example.com"
+        },
+        actor: system_actor
+      )
 
     conn = conn_with_oidc_user(conn)
     {:ok, index_view, _html} = live(conn, "/members")
@@ -251,27 +256,38 @@ defmodule MvWeb.MemberLive.IndexTest do
 
   describe "copy_emails feature" do
     setup do
+      system_actor = Mv.Helpers.SystemActor.get_system_actor()
+
       # Create test members
       {:ok, member1} =
-        Mv.Membership.create_member(%{
-          first_name: "Max",
-          last_name: "Mustermann",
-          email: "max@example.com"
-        })
+        Mv.Membership.create_member(
+          %{
+            first_name: "Max",
+            last_name: "Mustermann",
+            email: "max@example.com"
+          },
+          actor: system_actor
+        )
 
       {:ok, member2} =
-        Mv.Membership.create_member(%{
-          first_name: "Erika",
-          last_name: "Musterfrau",
-          email: "erika@example.com"
-        })
+        Mv.Membership.create_member(
+          %{
+            first_name: "Erika",
+            last_name: "Musterfrau",
+            email: "erika@example.com"
+          },
+          actor: system_actor
+        )
 
       {:ok, member3} =
-        Mv.Membership.create_member(%{
-          first_name: "Hans",
-          last_name: "Müller-Lüdenscheidt",
-          email: "hans@example.com"
-        })
+        Mv.Membership.create_member(
+          %{
+            first_name: "Hans",
+            last_name: "Müller-Lüdenscheidt",
+            email: "hans@example.com"
+          },
+          actor: system_actor
+        )
 
       %{member1: member1, member2: member2, member3: member3}
     end
@@ -351,7 +367,8 @@ defmodule MvWeb.MemberLive.IndexTest do
       render_click(view, "select_member", %{"id" => member1.id})
 
       # Delete the member from the database
-      Ash.destroy!(member1)
+      system_actor = Mv.Helpers.SystemActor.get_system_actor()
+      Ash.destroy!(member1, actor: system_actor)
 
       # Trigger copy_emails event directly - selection still contains the deleted ID
       # but the member is no longer in @members list after reload
@@ -391,12 +408,17 @@ defmodule MvWeb.MemberLive.IndexTest do
       conn = conn_with_oidc_user(conn)
 
       # Create a member with known data
+      system_actor = Mv.Helpers.SystemActor.get_system_actor()
+
       {:ok, test_member} =
-        Mv.Membership.create_member(%{
-          first_name: "Test",
-          last_name: "Format",
-          email: "test.format@example.com"
-        })
+        Mv.Membership.create_member(
+          %{
+            first_name: "Test",
+            last_name: "Format",
+            email: "test.format@example.com"
+          },
+          actor: system_actor
+        )
 
       {:ok, view, _html} = live(conn, "/members")
 
@@ -461,7 +483,7 @@ defmodule MvWeb.MemberLive.IndexTest do
     alias Mv.MembershipFees.MembershipFeeCycle
 
     # Helper to create a membership fee type
-    defp create_fee_type(attrs) do
+    defp create_fee_type(attrs, actor) do
       default_attrs = %{
         name: "Test Fee Type #{System.unique_integer([:positive])}",
         amount: Decimal.new("50.00"),
@@ -472,11 +494,11 @@ defmodule MvWeb.MemberLive.IndexTest do
 
       MembershipFeeType
       |> Ash.Changeset.for_create(:create, attrs)
-      |> Ash.create!()
+      |> Ash.create!(actor: actor)
     end
 
     # Helper to create a member
-    defp create_member(attrs) do
+    defp create_member(attrs, actor) do
       default_attrs = %{
         first_name: "Test",
         last_name: "Member",
@@ -487,18 +509,18 @@ defmodule MvWeb.MemberLive.IndexTest do
 
       Mv.Membership.Member
       |> Ash.Changeset.for_create(:create_member, attrs)
-      |> Ash.create!()
+      |> Ash.create!(actor: actor)
     end
 
     # Helper to create a cycle
-    defp create_cycle(member, fee_type, attrs) do
+    defp create_cycle(member, fee_type, attrs, actor) do
       # Delete any auto-generated cycles first to avoid conflicts
       existing_cycles =
         MembershipFeeCycle
         |> Ash.Query.filter(member_id == ^member.id)
-        |> Ash.read!()
+        |> Ash.read!(actor: actor)
 
-      Enum.each(existing_cycles, fn cycle -> Ash.destroy!(cycle) end)
+      Enum.each(existing_cycles, fn cycle -> Ash.destroy!(cycle, actor: actor) end)
 
       default_attrs = %{
         cycle_start: ~D[2023-01-01],
@@ -512,32 +534,49 @@ defmodule MvWeb.MemberLive.IndexTest do
 
       MembershipFeeCycle
       |> Ash.Changeset.for_create(:create, attrs)
-      |> Ash.create!()
+      |> Ash.create!(actor: actor)
     end
 
     test "filter shows only members with paid status in last cycle", %{conn: conn} do
+      system_actor = Mv.Helpers.SystemActor.get_system_actor()
       conn = conn_with_oidc_user(conn)
-      fee_type = create_fee_type(%{interval: :yearly})
+      fee_type = create_fee_type(%{interval: :yearly}, system_actor)
       today = Date.utc_today()
       last_year_start = Date.new!(today.year - 1, 1, 1)
 
       # Member with paid last cycle
       paid_member =
-        create_member(%{
-          first_name: "PaidLast",
-          membership_fee_type_id: fee_type.id
-        })
+        create_member(
+          %{
+            first_name: "PaidLast",
+            membership_fee_type_id: fee_type.id
+          },
+          system_actor
+        )
 
-      create_cycle(paid_member, fee_type, %{cycle_start: last_year_start, status: :paid})
+      create_cycle(
+        paid_member,
+        fee_type,
+        %{cycle_start: last_year_start, status: :paid},
+        system_actor
+      )
 
       # Member with unpaid last cycle
       unpaid_member =
-        create_member(%{
-          first_name: "UnpaidLast",
-          membership_fee_type_id: fee_type.id
-        })
+        create_member(
+          %{
+            first_name: "UnpaidLast",
+            membership_fee_type_id: fee_type.id
+          },
+          system_actor
+        )
 
-      create_cycle(unpaid_member, fee_type, %{cycle_start: last_year_start, status: :unpaid})
+      create_cycle(
+        unpaid_member,
+        fee_type,
+        %{cycle_start: last_year_start, status: :unpaid},
+        system_actor
+      )
 
       {:ok, _view, html} = live(conn, "/members?cycle_status_filter=paid")
 
@@ -546,28 +585,45 @@ defmodule MvWeb.MemberLive.IndexTest do
     end
 
     test "filter shows only members with unpaid status in last cycle", %{conn: conn} do
+      system_actor = Mv.Helpers.SystemActor.get_system_actor()
       conn = conn_with_oidc_user(conn)
-      fee_type = create_fee_type(%{interval: :yearly})
+      fee_type = create_fee_type(%{interval: :yearly}, system_actor)
       today = Date.utc_today()
       last_year_start = Date.new!(today.year - 1, 1, 1)
 
       # Member with paid last cycle
       paid_member =
-        create_member(%{
-          first_name: "PaidLast",
-          membership_fee_type_id: fee_type.id
-        })
+        create_member(
+          %{
+            first_name: "PaidLast",
+            membership_fee_type_id: fee_type.id
+          },
+          system_actor
+        )
 
-      create_cycle(paid_member, fee_type, %{cycle_start: last_year_start, status: :paid})
+      create_cycle(
+        paid_member,
+        fee_type,
+        %{cycle_start: last_year_start, status: :paid},
+        system_actor
+      )
 
       # Member with unpaid last cycle
       unpaid_member =
-        create_member(%{
-          first_name: "UnpaidLast",
-          membership_fee_type_id: fee_type.id
-        })
+        create_member(
+          %{
+            first_name: "UnpaidLast",
+            membership_fee_type_id: fee_type.id
+          },
+          system_actor
+        )
 
-      create_cycle(unpaid_member, fee_type, %{cycle_start: last_year_start, status: :unpaid})
+      create_cycle(
+        unpaid_member,
+        fee_type,
+        %{cycle_start: last_year_start, status: :unpaid},
+        system_actor
+      )
 
       {:ok, _view, html} = live(conn, "/members?cycle_status_filter=unpaid")
 
@@ -576,28 +632,45 @@ defmodule MvWeb.MemberLive.IndexTest do
     end
 
     test "filter shows only members with paid status in current cycle", %{conn: conn} do
+      system_actor = Mv.Helpers.SystemActor.get_system_actor()
       conn = conn_with_oidc_user(conn)
-      fee_type = create_fee_type(%{interval: :yearly})
+      fee_type = create_fee_type(%{interval: :yearly}, system_actor)
       today = Date.utc_today()
       current_year_start = Date.new!(today.year, 1, 1)
 
       # Member with paid current cycle
       paid_member =
-        create_member(%{
-          first_name: "PaidCurrent",
-          membership_fee_type_id: fee_type.id
-        })
+        create_member(
+          %{
+            first_name: "PaidCurrent",
+            membership_fee_type_id: fee_type.id
+          },
+          system_actor
+        )
 
-      create_cycle(paid_member, fee_type, %{cycle_start: current_year_start, status: :paid})
+      create_cycle(
+        paid_member,
+        fee_type,
+        %{cycle_start: current_year_start, status: :paid},
+        system_actor
+      )
 
       # Member with unpaid current cycle
       unpaid_member =
-        create_member(%{
-          first_name: "UnpaidCurrent",
-          membership_fee_type_id: fee_type.id
-        })
+        create_member(
+          %{
+            first_name: "UnpaidCurrent",
+            membership_fee_type_id: fee_type.id
+          },
+          system_actor
+        )
 
-      create_cycle(unpaid_member, fee_type, %{cycle_start: current_year_start, status: :unpaid})
+      create_cycle(
+        unpaid_member,
+        fee_type,
+        %{cycle_start: current_year_start, status: :unpaid},
+        system_actor
+      )
 
       {:ok, _view, html} = live(conn, "/members?cycle_status_filter=paid&show_current_cycle=true")
 
@@ -606,28 +679,45 @@ defmodule MvWeb.MemberLive.IndexTest do
     end
 
     test "filter shows only members with unpaid status in current cycle", %{conn: conn} do
+      system_actor = Mv.Helpers.SystemActor.get_system_actor()
       conn = conn_with_oidc_user(conn)
-      fee_type = create_fee_type(%{interval: :yearly})
+      fee_type = create_fee_type(%{interval: :yearly}, system_actor)
       today = Date.utc_today()
       current_year_start = Date.new!(today.year, 1, 1)
 
       # Member with paid current cycle
       paid_member =
-        create_member(%{
-          first_name: "PaidCurrent",
-          membership_fee_type_id: fee_type.id
-        })
+        create_member(
+          %{
+            first_name: "PaidCurrent",
+            membership_fee_type_id: fee_type.id
+          },
+          system_actor
+        )
 
-      create_cycle(paid_member, fee_type, %{cycle_start: current_year_start, status: :paid})
+      create_cycle(
+        paid_member,
+        fee_type,
+        %{cycle_start: current_year_start, status: :paid},
+        system_actor
+      )
 
       # Member with unpaid current cycle
       unpaid_member =
-        create_member(%{
-          first_name: "UnpaidCurrent",
-          membership_fee_type_id: fee_type.id
-        })
+        create_member(
+          %{
+            first_name: "UnpaidCurrent",
+            membership_fee_type_id: fee_type.id
+          },
+          system_actor
+        )
 
-      create_cycle(unpaid_member, fee_type, %{cycle_start: current_year_start, status: :unpaid})
+      create_cycle(
+        unpaid_member,
+        fee_type,
+        %{cycle_start: current_year_start, status: :unpaid},
+        system_actor
+      )
 
       {:ok, _view, html} =
         live(conn, "/members?cycle_status_filter=unpaid&show_current_cycle=true")