feat(member): condense the overview into composite name and address cells

test/mv_web/member_live/index_test.exs

@@ -154,9 +154,13 @@ defmodule MvWeb.MemberLive.IndexTest do
 
   describe "sorting integration" do
     @describetag :ui
+    # The curated default columns no longer expose the individual name/address
+    # sort headers, so these tests make the relevant column visible via ?fields=.
+    # That puts a `fields` param on every push_patch, hence the relaxed
+    # substring assertions instead of exact patch strings.
     test "clicking a column header toggles sort order and updates the URL", %{conn: conn} do
       conn = conn_with_oidc_user(conn)
-      {:ok, view, _html} = live(conn, "/members")
+      {:ok, view, _html} = live(conn, "/members?fields=email")
 
       # The component data test ids are built with the name of the field
       # First click – should sort ASC
@@ -164,32 +168,44 @@ defmodule MvWeb.MemberLive.IndexTest do
       |> element("[data-testid='email']")
       |> render_click()
 
-      # The LiveView pushes a patch with the new query params
-      assert_patch(view, "/members?query=&sort_field=email&sort_order=asc")
+      path_asc = assert_patch(view)
+      assert path_asc =~ "sort_field=email"
+      assert path_asc =~ "sort_order=asc"
 
       # Second click – toggles to DESC
       view
       |> element("[data-testid='email']")
       |> render_click()
 
-      assert_patch(view, "/members?query=&sort_field=email&sort_order=desc")
+      path_desc = assert_patch(view)
+      assert path_desc =~ "sort_field=email"
+      assert path_desc =~ "sort_order=desc"
     end
 
     test "clicking different column header resets order to ascending", %{conn: conn} do
       conn = conn_with_oidc_user(conn)
-      {:ok, view, _html} = live(conn, "/members?sort_field=email&sort_order=desc")
+
+      {:ok, view, _html} =
+        live(conn, "/members?fields=first_name,email&sort_field=email&sort_order=desc")
 
       # Click on a different column
       view
       |> element("[data-testid='first_name']")
       |> render_click()
 
-      assert_patch(view, "/members?query=&sort_field=first_name&sort_order=asc")
+      path = assert_patch(view)
+      assert path =~ "sort_field=first_name"
+      assert path =~ "sort_order=asc"
     end
 
     test "all sortable columns work correctly", %{conn: conn} do
       conn = conn_with_oidc_user(conn)
-      {:ok, view, _html} = live(conn, "/members")
+
+      {:ok, view, _html} =
+        live(
+          conn,
+          "/members?fields=first_name,email,street,house_number,postal_code,city,country,join_date"
+        )
 
       # default ascending sorting with first name
       assert has_element?(view, "[data-testid='first_name'][aria-label='ascending']")
@@ -209,30 +225,40 @@ defmodule MvWeb.MemberLive.IndexTest do
         |> element("[data-testid='#{field}']")
         |> render_click()
 
-        assert_patch(view, "/members?query=&sort_field=#{field}&sort_order=asc")
+        path = assert_patch(view)
+        assert path =~ "sort_field=#{field}"
+        assert path =~ "sort_order=asc"
       end
     end
 
     test "sorting works with search query", %{conn: conn} do
       conn = conn_with_oidc_user(conn)
-      {:ok, view, _html} = live(conn, "/members?query=test")
+      {:ok, view, _html} = live(conn, "/members?fields=email&query=test")
 
       view
       |> element("[data-testid='email']")
       |> render_click()
 
-      assert_patch(view, "/members?query=test&sort_field=email&sort_order=asc")
+      path = assert_patch(view)
+      assert path =~ "query=test"
+      assert path =~ "sort_field=email"
+      assert path =~ "sort_order=asc"
     end
 
     test "sorting maintains search query when toggling order", %{conn: conn} do
       conn = conn_with_oidc_user(conn)
-      {:ok, view, _html} = live(conn, "/members?query=test&sort_field=email&sort_order=asc")
+
+      {:ok, view, _html} =
+        live(conn, "/members?fields=email&query=test&sort_field=email&sort_order=asc")
 
       view
       |> element("[data-testid='email']")
       |> render_click()
 
-      assert_patch(view, "/members?query=test&sort_field=email&sort_order=desc")
+      path = assert_patch(view)
+      assert path =~ "query=test"
+      assert path =~ "sort_field=email"
+      assert path =~ "sort_order=desc"
     end
   end
 
@@ -240,7 +266,9 @@ defmodule MvWeb.MemberLive.IndexTest do
     @describetag :ui
     test "handle_params reads sort query and applies it", %{conn: conn} do
       conn = conn_with_oidc_user(conn)
-      {:ok, view, _html} = live(conn, "/members?query=&sort_field=email&sort_order=desc")
+
+      {:ok, view, _html} =
+        live(conn, "/members?fields=email&query=&sort_field=email&sort_order=desc")
 
       # Check that the sort state is correctly applied
       assert has_element?(view, "[data-testid='email'][aria-label='descending']")
@@ -248,7 +276,9 @@ defmodule MvWeb.MemberLive.IndexTest do
 
     test "handle_params handles invalid sort field gracefully", %{conn: conn} do
       conn = conn_with_oidc_user(conn)
-      {:ok, view, _html} = live(conn, "/members?query=&sort_field=invalid_field&sort_order=asc")
+
+      {:ok, view, _html} =
+        live(conn, "/members?fields=first_name&query=&sort_field=invalid_field&sort_order=asc")
 
       # Should not crash and should show default first name order
       assert has_element?(view, "[data-testid='first_name'][aria-label='ascending']")
@@ -256,7 +286,9 @@ defmodule MvWeb.MemberLive.IndexTest do
 
     test "handle_params preserves search query with sort params", %{conn: conn} do
       conn = conn_with_oidc_user(conn)
-      {:ok, view, _html} = live(conn, "/members?query=test&sort_field=email&sort_order=desc")
+
+      {:ok, view, _html} =
+        live(conn, "/members?fields=email&query=test&sort_field=email&sort_order=desc")
 
       # Both search and sort should be preserved
       assert has_element?(view, "[data-testid='email'][aria-label='descending']")
@@ -267,7 +299,9 @@ defmodule MvWeb.MemberLive.IndexTest do
     @describetag :ui
     test "search maintains sort state", %{conn: conn} do
       conn = conn_with_oidc_user(conn)
-      {:ok, view, _html} = live(conn, "/members?query=&sort_field=email&sort_order=desc")
+
+      {:ok, view, _html} =
+        live(conn, "/members?fields=email&query=&sort_field=email&sort_order=desc")
 
       # Perform search
       view
@@ -280,7 +314,9 @@ defmodule MvWeb.MemberLive.IndexTest do
 
     test "sort maintains search state", %{conn: conn} do
       conn = conn_with_oidc_user(conn)
-      {:ok, view, _html} = live(conn, "/members?query=test&sort_field=email&sort_order=asc")
+
+      {:ok, view, _html} =
+        live(conn, "/members?fields=email&query=test&sort_field=email&sort_order=asc")
 
       # Perform sort
       view
@@ -288,7 +324,10 @@ defmodule MvWeb.MemberLive.IndexTest do
       |> render_click()
 
       # Search state should be maintained
-      assert_patch(view, "/members?query=test&sort_field=email&sort_order=desc")
+      path = assert_patch(view)
+      assert path =~ "query=test"
+      assert path =~ "sort_field=email"
+      assert path =~ "sort_order=desc"
     end
   end
 
@@ -1578,7 +1617,7 @@ defmodule MvWeb.MemberLive.IndexTest do
       boolean_field = create_boolean_custom_field()
 
       {:ok, view, _html} =
-        live(conn, "/members?bf_#{boolean_field.id}=true")
+        live(conn, "/members?fields=email&bf_#{boolean_field.id}=true")
 
       # Test sort toggle preserves filter
       view