refactor: fix review comments

test/mv/config_smtp_test.exs

@@ -2,7 +2,7 @@ defmodule Mv.ConfigSmtpTest do
   @moduledoc """
   Unit tests for Mv.Config SMTP-related helpers.
 
-  ENV overrides Settings (same pattern as OIDC/Vereinfacht). Uses real ENV and
+  SMTP uses ENV-only mode when SMTP_HOST is set. Uses real ENV and
   Settings; no mocking so we test the actual precedence. async: false because
   we mutate ENV.
   """
@@ -52,10 +52,10 @@ defmodule Mv.ConfigSmtpTest do
     end
   end
 
-  describe "smtp_env_configured?/0" do
+  describe "smtp_env_mode?/0" do
     test "returns true when SMTP_HOST is set" do
       set_smtp_env("SMTP_HOST", "smtp.example.com")
-      assert Mv.Config.smtp_env_configured?() == true
+      assert Mv.Config.smtp_env_mode?() == true
     after
       clear_smtp_env()
     end
@@ -63,14 +63,14 @@ defmodule Mv.ConfigSmtpTest do
     test "returns false when SMTP_HOST is not set even if other SMTP ENV variables are set" do
       set_smtp_env("SMTP_USERNAME", "user@example.com")
       set_smtp_env("SMTP_PASSWORD", "secret")
-      refute Mv.Config.smtp_env_configured?()
+      refute Mv.Config.smtp_env_mode?()
     after
       clear_smtp_env()
     end
 
     test "returns false when no SMTP ENV variables are set" do
       clear_smtp_env()
-      refute Mv.Config.smtp_env_configured?()
+      refute Mv.Config.smtp_env_mode?()
     end
   end
 

test/mv_web/live/global_settings_live_test.exs

@@ -1,5 +1,5 @@
 defmodule MvWeb.GlobalSettingsLiveTest do
-  use MvWeb.ConnCase, async: true
+  use MvWeb.ConnCase, async: false
   import Phoenix.LiveViewTest
   alias Mv.Membership
 
@@ -203,6 +203,20 @@ defmodule MvWeb.GlobalSettingsLiveTest do
       refute has_element?(view, "#setting_smtp_host[disabled]")
       refute has_element?(view, "#setting_smtp_username[disabled]")
     end
+
+    @tag :ui
+    test "shows effective ENV SMTP host value in disabled field", %{conn: conn} do
+      clear_smtp_env()
+      System.put_env("SMTP_HOST", "smtp.env-active.example")
+      on_exit(fn -> clear_smtp_env() end)
+
+      {:ok, settings} = Membership.get_settings()
+      {:ok, _} = Membership.update_settings(settings, %{smtp_host: "smtp.db-legacy.example"})
+
+      {:ok, _view, html} = live(conn, ~p"/settings")
+      assert html =~ ~s(value="smtp.env-active.example")
+      refute html =~ ~s(value="smtp.db-legacy.example")
+    end
   end
 
   describe "Authentication section when OIDC-only is enabled" do