fix: resolve pr remarks
This commit is contained in:
parent
a92f503752
commit
b4657cae23
6 changed files with 139 additions and 83 deletions
|
|
@ -1526,6 +1526,44 @@ defmodule MvWeb.MemberLive.IndexTest do
|
|||
refute html =~ "FalseMember"
|
||||
end
|
||||
|
||||
test "boolean filter works even when custom field is not visible in overview", %{conn: conn} do
|
||||
conn = conn_with_oidc_user(conn)
|
||||
|
||||
# Create boolean field with show_in_overview: false
|
||||
boolean_field = create_boolean_custom_field(%{show_in_overview: false})
|
||||
|
||||
_member_with_true =
|
||||
create_member_with_boolean_value(%{first_name: "TrueMember"}, boolean_field, true)
|
||||
|
||||
_member_with_false =
|
||||
create_member_with_boolean_value(%{first_name: "FalseMember"}, boolean_field, false)
|
||||
|
||||
{:ok, _member_without_value} =
|
||||
Mv.Membership.Member
|
||||
|> Ash.Changeset.for_create(:create_member, %{
|
||||
first_name: "NoValue",
|
||||
last_name: "Member",
|
||||
email: "novalue.member.#{System.unique_integer([:positive])}@example.com"
|
||||
})
|
||||
|> Ash.create()
|
||||
|
||||
# Test that filter works even though field is not visible in overview
|
||||
{:ok, _view, html_true} =
|
||||
live(conn, "/members?bf_#{boolean_field.id}=true")
|
||||
|
||||
assert html_true =~ "TrueMember"
|
||||
refute html_true =~ "FalseMember"
|
||||
refute html_true =~ "NoValue"
|
||||
|
||||
# Test false filter
|
||||
{:ok, _view, html_false} =
|
||||
live(conn, "/members?bf_#{boolean_field.id}=false")
|
||||
|
||||
assert html_false =~ "FalseMember"
|
||||
refute html_false =~ "TrueMember"
|
||||
refute html_false =~ "NoValue"
|
||||
end
|
||||
|
||||
test "boolean custom field appears in filter dropdown after being added", %{conn: conn} do
|
||||
conn = conn_with_oidc_user(conn)
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue