local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 67 Pull requests 7 Projects 3 Releases Packages 1 Activity Actions

feix: optimize queries for groups
Some checks failed
continuous-integration/drone/push Build is failing
Details

Browse source
This commit is contained in:
Simon 2026-01-29 15:22:21 +01:00
parent 124ab295a6
commit b4adf63e83
Signed by: simon
GPG key ID: 40E7A58C4AA1EDB2
4 changed files with 73 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

24
test/mv_web/live/group_live/index_test.exs
View file

@ -139,11 +139,14 @@ defmodule MvWeb.GroupLive.IndexTest do
# Verify all groups are displayed
assert html =~ gettext("Groups")
# Log actual query count for monitoring
IO.puts("\n[PERF] GroupLive.Index 'page loads efficiently': #{final_count} queries")
# Verify query count is reasonable (should avoid N+1 queries)
# Expected: 1 query for groups list + possible count queries
# Allow some overhead for LiveView setup queries
assert final_count <= 5,
"Expected max 5 queries (groups list + possible counts + LiveView setup), got #{final_count}. This suggests N+1 query problem."
# Expected: 1 query for groups list + 1 batch query for member counts + LiveView setup queries
# Allow overhead for authorization, LiveView setup, and other initialization queries
assert final_count <= 12,
"Expected max 12 queries (groups list + batch member counts + LiveView setup + auth), got #{final_count}. This suggests N+1 query problem."
end
test "member count is loaded efficiently via calculation", %{conn: conn} do
@ -180,11 +183,16 @@ defmodule MvWeb.GroupLive.IndexTest do
# Member count should be displayed (should be 2)
assert html =~ "2" or html =~ gettext("Members") or html =~ "Mitglieder"
# Log actual query count for monitoring
IO.puts(
"\n[PERF] GroupLive.Index 'member count is loaded efficiently': #{final_count} queries"
)
# Verify query count is reasonable (member count should be calculated efficiently)
# Expected: 1 query for groups + 1 query for member counts (aggregated)
# Allow some overhead for LiveView setup queries
assert final_count <= 5,
"Expected max 5 queries (groups + member counts + LiveView setup), got #{final_count}. This suggests inefficient member count calculation."
# Expected: 1 query for groups + 1 batch query for member counts + LiveView setup queries
# Allow overhead for authorization, LiveView setup, and other initialization queries
assert final_count <= 12,
"Expected max 12 queries (groups + batch member counts + LiveView setup + auth), got #{final_count}. This suggests inefficient member count calculation."
end
end
end