local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 72 Pull requests 3 Projects 4 Releases Packages 1 Activity Actions

refactor: replace cond with if in handle_delete_role functions
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse source
This commit is contained in:
Moritz 2026-01-08 13:54:43 +01:00
parent 4f371352e2
commit c27b903018
Signed by: moritz
GPG key ID: 1020A035E5DD0824
6 changed files with 33 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

1
lib/mv_web/live/role_live/form.ex
View file

@ -89,7 +89,6 @@ defmodule MvWeb.RoleLive.Form do
@impl true
def mount(params, _session, socket) do
case params["id"] do
nil ->
action = gettext("New")

30
lib/mv_web/live/role_live/index.ex
View file

@ -63,20 +63,18 @@ defmodule MvWeb.RoleLive.Index do
end
defp handle_delete_role(role, id, socket) do
cond do
role.is_system_role ->
if role.is_system_role do
{:noreply,
put_flash(
socket,
:error,
gettext("System roles cannot be deleted.")
)}
else
user_count = recalculate_user_count(role)
if user_count > 0 do
{:noreply,
put_flash(
socket,
:error,
gettext("System roles cannot be deleted.")
)}
true ->
user_count = recalculate_user_count(role)
if user_count > 0 do
{:noreply,
put_flash(
socket,
:error,
@ -85,9 +83,9 @@ defmodule MvWeb.RoleLive.Index do
count: user_count
)
)}
else
perform_role_deletion(role, id, socket)
end
else
perform_role_deletion(role, id, socket)
end
end
end

30
lib/mv_web/live/role_live/show.ex
View file

@ -91,20 +91,18 @@ defmodule MvWeb.RoleLive.Show do
end
defp handle_delete_role(role, socket) do
cond do
role.is_system_role ->
if role.is_system_role do
{:noreply,
put_flash(
socket,
:error,
gettext("System roles cannot be deleted.")
)}
else
user_count = recalculate_user_count(role)
if user_count > 0 do
{:noreply,
put_flash(
socket,
:error,
gettext("System roles cannot be deleted.")
)}
true ->
user_count = recalculate_user_count(role)
if user_count > 0 do
{:noreply,
put_flash(
socket,
:error,
@ -113,9 +111,9 @@ defmodule MvWeb.RoleLive.Show do
count: user_count
)
)}
else
perform_role_deletion(role, socket)
end
else
perform_role_deletion(role, socket)
end
end
end