local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 72 Pull requests 3 Projects 4 Releases Packages 1 Activity Actions

refactor: replace cond with if in handle_delete_role functions
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse source
This commit is contained in:
Moritz 2026-01-08 13:54:43 +01:00
parent 4f371352e2
commit c27b903018
Signed by: moritz
GPG key ID: 1020A035E5DD0824
6 changed files with 33 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

1
lib/mv_web/live/role_live/form.ex
View file

@ -89,7 +89,6 @@ defmodule MvWeb.RoleLive.Form do
@impl true @impl true
def mount(params, _session, socket) do def mount(params, _session, socket) do
case params["id"] do case params["id"] do
nil -> nil ->
action = gettext("New") action = gettext("New")

6
lib/mv_web/live/role_live/index.ex
View file

@ -63,16 +63,14 @@ defmodule MvWeb.RoleLive.Index do
end end
defp handle_delete_role(role, id, socket) do defp handle_delete_role(role, id, socket) do
cond do if role.is_system_role do
role.is_system_role ->
{:noreply, {:noreply,
put_flash( put_flash(
socket, socket,
:error, :error,
gettext("System roles cannot be deleted.") gettext("System roles cannot be deleted.")
)} )}
else
true ->
user_count = recalculate_user_count(role) user_count = recalculate_user_count(role)
if user_count > 0 do if user_count > 0 do

6
lib/mv_web/live/role_live/show.ex
View file

@ -91,16 +91,14 @@ defmodule MvWeb.RoleLive.Show do
end end
defp handle_delete_role(role, socket) do defp handle_delete_role(role, socket) do
cond do if role.is_system_role do
role.is_system_role ->
{:noreply, {:noreply,
put_flash( put_flash(
socket, socket,
:error, :error,
gettext("System roles cannot be deleted.") gettext("System roles cannot be deleted.")
)} )}
else
true ->
user_count = recalculate_user_count(role) user_count = recalculate_user_count(role)
if user_count > 0 do if user_count > 0 do

2
priv/gettext/de/LC_MESSAGES/default.po
View file

@ -1449,6 +1449,7 @@ msgstr "Bereits bezahlte Zyklen bleiben mit dem alten Betrag."
#: lib/mv_web/live/member_live/show/membership_fees_component.ex #: lib/mv_web/live/member_live/show/membership_fees_component.ex
#: lib/mv_web/live/membership_fee_type_live/index.ex #: lib/mv_web/live/membership_fee_type_live/index.ex
#: lib/mv_web/live/role_live/form.ex
#: lib/mv_web/live/role_live/index.ex #: lib/mv_web/live/role_live/index.ex
#: lib/mv_web/live/role_live/show.ex #: lib/mv_web/live/role_live/show.ex
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format
@ -1992,6 +1993,7 @@ msgstr "Rollen"
msgid "Cannot delete role. %{count} user(s) are still assigned to this role. Please assign them to another role first." msgid "Cannot delete role. %{count} user(s) are still assigned to this role. Please assign them to another role first."
msgstr "Rolle kann nicht gelöscht werden. %{count} Benutzer*in(nen) sind dieser Rolle noch zugeordnet. Bitte weisen Sie sie zunächst einer anderen Rolle zu." msgstr "Rolle kann nicht gelöscht werden. %{count} Benutzer*in(nen) sind dieser Rolle noch zugeordnet. Bitte weisen Sie sie zunächst einer anderen Rolle zu."
#: lib/mv_web/live/role_live/form.ex
#: lib/mv_web/live/role_live/index.ex #: lib/mv_web/live/role_live/index.ex
#: lib/mv_web/live/role_live/show.ex #: lib/mv_web/live/role_live/show.ex
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format

1
priv/gettext/default.pot
View file

@ -1450,6 +1450,7 @@ msgstr ""
#: lib/mv_web/live/member_live/show/membership_fees_component.ex #: lib/mv_web/live/member_live/show/membership_fees_component.ex
#: lib/mv_web/live/membership_fee_type_live/index.ex #: lib/mv_web/live/membership_fee_type_live/index.ex
#: lib/mv_web/live/role_live/form.ex
#: lib/mv_web/live/role_live/index.ex #: lib/mv_web/live/role_live/index.ex
#: lib/mv_web/live/role_live/show.ex #: lib/mv_web/live/role_live/show.ex
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format

2
priv/gettext/en/LC_MESSAGES/default.po
View file

@ -1450,6 +1450,7 @@ msgstr ""
#: lib/mv_web/live/member_live/show/membership_fees_component.ex #: lib/mv_web/live/member_live/show/membership_fees_component.ex
#: lib/mv_web/live/membership_fee_type_live/index.ex #: lib/mv_web/live/membership_fee_type_live/index.ex
#: lib/mv_web/live/role_live/form.ex
#: lib/mv_web/live/role_live/index.ex #: lib/mv_web/live/role_live/index.ex
#: lib/mv_web/live/role_live/show.ex #: lib/mv_web/live/role_live/show.ex
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format
@ -1993,6 +1994,7 @@ msgstr ""
msgid "Cannot delete role. %{count} user(s) are still assigned to this role. Please assign them to another role first." msgid "Cannot delete role. %{count} user(s) are still assigned to this role. Please assign them to another role first."
msgstr "" msgstr ""
#: lib/mv_web/live/role_live/form.ex
#: lib/mv_web/live/role_live/index.ex #: lib/mv_web/live/role_live/index.ex
#: lib/mv_web/live/role_live/show.ex #: lib/mv_web/live/role_live/show.ex
#, elixir-autogen, elixir-format #, elixir-autogen, elixir-format