feat: unify page titles

lib/mv_web/live/role_live/form.ex

@@ -29,7 +29,7 @@ defmodule MvWeb.RoleLive.Form do
               {gettext("Back")}
             </.button>
           </:leading>
-          {@page_title}
+          {@content_title}
           <:actions>
             <.button phx-disable-with={gettext("Saving...")} variant="primary" type="submit">
               {gettext("Save")}
@@ -94,14 +94,13 @@ defmodule MvWeb.RoleLive.Form do
   def mount(params, _session, socket) do
     case params["id"] do
       nil ->
-        action = gettext("New")
-        page_title = action <> " " <> gettext("Role")
+        content_title = gettext("New") <> " " <> gettext("Role")
 
         {:ok,
          socket
          |> assign(:return_to, return_to(params["return_to"]))
          |> assign(:role, nil)
-         |> assign(:page_title, page_title)
+         |> Layouts.assign_page_title(content_title)
          |> assign_form()}
 
       id ->
@@ -113,14 +112,13 @@ defmodule MvWeb.RoleLive.Form do
                  actor: socket.assigns[:current_user]
                ) do
             {:ok, role} ->
-              action = gettext("Edit")
-              page_title = action <> " " <> gettext("Role")
+              content_title = gettext("Edit") <> " " <> gettext("Role")
 
               {:ok,
                socket
                |> assign(:return_to, return_to(params["return_to"]))
                |> assign(:role, role)
-               |> assign(:page_title, page_title)
+               |> Layouts.assign_page_title(content_title)
                |> assign_form()}
 
             {:error, %Ash.Error.Invalid{errors: [%Ash.Error.Query.NotFound{} | _]}} ->

lib/mv_web/live/role_live/index.ex

@@ -28,7 +28,7 @@ defmodule MvWeb.RoleLive.Index do
 
     {:ok,
      socket
-     |> assign(:page_title, gettext("Listing Roles"))
+     |> Layouts.assign_page_title(gettext("Roles"))
      |> assign(:roles, roles)
      |> assign(:user_counts, user_counts)}
   end

lib/mv_web/live/role_live/index.html.heex

@@ -1,6 +1,6 @@
 <Layouts.app flash={@flash} current_user={@current_user}>
   <.header>
-    {gettext("Listing Roles")}
+    {@content_title}
     <:subtitle>
       {gettext("Manage roles and their permission sets.")}
     </:subtitle>

lib/mv_web/live/role_live/show.ex

@@ -30,9 +30,11 @@ defmodule MvWeb.RoleLive.Show do
       {:ok, role} ->
         user_count = load_user_count(role, socket.assigns[:current_user])
 
+        content_title = gettext("Role %{name}", name: role.name)
+
         {:ok,
          socket
-         |> assign(:page_title, gettext("Show Role"))
+         |> Layouts.assign_page_title(content_title)
          |> assign(:role, role)
          |> assign(:user_count, user_count)
          |> assign(:show_delete_modal, false)}
@@ -202,7 +204,7 @@ defmodule MvWeb.RoleLive.Show do
             {gettext("Back")}
           </.button>
         </:leading>
-        {gettext("Role")} {@role.name}
+        {@content_title}
         <:subtitle>{gettext("Role details and permissions.")}</:subtitle>
 
         <:actions>