local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 54 Pull requests 1 Projects 1 Releases 3 Packages 1 Activity Actions

fix: failing tests
Some checks failed
continuous-integration/drone/push Build is failing
Details

Browse source
This commit is contained in:
Simon 2026-04-07 14:54:29 +02:00
parent 61952f986d
commit d7dd7d1959
Signed by: simon
GPG key ID: 40E7A58C4AA1EDB2
3 changed files with 66 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/smtp-configuration-concept.md
View file

@ -109,6 +109,8 @@ By default, TLS certificate verification is relaxed (`verify_none`) so self-sign
Verify mode is set in `tls_options` for port 587 (STARTTLS). For port 465 (implicit SSL), the initial connection is `ssl:connect`, so we also pass `sockopts: [verify: verify_mode]` so the SSL handshake uses the same mode. For 587 we must not pass `verify` in sockopts—gen_tcp is used first and rejects it (ArgumentError). The logic lives in `Mv.Smtp.ConfigBuilder.build_opts/1` (single source of truth), used by `config/runtime.exs` (boot) and `Mv.Mailer.smtp_config/0` (Settings-only).
**Tests:** `Mv.Smtp.ConfigBuilderTest` asserts sockopts/TLS shape. `Mv.Mailer.smtp_config/0` returns `[]` when the mailer adapter is `Swoosh.Adapters.Test`; `test/mv/mailer_smtp_config_test.exs` asserts that guard and, with the adapter temporarily set to `Swoosh.Adapters.Local`, wiring from ENV. Those mailer tests use `Mv.DataCase` so Settings fallbacks in `Mv.Config` (e.g. SMTP username/password when ENV is unset) stay under the SQL sandbox.
---
## 12. Summary Checklist