local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 67 Pull requests 6 Projects 3 Releases Packages 1 Activity Actions

Fix tests: Add missing actor parameters to Ash operations

Browse source
This commit is contained in:
Moritz 2026-01-24 01:42:20 +01:00
parent b9d68a3417
commit d8187484b8
Signed by: moritz
GPG key ID: 1020A035E5DD0824
5 changed files with 9 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/mv/authorization/actor_test.exs
View file

@ -28,7 +28,7 @@ defmodule Mv.Authorization.ActorTest do
|> Ash.create(actor: actor) |> Ash.create(actor: actor)
# Load role # Load role
{:ok, user_with_role} = Ash.load(user, :role, domain: Mv.Accounts) {:ok, user_with_role} = Ash.load(user, :role, domain: Mv.Accounts, actor: actor)
# Should return as-is (no additional load) # Should return as-is (no additional load)
result = Actor.ensure_loaded(user_with_role) result = Actor.ensure_loaded(user_with_role)

4
test/mv_web/live/membership_fee_type_live/index_test.exs
View file

@ -16,6 +16,8 @@ defmodule MvWeb.MembershipFeeTypeLive.IndexTest do
# Helper to create a membership fee type # Helper to create a membership fee type
defp create_fee_type(attrs) do defp create_fee_type(attrs) do
system_actor = Mv.Helpers.SystemActor.get_system_actor()
default_attrs = %{ default_attrs = %{
name: "Test Fee Type #{System.unique_integer([:positive])}", name: "Test Fee Type #{System.unique_integer([:positive])}",
amount: Decimal.new("50.00"), amount: Decimal.new("50.00"),
@ -26,7 +28,7 @@ defmodule MvWeb.MembershipFeeTypeLive.IndexTest do
MembershipFeeType MembershipFeeType
|> Ash.Changeset.for_create(:create, attrs) |> Ash.Changeset.for_create(:create, attrs)
|> Ash.create!() |> Ash.create!(actor: system_actor)
end end
# Helper to create a member # Helper to create a member

2
test/mv_web/live/role_live/show_test.exs
View file

@ -79,7 +79,7 @@ defmodule MvWeb.RoleLive.ShowTest do
|> Ash.update(actor: actor) |> Ash.update(actor: actor)
# Load role for authorization checks (must be loaded for can?/3 to work) # Load role for authorization checks (must be loaded for can?/3 to work)
user_with_role = Ash.load!(user, :role, domain: Mv.Accounts) user_with_role = Ash.load!(user, :role, domain: Mv.Accounts, actor: actor)
# Store user with role in session for LiveView # Store user with role in session for LiveView
conn = conn_with_password_user(conn, user_with_role) conn = conn_with_password_user(conn, user_with_role)

2
test/mv_web/live/role_live_test.exs
View file

@ -70,7 +70,7 @@ defmodule MvWeb.RoleLiveTest do
|> Ash.update(actor: actor) |> Ash.update(actor: actor)
# Load role for authorization checks (must be loaded for can?/3 to work) # Load role for authorization checks (must be loaded for can?/3 to work)
user_with_role = Ash.load!(user, :role, domain: Mv.Accounts) user_with_role = Ash.load!(user, :role, domain: Mv.Accounts, actor: actor)
# Store user with role in session for LiveView # Store user with role in session for LiveView
conn = conn_with_password_user(conn, user_with_role) conn = conn_with_password_user(conn, user_with_role)

4
test/mv_web/member_live/form_membership_fee_type_test.exs
View file

@ -212,6 +212,8 @@ defmodule MvWeb.MemberLive.FormMembershipFeeTypeTest do
end end
test "union/typed values roundtrip correctly", %{conn: conn, current_user: admin_user} do test "union/typed values roundtrip correctly", %{conn: conn, current_user: admin_user} do
system_actor = Mv.Helpers.SystemActor.get_system_actor()
# Create date custom field # Create date custom field
custom_field = custom_field =
Mv.Membership.CustomField Mv.Membership.CustomField
@ -220,7 +222,7 @@ defmodule MvWeb.MemberLive.FormMembershipFeeTypeTest do
value_type: :date, value_type: :date,
required: false required: false
}) })
|> Ash.create!() |> Ash.create!(actor: system_actor)
fee_type = create_fee_type(%{interval: :yearly}) fee_type = create_fee_type(%{interval: :yearly})