local-it/mitgliederverwaltung
2
3
Fork 0
Code Issues 66 Pull requests 6 Projects 3 Releases Packages 1 Activity Actions

fix: linting + tests

Browse source
This commit is contained in:
Simon 2026-01-19 14:09:19 +01:00
parent bc4bcd0089
commit d9b659e5ea
Signed by: simon
GPG key ID: 40E7A58C4AA1EDB2
4 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/mv_web/components/layouts/sidebar.ex
View file

@ -81,7 +81,7 @@ defmodule MvWeb.Layouts.Sidebar do
icon="hero-currency-euro" icon="hero-currency-euro"
label={gettext("Fee Types")} label={gettext("Fee Types")}
/> />
<!-- Nested Admin Menu --> <!-- Nested Admin Menu -->
<.menu_group icon="hero-cog-6-tooth" label={gettext("Administration")}> <.menu_group icon="hero-cog-6-tooth" label={gettext("Administration")}>
<.menu_subitem href={~p"/users"} label={gettext("Users")} /> <.menu_subitem href={~p"/users"} label={gettext("Users")} />

8
lib/mv_web/live/member_live/form.ex
View file

@ -375,7 +375,9 @@ defmodule MvWeb.MemberLive.Form do
[error | _] -> [error | _] ->
# Try to extract message from other error types # Try to extract message from other error types
case error do case error do
%{message: message} when is_binary(message) -> message %{message: message} when is_binary(message) ->
message
error when is_struct(error) -> error when is_struct(error) ->
# Try to use Ash.ErrorKind protocol if available # Try to use Ash.ErrorKind protocol if available
try do try do
@ -383,7 +385,9 @@ defmodule MvWeb.MemberLive.Form do
rescue rescue
Protocol.UndefinedError -> gettext("Failed to save member. Please try again.") Protocol.UndefinedError -> gettext("Failed to save member. Please try again.")
end end
_ -> gettext("Failed to save member. Please try again.")
_ ->
gettext("Failed to save member. Please try again.")
end end
_ -> _ ->

4
priv/repo/seeds.exs
View file

@ -166,7 +166,7 @@ case Accounts.User
# User already exists (e.g., via OIDC) - assign admin role # User already exists (e.g., via OIDC) - assign admin role
existing_admin_user existing_admin_user
|> Ash.Changeset.for_update(:update, %{}) |> Ash.Changeset.for_update(:update, %{})
|> Ash.Changeset.manage_relationship(:role, admin_role, type: :replace) |> Ash.Changeset.manage_relationship(:role, admin_role, type: :append_and_remove)
|> Ash.update!() |> Ash.update!()
{:ok, nil} -> {:ok, nil} ->
@ -177,7 +177,7 @@ case Accounts.User
|> then(fn user -> |> then(fn user ->
user user
|> Ash.Changeset.for_update(:update, %{}) |> Ash.Changeset.for_update(:update, %{})
|> Ash.Changeset.manage_relationship(:role, admin_role, type: :replace) |> Ash.Changeset.manage_relationship(:role, admin_role, type: :append_and_remove)
|> Ash.update!() |> Ash.update!()
end) end)

3
test/mv_web/member_live/form_error_handling_test.exs
View file

@ -39,6 +39,7 @@ defmodule MvWeb.MemberLive.FormErrorHandlingTest do
# Should show flash error message # Should show flash error message
assert has_element?(view, "#flash-group") assert has_element?(view, "#flash-group")
assert html =~ "error" or html =~ "Error" or html =~ "Fehler" or assert html =~ "error" or html =~ "Error" or html =~ "Fehler" or
html =~ "failed" or html =~ "fehlgeschlagen" or html =~ "failed" or html =~ "fehlgeschlagen" or
html =~ "Validation failed" or html =~ "Validierung fehlgeschlagen" html =~ "Validation failed" or html =~ "Validierung fehlgeschlagen"
@ -64,6 +65,7 @@ defmodule MvWeb.MemberLive.FormErrorHandlingTest do
# Should show flash error message # Should show flash error message
assert has_element?(view, "#flash-group") assert has_element?(view, "#flash-group")
assert html =~ "error" or html =~ "Error" or html =~ "Fehler" or assert html =~ "error" or html =~ "Error" or html =~ "Fehler" or
html =~ "failed" or html =~ "fehlgeschlagen" or html =~ "failed" or html =~ "fehlgeschlagen" or
html =~ "Validation failed" or html =~ "Validierung fehlgeschlagen" or html =~ "Validation failed" or html =~ "Validierung fehlgeschlagen" or
@ -108,6 +110,7 @@ defmodule MvWeb.MemberLive.FormErrorHandlingTest do
# Should show flash error message # Should show flash error message
assert has_element?(view, "#flash-group") assert has_element?(view, "#flash-group")
assert html =~ "error" or html =~ "Error" or html =~ "Fehler" or assert html =~ "error" or html =~ "Error" or html =~ "Fehler" or
html =~ "failed" or html =~ "fehlgeschlagen" or html =~ "failed" or html =~ "fehlgeschlagen" or
html =~ "Validation failed" or html =~ "Validierung fehlgeschlagen" html =~ "Validation failed" or html =~ "Validierung fehlgeschlagen"