refactor: improve groups LiveView based on code review feedback
All checks were successful
continuous-integration/drone/push Build is passing
All checks were successful
continuous-integration/drone/push Build is passing
This commit is contained in:
parent
3eb4cde0b7
commit
ddc8335cc0
8 changed files with 109 additions and 104 deletions
|
|
@ -1010,6 +1010,10 @@ let liveSocket = new LiveSocket("/live", Socket, {
|
|||
|
||||
### 3.8 Code Quality: Credo
|
||||
|
||||
**Static Code Analysis:**
|
||||
|
||||
We use **Credo** for static code analysis to ensure code quality, consistency, and maintainability. Credo checks are **mandatory** and must pass before code can be merged.
|
||||
|
||||
**Run Credo Regularly:**
|
||||
|
||||
```bash
|
||||
|
|
@ -1020,6 +1024,13 @@ mix credo
|
|||
mix credo --strict
|
||||
```
|
||||
|
||||
**CI Enforcement:**
|
||||
|
||||
- ✅ **All Credo checks must pass in CI pipeline**
|
||||
- ✅ Pull requests will be blocked if Credo checks fail
|
||||
- ✅ Run `mix credo --strict` locally before pushing to catch issues early
|
||||
- ✅ Address all Credo warnings and errors before requesting code review
|
||||
|
||||
**Key Credo Checks Enabled:**
|
||||
|
||||
- Consistency checks (spacing, line endings, parameter patterns)
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue