fix linting

test/mv_web/controllers/member_export_controller_test.exs

@@ -211,294 +211,294 @@ defmodule MvWeb.MemberExportControllerTest do
       assert header =~ "Membership Fee Status"
     end
 
-      setup %{conn: conn} do
-        system_actor = Mv.Helpers.SystemActor.get_system_actor()
+    setup %{conn: conn} do
+      system_actor = Mv.Helpers.SystemActor.get_system_actor()
 
-        # Create custom fields for different types
-        {:ok, string_field} =
-          Mv.Membership.CustomField
-          |> Ash.Changeset.for_create(:create, %{
-            name: "Phone Number",
-            value_type: :string
-          })
-          |> Ash.create(actor: system_actor)
+      # Create custom fields for different types
+      {:ok, string_field} =
+        Mv.Membership.CustomField
+        |> Ash.Changeset.for_create(:create, %{
+          name: "Phone Number",
+          value_type: :string
+        })
+        |> Ash.create(actor: system_actor)
 
-        {:ok, integer_field} =
-          Mv.Membership.CustomField
-          |> Ash.Changeset.for_create(:create, %{
-            name: "Membership Number",
-            value_type: :integer
-          })
-          |> Ash.create(actor: system_actor)
+      {:ok, integer_field} =
+        Mv.Membership.CustomField
+        |> Ash.Changeset.for_create(:create, %{
+          name: "Membership Number",
+          value_type: :integer
+        })
+        |> Ash.create(actor: system_actor)
 
-        {:ok, boolean_field} =
-          Mv.Membership.CustomField
-          |> Ash.Changeset.for_create(:create, %{
-            name: "Active Member",
-            value_type: :boolean
-          })
-          |> Ash.create(actor: system_actor)
+      {:ok, boolean_field} =
+        Mv.Membership.CustomField
+        |> Ash.Changeset.for_create(:create, %{
+          name: "Active Member",
+          value_type: :boolean
+        })
+        |> Ash.create(actor: system_actor)
 
-        # Create members with custom field values
-        {:ok, member_with_string} =
-          Mv.Membership.create_member(
-            %{
-              first_name: "Test",
-              last_name: "String",
-              email: "test.string@example.com"
-            },
-            actor: system_actor
-          )
+      # Create members with custom field values
+      {:ok, member_with_string} =
+        Mv.Membership.create_member(
+          %{
+            first_name: "Test",
+            last_name: "String",
+            email: "test.string@example.com"
+          },
+          actor: system_actor
+        )
 
-        {:ok, _cfv_string} =
-          Mv.Membership.CustomFieldValue
-          |> Ash.Changeset.for_create(:create, %{
-            member_id: member_with_string.id,
-            custom_field_id: string_field.id,
-            value: "+49 123 456789"
-          })
-          |> Ash.create(actor: system_actor)
+      {:ok, _cfv_string} =
+        Mv.Membership.CustomFieldValue
+        |> Ash.Changeset.for_create(:create, %{
+          member_id: member_with_string.id,
+          custom_field_id: string_field.id,
+          value: "+49 123 456789"
+        })
+        |> Ash.create(actor: system_actor)
 
-        {:ok, member_with_integer} =
-          Mv.Membership.create_member(
-            %{
-              first_name: "Test",
-              last_name: "Integer",
-              email: "test.integer@example.com"
-            },
-            actor: system_actor
-          )
+      {:ok, member_with_integer} =
+        Mv.Membership.create_member(
+          %{
+            first_name: "Test",
+            last_name: "Integer",
+            email: "test.integer@example.com"
+          },
+          actor: system_actor
+        )
 
-        {:ok, _cfv_integer} =
-          Mv.Membership.CustomFieldValue
-          |> Ash.Changeset.for_create(:create, %{
-            member_id: member_with_integer.id,
-            custom_field_id: integer_field.id,
-            value: 12345
-          })
-          |> Ash.create(actor: system_actor)
+      {:ok, _cfv_integer} =
+        Mv.Membership.CustomFieldValue
+        |> Ash.Changeset.for_create(:create, %{
+          member_id: member_with_integer.id,
+          custom_field_id: integer_field.id,
+          value: 12_345
+        })
+        |> Ash.create(actor: system_actor)
 
-        {:ok, member_with_boolean} =
-          Mv.Membership.create_member(
-            %{
-              first_name: "Test",
-              last_name: "Boolean",
-              email: "test.boolean@example.com"
-            },
-            actor: system_actor
-          )
+      {:ok, member_with_boolean} =
+        Mv.Membership.create_member(
+          %{
+            first_name: "Test",
+            last_name: "Boolean",
+            email: "test.boolean@example.com"
+          },
+          actor: system_actor
+        )
 
-        {:ok, _cfv_boolean} =
-          Mv.Membership.CustomFieldValue
-          |> Ash.Changeset.for_create(:create, %{
-            member_id: member_with_boolean.id,
-            custom_field_id: boolean_field.id,
-            value: true
-          })
-          |> Ash.create(actor: system_actor)
+      {:ok, _cfv_boolean} =
+        Mv.Membership.CustomFieldValue
+        |> Ash.Changeset.for_create(:create, %{
+          member_id: member_with_boolean.id,
+          custom_field_id: boolean_field.id,
+          value: true
+        })
+        |> Ash.create(actor: system_actor)
 
-        {:ok, member_without_value} =
-          Mv.Membership.create_member(
-            %{
-              first_name: "Test",
-              last_name: "NoValue",
-              email: "test.novalue@example.com"
-            },
-            actor: system_actor
-          )
+      {:ok, member_without_value} =
+        Mv.Membership.create_member(
+          %{
+            first_name: "Test",
+            last_name: "NoValue",
+            email: "test.novalue@example.com"
+          },
+          actor: system_actor
+        )
 
-        %{
-          conn: conn,
-          string_field: string_field,
-          integer_field: integer_field,
-          boolean_field: boolean_field,
-          member_with_string: member_with_string,
-          member_with_integer: member_with_integer,
-          member_with_boolean: member_with_boolean,
-          member_without_value: member_without_value
-        }
-      end
-
-      test "export includes custom field column with string value", %{
-        conn: conn,
-        string_field: string_field,
-        member_with_string: member
-      } do
-        payload = %{
-          "selected_ids" => [member.id],
-          "member_fields" => ["first_name", "last_name"],
-          "custom_field_ids" => [string_field.id],
-          "query" => nil,
-          "sort_field" => nil,
-          "sort_order" => nil
-        }
-
-        conn = get(conn, "/members")
-        csrf_token = csrf_token_from_conn(conn)
-
-        conn =
-          post(conn, "/members/export.csv", %{
-            "payload" => Jason.encode!(payload),
-            "_csrf_token" => csrf_token
-          })
-
-        assert conn.status == 200
-        body = response(conn, 200)
-        lines = export_lines(body)
-        header = hd(lines)
-
-        assert header =~ "First Name"
-        assert header =~ "Last Name"
-        assert header =~ "Phone Number"
-        assert body =~ "Test"
-        assert body =~ "String"
-        assert body =~ "+49 123 456789"
-      end
-
-      test "export includes custom field column with integer value", %{
-        conn: conn,
-        integer_field: integer_field,
-        member_with_integer: member
-      } do
-        payload = %{
-          "selected_ids" => [member.id],
-          "member_fields" => ["first_name"],
-          "custom_field_ids" => [integer_field.id],
-          "query" => nil,
-          "sort_field" => nil,
-          "sort_order" => nil
-        }
-
-        conn = get(conn, "/members")
-        csrf_token = csrf_token_from_conn(conn)
-
-        conn =
-          post(conn, "/members/export.csv", %{
-            "payload" => Jason.encode!(payload),
-            "_csrf_token" => csrf_token
-          })
-
-        assert conn.status == 200
-        body = response(conn, 200)
-        header = body |> export_lines() |> hd()
-
-        assert header =~ "First Name"
-        assert header =~ "Membership Number"
-        assert body =~ "Test"
-        assert body =~ "12345"
-      end
-
-      test "export includes custom field column with boolean value", %{
-        conn: conn,
-        boolean_field: boolean_field,
-        member_with_boolean: member
-      } do
-        payload = %{
-          "selected_ids" => [member.id],
-          "member_fields" => ["first_name"],
-          "custom_field_ids" => [boolean_field.id],
-          "query" => nil,
-          "sort_field" => nil,
-          "sort_order" => nil
-        }
-
-        conn = get(conn, "/members")
-        csrf_token = csrf_token_from_conn(conn)
-
-        conn =
-          post(conn, "/members/export.csv", %{
-            "payload" => Jason.encode!(payload),
-            "_csrf_token" => csrf_token
-          })
-
-        assert conn.status == 200
-        body = response(conn, 200)
-        header = body |> export_lines() |> hd()
-
-        assert header =~ "First Name"
-        assert header =~ "Active Member"
-        assert body =~ "Test"
-        # Boolean values are formatted as "Yes" or "No" by CustomFieldValueFormatter
-        assert body =~ "Yes"
-      end
-
-      test "export shows empty cell for member without custom field value", %{
-        conn: conn,
-        string_field: string_field,
-        member_without_value: member
-      } do
-        payload = %{
-          "selected_ids" => [member.id],
-          "member_fields" => ["first_name", "last_name"],
-          "custom_field_ids" => [string_field.id],
-          "query" => nil,
-          "sort_field" => nil,
-          "sort_order" => nil
-        }
-
-        conn = get(conn, "/members")
-        csrf_token = csrf_token_from_conn(conn)
-
-        conn =
-          post(conn, "/members/export.csv", %{
-            "payload" => Jason.encode!(payload),
-            "_csrf_token" => csrf_token
-          })
-
-        assert conn.status == 200
-        body = response(conn, 200)
-        lines = export_lines(body)
-        header = hd(lines)
-        data_line = Enum.at(lines, 1)
-
-        assert header =~ "Phone Number"
-        # Empty custom field value should result in empty cell (two consecutive commas)
-        assert data_line =~ "Test,NoValue,"
-      end
-
-      test "export includes multiple custom fields in correct order", %{
+      %{
         conn: conn,
         string_field: string_field,
         integer_field: integer_field,
         boolean_field: boolean_field,
-        member_with_string: member
-      } do
-        payload = %{
-          "selected_ids" => [member.id],
-          "member_fields" => ["first_name"],
-          "custom_field_ids" => [string_field.id, integer_field.id, boolean_field.id],
-          "query" => nil,
-          "sort_field" => nil,
-          "sort_order" => nil
-        }
+        member_with_string: member_with_string,
+        member_with_integer: member_with_integer,
+        member_with_boolean: member_with_boolean,
+        member_without_value: member_without_value
+      }
+    end
 
-        conn = get(conn, "/members")
-        csrf_token = csrf_token_from_conn(conn)
+    test "export includes custom field column with string value", %{
+      conn: conn,
+      string_field: string_field,
+      member_with_string: member
+    } do
+      payload = %{
+        "selected_ids" => [member.id],
+        "member_fields" => ["first_name", "last_name"],
+        "custom_field_ids" => [string_field.id],
+        "query" => nil,
+        "sort_field" => nil,
+        "sort_order" => nil
+      }
 
-        conn =
-          post(conn, "/members/export.csv", %{
-            "payload" => Jason.encode!(payload),
-            "_csrf_token" => csrf_token
-          })
+      conn = get(conn, "/members")
+      csrf_token = csrf_token_from_conn(conn)
 
-        assert conn.status == 200
-        body = response(conn, 200)
-        header = body |> export_lines() |> hd()
+      conn =
+        post(conn, "/members/export.csv", %{
+          "payload" => Jason.encode!(payload),
+          "_csrf_token" => csrf_token
+        })
 
-        assert header =~ "First Name"
-        assert header =~ "Phone Number"
-        assert header =~ "Membership Number"
-        assert header =~ "Active Member"
-        # Verify order: member fields first, then custom fields in the order specified
-        header_parts = String.split(header, ",")
-        first_name_idx = Enum.find_index(header_parts, &String.contains?(&1, "First Name"))
-        phone_idx = Enum.find_index(header_parts, &String.contains?(&1, "Phone Number"))
-        membership_idx = Enum.find_index(header_parts, &String.contains?(&1, "Membership Number"))
-        active_idx = Enum.find_index(header_parts, &String.contains?(&1, "Active Member"))
+      assert conn.status == 200
+      body = response(conn, 200)
+      lines = export_lines(body)
+      header = hd(lines)
 
-        assert first_name_idx < phone_idx
-        assert phone_idx < membership_idx
-        assert membership_idx < active_idx
-      end
+      assert header =~ "First Name"
+      assert header =~ "Last Name"
+      assert header =~ "Phone Number"
+      assert body =~ "Test"
+      assert body =~ "String"
+      assert body =~ "+49 123 456789"
+    end
+
+    test "export includes custom field column with integer value", %{
+      conn: conn,
+      integer_field: integer_field,
+      member_with_integer: member
+    } do
+      payload = %{
+        "selected_ids" => [member.id],
+        "member_fields" => ["first_name"],
+        "custom_field_ids" => [integer_field.id],
+        "query" => nil,
+        "sort_field" => nil,
+        "sort_order" => nil
+      }
+
+      conn = get(conn, "/members")
+      csrf_token = csrf_token_from_conn(conn)
+
+      conn =
+        post(conn, "/members/export.csv", %{
+          "payload" => Jason.encode!(payload),
+          "_csrf_token" => csrf_token
+        })
+
+      assert conn.status == 200
+      body = response(conn, 200)
+      header = body |> export_lines() |> hd()
+
+      assert header =~ "First Name"
+      assert header =~ "Membership Number"
+      assert body =~ "Test"
+      assert body =~ "12345"
+    end
+
+    test "export includes custom field column with boolean value", %{
+      conn: conn,
+      boolean_field: boolean_field,
+      member_with_boolean: member
+    } do
+      payload = %{
+        "selected_ids" => [member.id],
+        "member_fields" => ["first_name"],
+        "custom_field_ids" => [boolean_field.id],
+        "query" => nil,
+        "sort_field" => nil,
+        "sort_order" => nil
+      }
+
+      conn = get(conn, "/members")
+      csrf_token = csrf_token_from_conn(conn)
+
+      conn =
+        post(conn, "/members/export.csv", %{
+          "payload" => Jason.encode!(payload),
+          "_csrf_token" => csrf_token
+        })
+
+      assert conn.status == 200
+      body = response(conn, 200)
+      header = body |> export_lines() |> hd()
+
+      assert header =~ "First Name"
+      assert header =~ "Active Member"
+      assert body =~ "Test"
+      # Boolean values are formatted as "Yes" or "No" by CustomFieldValueFormatter
+      assert body =~ "Yes"
+    end
+
+    test "export shows empty cell for member without custom field value", %{
+      conn: conn,
+      string_field: string_field,
+      member_without_value: member
+    } do
+      payload = %{
+        "selected_ids" => [member.id],
+        "member_fields" => ["first_name", "last_name"],
+        "custom_field_ids" => [string_field.id],
+        "query" => nil,
+        "sort_field" => nil,
+        "sort_order" => nil
+      }
+
+      conn = get(conn, "/members")
+      csrf_token = csrf_token_from_conn(conn)
+
+      conn =
+        post(conn, "/members/export.csv", %{
+          "payload" => Jason.encode!(payload),
+          "_csrf_token" => csrf_token
+        })
+
+      assert conn.status == 200
+      body = response(conn, 200)
+      lines = export_lines(body)
+      header = hd(lines)
+      data_line = Enum.at(lines, 1)
+
+      assert header =~ "Phone Number"
+      # Empty custom field value should result in empty cell (two consecutive commas)
+      assert data_line =~ "Test,NoValue,"
+    end
+
+    test "export includes multiple custom fields in correct order", %{
+      conn: conn,
+      string_field: string_field,
+      integer_field: integer_field,
+      boolean_field: boolean_field,
+      member_with_string: member
+    } do
+      payload = %{
+        "selected_ids" => [member.id],
+        "member_fields" => ["first_name"],
+        "custom_field_ids" => [string_field.id, integer_field.id, boolean_field.id],
+        "query" => nil,
+        "sort_field" => nil,
+        "sort_order" => nil
+      }
+
+      conn = get(conn, "/members")
+      csrf_token = csrf_token_from_conn(conn)
+
+      conn =
+        post(conn, "/members/export.csv", %{
+          "payload" => Jason.encode!(payload),
+          "_csrf_token" => csrf_token
+        })
+
+      assert conn.status == 200
+      body = response(conn, 200)
+      header = body |> export_lines() |> hd()
+
+      assert header =~ "First Name"
+      assert header =~ "Phone Number"
+      assert header =~ "Membership Number"
+      assert header =~ "Active Member"
+      # Verify order: member fields first, then custom fields in the order specified
+      header_parts = String.split(header, ",")
+      first_name_idx = Enum.find_index(header_parts, &String.contains?(&1, "First Name"))
+      phone_idx = Enum.find_index(header_parts, &String.contains?(&1, "Phone Number"))
+      membership_idx = Enum.find_index(header_parts, &String.contains?(&1, "Membership Number"))
+      active_idx = Enum.find_index(header_parts, &String.contains?(&1, "Active Member"))
+
+      assert first_name_idx < phone_idx
+      assert phone_idx < membership_idx
+      assert membership_idx < active_idx
+    end
   end
 end