Merge branch 'main' into feature/209_hide_field_dropdown

lib/mv_web/live/member_live/index.ex

@@ -18,6 +18,7 @@ defmodule MvWeb.MemberLive.Index do
   - `delete` - Remove a member from the database
   - `select_member` - Toggle individual member selection
   - `select_all` - Toggle selection of all visible members
+  - `copy_emails` - Copy email addresses of selected members to clipboard
 
   ## Implementation Notes
   - Search uses PostgreSQL full-text search (plainto_tsquery)
@@ -47,7 +48,7 @@ defmodule MvWeb.MemberLive.Index do
   Initializes the LiveView state.
 
   Sets up initial assigns for page title, search query, sort configuration,
-  and member selection. Actual data loading happens in `handle_params/3`.
+  payment filter, and member selection. Actual data loading happens in `handle_params/3`.
   """
   @impl true
   def mount(_params, session, socket) do
@@ -95,7 +96,8 @@ defmodule MvWeb.MemberLive.Index do
       |> assign(:query, "")
       |> assign_new(:sort_field, fn -> :first_name end)
       |> assign_new(:sort_order, fn -> :asc end)
-      |> assign(:selected_members, [])
+      |> assign(:paid_filter, nil)
+      |> assign(:selected_members, MapSet.new())
       |> assign(:settings, settings)
       |> assign(:custom_fields_visible, custom_fields_visible)
       |> assign(:all_custom_fields, all_custom_fields)
@@ -106,6 +108,7 @@ defmodule MvWeb.MemberLive.Index do
         :member_fields_visible,
         FieldVisibility.get_visible_member_fields(initial_selection)
       )
+      |> assign(:member_fields_visible, get_visible_member_fields(settings))
 
     # We call handle params to use the query from the URL
     {:ok, socket}
@@ -137,10 +140,10 @@ defmodule MvWeb.MemberLive.Index do
   @impl true
   def handle_event("select_member", %{"id" => id}, socket) do
     selected =
-      if id in socket.assigns.selected_members do
-        List.delete(socket.assigns.selected_members, id)
+      if MapSet.member?(socket.assigns.selected_members, id) do
+        MapSet.delete(socket.assigns.selected_members, id)
       else
-        [id | socket.assigns.selected_members]
+        MapSet.put(socket.assigns.selected_members, id)
       end
 
     {:noreply, assign(socket, :selected_members, selected)}
@@ -148,13 +151,11 @@ defmodule MvWeb.MemberLive.Index do
 
   @impl true
   def handle_event("select_all", _params, socket) do
-    members = socket.assigns.members
-
-    all_ids = Enum.map(members, & &1.id)
+    all_ids = socket.assigns.members |> Enum.map(& &1.id) |> MapSet.new()
 
     selected =
-      if Enum.sort(socket.assigns.selected_members) == Enum.sort(all_ids) do
-        []
+      if MapSet.equal?(socket.assigns.selected_members, all_ids) do
+        MapSet.new()
       else
         all_ids
       end
@@ -162,6 +163,52 @@ defmodule MvWeb.MemberLive.Index do
     {:noreply, assign(socket, :selected_members, selected)}
   end
 
+  @impl true
+  def handle_event("copy_emails", _params, socket) do
+    selected_ids = socket.assigns.selected_members
+
+    # Filter members that are in the selection and have email addresses
+    formatted_emails =
+      socket.assigns.members
+      |> Enum.filter(fn member ->
+        MapSet.member?(selected_ids, member.id) && member.email && member.email != ""
+      end)
+      |> Enum.map(&format_member_email/1)
+
+    email_count = length(formatted_emails)
+
+    cond do
+      MapSet.size(selected_ids) == 0 ->
+        {:noreply, put_flash(socket, :error, gettext("No members selected"))}
+
+      email_count == 0 ->
+        {:noreply, put_flash(socket, :error, gettext("No email addresses found"))}
+
+      true ->
+        # RFC 5322 uses comma as separator for email address lists
+        email_string = Enum.join(formatted_emails, ", ")
+
+        socket =
+          socket
+          |> push_event("copy_to_clipboard", %{text: email_string})
+          |> put_flash(
+            :success,
+            ngettext(
+              "Copied %{count} email address to clipboard",
+              "Copied %{count} email addresses to clipboard",
+              email_count,
+              count: email_count
+            )
+          )
+          |> put_flash(
+            :warning,
+            gettext("Tip: Paste email addresses into the BCC field for privacy compliance")
+          )
+
+        {:noreply, socket}
+    end
+  end
+
   # -----------------------------------------------------------------
   # Handle Infos from Child Components
   # -----------------------------------------------------------------
@@ -194,22 +241,17 @@ defmodule MvWeb.MemberLive.Index do
 
   @impl true
   def handle_info({:search_changed, q}, socket) do
-    # Update query assign first
-    socket = assign(socket, :query, q)
-
-    # Load members with the new query
-    socket = load_members(socket, q)
+    socket =
+      socket
+      |> assign(:query, q)
+      |> load_members()
 
     existing_field_query = socket.assigns.sort_field
     existing_sort_query = socket.assigns.sort_order
 
     # Build the URL with queries
     query_params =
-      build_query_params(socket, %{
-        "query" => q,
-        "sort_field" => existing_field_query,
-        "sort_order" => existing_sort_query
-      })
+      build_query_params(q, existing_field_query, existing_sort_query, socket.assigns.paid_filter)
 
     # Set the new path with params
     new_path = ~p"/members?#{query_params}"
@@ -222,6 +264,31 @@ defmodule MvWeb.MemberLive.Index do
      )}
   end
 
+  @impl true
+  def handle_info({:payment_filter_changed, filter}, socket) do
+    socket =
+      socket
+      |> assign(:paid_filter, filter)
+      |> load_members()
+
+    # Build the URL with all params including new filter
+    query_params =
+      build_query_params(
+        socket.assigns.query,
+        socket.assigns.sort_field,
+        socket.assigns.sort_order,
+        filter
+      )
+
+    new_path = ~p"/members?#{query_params}"
+
+    {:noreply,
+     push_patch(socket,
+       to: new_path,
+       replace: true
+     )}
+  end
+
   @impl true
   def handle_info({:field_toggled, field_string, visible}, socket) do
     # Update user field selection
@@ -289,7 +356,7 @@ defmodule MvWeb.MemberLive.Index do
   @doc """
   Handles URL parameter changes.
 
-  Parses query parameters for search query, sort field, sort order, and field selection,
+  Parses query parameters for search query, sort field, sort order, and payment filter,  and field selection,
   then loads members accordingly. This enables bookmarkable URLs and
   browser back/forward navigation.
   """
@@ -322,10 +389,12 @@ defmodule MvWeb.MemberLive.Index do
       socket
       |> maybe_update_search(params)
       |> maybe_update_sort(params)
+      |> maybe_update_paid_filter(params)
+      |> assign(:query, params["query"])
       |> assign(:user_field_selection, final_selection)
       |> assign(:member_fields_visible, visible_member_fields)
       |> assign(:visible_custom_field_ids, extract_custom_field_ids(visible_custom_fields))
-      |> load_members(params["query"])
+      |> load_members()
       |> prepare_dynamic_cols()
 
     {:noreply, socket}
@@ -423,10 +492,12 @@ defmodule MvWeb.MemberLive.Index do
       end
 
     query_params =
-      build_query_params(socket, %{
-        "sort_field" => field_str,
-        "sort_order" => Atom.to_string(order)
-      })
+      build_query_params(
+        socket.assigns.query,
+        field_str,
+        Atom.to_string(order),
+        socket.assigns.paid_filter
+      )
 
     new_path = ~p"/members?#{query_params}"
 
@@ -481,13 +552,45 @@ defmodule MvWeb.MemberLive.Index do
     assign(socket, :user_field_selection, selection)
   end
 
-  # Loads members from the database with custom field values and applies search/sort filters.
+  # Builds URL query parameters map including all filter/sort state.
+  # Converts paid_filter atom to string for URL.
+  defp build_query_params(query, sort_field, sort_order, paid_filter) do
+    field_str =
+      if is_atom(sort_field) do
+        Atom.to_string(sort_field)
+      else
+        sort_field
+      end
+
+    order_str =
+      if is_atom(sort_order) do
+        Atom.to_string(sort_order)
+      else
+        sort_order
+      end
+
+    base_params = %{
+      "query" => query,
+      "sort_field" => field_str,
+      "sort_order" => order_str
+    }
+
+    # Only add paid_filter to URL if it's set
+    case paid_filter do
+      nil -> base_params
+      :paid -> Map.put(base_params, "paid_filter", "paid")
+      :not_paid -> Map.put(base_params, "paid_filter", "not_paid")
+    end
+  end
+
+  # Loads members from the database with custom field values and applies search/sort/payment filters.
   #
   # Process:
   # 1. Builds base query with selected fields
   # 2. Loads custom field values for visible custom fields (filtered at database level)
   # 3. Applies search filter if provided
-  # 4. Applies sorting (database-level for regular fields, in-memory for custom fields)
+  # 4. Applies payment status filter if set
+  # 5. Applies sorting (database-level for regular fields, in-memory for custom fields)
   #
   # Performance Considerations:
   # - Database-level filtering: Custom field values are filtered directly in the database
@@ -499,7 +602,9 @@ defmodule MvWeb.MemberLive.Index do
   #   consider implementing pagination (see Issue #165).
   #
   # Returns the socket with `:members` assigned.
-  defp load_members(socket, search_query) do
+  defp load_members(socket) do
+    search_query = socket.assigns.query
+
     query =
       Mv.Membership.Member
       |> Ash.Query.new()
@@ -512,6 +617,9 @@ defmodule MvWeb.MemberLive.Index do
     # Apply the search filter first
     query = apply_search_filter(query, search_query)
 
+    # Apply payment status filter
+    query = apply_paid_filter(query, socket.assigns.paid_filter)
+
     # Apply sorting based on current socket state
     # For custom fields, we sort after loading
     {query, sort_after_load} =
@@ -586,6 +694,24 @@ defmodule MvWeb.MemberLive.Index do
     end
   end
 
+  # Applies payment status filter to the query.
+  #
+  # Filter values:
+  # - nil: No filter, return all members
+  # - :paid: Only members with paid == true
+  # - :not_paid: Members with paid == false or paid == nil (not paid)
+  defp apply_paid_filter(query, nil), do: query
+
+  defp apply_paid_filter(query, :paid) do
+    Ash.Query.filter(query, expr(paid == true))
+  end
+
+  defp apply_paid_filter(query, :not_paid) do
+    # Include both false and nil as "not paid"
+    # Note: paid != true doesn't work correctly with NULL values in SQL
+    Ash.Query.filter(query, expr(paid == false or is_nil(paid)))
+  end
+
   # Functions to toggle sorting order
   defp toggle_order(:asc), do: :desc
   defp toggle_order(:desc), do: :asc
@@ -876,6 +1002,29 @@ defmodule MvWeb.MemberLive.Index do
     socket
   end
 
+  # Updates paid filter from URL parameters if present.
+  #
+  # Validates the filter value, falling back to nil (no filter) if invalid.
+  defp maybe_update_paid_filter(socket, %{"paid_filter" => filter_str}) do
+    filter = determine_paid_filter(filter_str)
+    assign(socket, :paid_filter, filter)
+  end
+
+  defp maybe_update_paid_filter(socket, _params) do
+    # Reset filter if not in URL params
+    assign(socket, :paid_filter, nil)
+  end
+
+  # Determines valid paid filter from URL parameter.
+  #
+  # SECURITY: This function whitelists allowed filter values. Only "paid" and "not_paid"
+  # are accepted - all other input (including malicious strings) falls back to nil.
+  # This ensures no raw user input is ever passed to Ash.Query.filter/2, following
+  # Ash's security recommendation to never pass untrusted input directly to filters.
+  defp determine_paid_filter("paid"), do: :paid
+  defp determine_paid_filter("not_paid"), do: :not_paid
+  defp determine_paid_filter(_), do: nil
+
   # -------------------------------------------------------------
   # Helper Functions for Custom Field Values
   # -------------------------------------------------------------
@@ -908,11 +1057,28 @@ defmodule MvWeb.MemberLive.Index do
     end
   end
 
-  # Gets the configuration for all member fields with their show_in_overview values.
+  # Formats a member's email in the format "First Last <email>"
+  # Used for copy_emails feature to create email-client-friendly format.
+  defp format_member_email(member) do
+    first_name = member.first_name || ""
+    last_name = member.last_name || ""
+
+    name =
+      [first_name, last_name]
+      |> Enum.filter(&(&1 != ""))
+      |> Enum.join(" ")
+
+    if name == "" do
+      member.email
+    else
+      "#{name} <#{member.email}>"
+    end
+  end
+
+  # Gets the list of member fields that should be visible in the overview.
   #
-  # Reads the visibility configuration from Settings and returns a map with all member fields
-  # and their show_in_overview values (true or false). Fields not configured in settings
-  # default to true.
+  # Reads the visibility configuration from Settings and returns only the fields
+  # where show_in_overview is true. Fields not configured in settings default to true.
   #
   # Performance: This function uses the already-loaded settings to avoid N+1 queries.
   # Settings should be loaded once in mount/3 and passed to this function.
@@ -920,62 +1086,20 @@ defmodule MvWeb.MemberLive.Index do
   # Parameters:
   #   - `settings` - The settings struct loaded from the database
   #
-  # Returns a map: %{field_name => show_in_overview}
-  #
-  # This can be used for:
-  # - Rendering the overview (filtering visible fields)
-  # - UI configuration dropdowns (showing all fields with their current state)
-  # - Dynamic field management
+  # Returns a list of atoms representing visible member field names.
   #
   # Fields are read from the global Constants module.
-  @spec get_member_field_configurations(map()) :: %{atom() => boolean()}
-  defp get_member_field_configurations(settings) do
+  @spec get_visible_member_fields(map()) :: [atom()]
+  defp get_visible_member_fields(settings) do
     # Get all eligible fields from the global constants
     all_fields = Mv.Constants.member_fields()
 
-    # Normalize visibility config (JSONB may return string keys)
-    visibility_config = normalize_visibility_config(settings.member_field_visibility || %{})
+    # JSONB stores keys as strings
+    visibility_config = settings.member_field_visibility || %{}
 
-    Enum.reduce(all_fields, %{}, fn field, acc ->
-      show_in_overview = Map.get(visibility_config, field, true)
-      Map.put(acc, field, show_in_overview)
+    # Filter to only return visible fields
+    Enum.filter(all_fields, fn field ->
+      Map.get(visibility_config, Atom.to_string(field), true)
     end)
   end
-
-
-  # Normalizes visibility config map keys from strings to atoms.
-  # JSONB in PostgreSQL converts atom keys to string keys when storing.
-  # This is a local helper to avoid N+1 queries by reusing the normalization logic.
-  defp normalize_visibility_config(config) when is_map(config) do
-    Enum.reduce(config, %{}, fn
-      {key, value}, acc when is_atom(key) ->
-        Map.put(acc, key, value)
-
-      {key, value}, acc when is_binary(key) ->
-        try do
-          atom_key = String.to_existing_atom(key)
-          Map.put(acc, atom_key, value)
-        rescue
-          ArgumentError ->
-            acc
-        end
-
-      _, acc ->
-        acc
-    end)
-  end
-
-  defp normalize_visibility_config(_), do: %{}
-
-  # Extracts custom field IDs from visible custom field strings
-  # Format: "custom_field_<id>" -> <id>
-  defp extract_custom_field_ids(visible_custom_fields) do
-    Enum.map(visible_custom_fields, fn field_string ->
-      case String.split(field_string, "custom_field_") do
-        ["", id] -> id
-        _ -> nil
-      end
-    end)
-    |> Enum.filter(&(&1 != nil))
-  end
 end