refactor: integrate approval ui review changes
This commit is contained in:
parent
28f97184b3
commit
f53a3ce3cc
13 changed files with 153 additions and 139 deletions
|
|
@ -44,8 +44,10 @@ defmodule MvWeb.Layouts do
|
|||
|
||||
def app(assigns) do
|
||||
club_name = get_club_name()
|
||||
join_form_enabled = get_join_form_enabled()
|
||||
join_form_enabled = Mv.Membership.join_form_enabled?()
|
||||
|
||||
# TODO: get_join_form_enabled and unprocessed count run on every page load; consider
|
||||
# loading count only on navigation or caching briefly if performance becomes an issue.
|
||||
unprocessed_join_requests_count =
|
||||
get_unprocessed_join_requests_count(assigns.current_user, join_form_enabled)
|
||||
|
||||
|
|
@ -136,13 +138,6 @@ defmodule MvWeb.Layouts do
|
|||
end
|
||||
end
|
||||
|
||||
defp get_join_form_enabled do
|
||||
case Mv.Membership.get_settings() do
|
||||
{:ok, %{join_form_enabled: true}} -> true
|
||||
_ -> false
|
||||
end
|
||||
end
|
||||
|
||||
defp get_unprocessed_join_requests_count(nil, _), do: 0
|
||||
defp get_unprocessed_join_requests_count(_user, false), do: 0
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue